From: Johannes Weiner <hannes@cmpxchg.org>
To: Chris Down <chris@chrisdown.name>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@kernel.org>, Tejun Heo <tj@kernel.org>,
Roman Gushchin <guro@fb.com>, Dennis Zhou <dennis@kernel.org>,
linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
linux-mm@kvack.org, kernel-team@fb.com
Subject: Re: [PATCH v2 1/2] mm: Rename ambiguously named memory.stat counters and functions
Date: Mon, 11 Feb 2019 13:55:35 -0500 [thread overview]
Message-ID: <20190211185535.GB13953@cmpxchg.org> (raw)
In-Reply-To: <20190208224319.GA23801@chrisdown.name>
On Fri, Feb 08, 2019 at 10:43:19PM +0000, Chris Down wrote:
> I spent literally an hour trying to work out why an earlier version of
> my memory.events aggregation code doesn't work properly, only to find
> out I was calling memcg->events instead of memcg->memory_events, which
> is fairly confusing.
>
> This naming seems in need of reworking, so make it harder to do the
> wrong thing by using vmevents instead of events, which makes it more
> clear that these are vm counters rather than memcg-specific counters.
>
> There are also a few other inconsistent names in both the percpu and
> aggregated structs, so these are all cleaned up to be more coherent and
> easy to understand.
>
> This commit contains code cleanup only: there are no logic changes.
>
> Signed-off-by: Chris Down <chris@chrisdown.name>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Michal Hocko <mhocko@kernel.org>
> Cc: Johannes Weiner <hannes@cmpxchg.org>
> Cc: Tejun Heo <tj@kernel.org>
> Cc: Roman Gushchin <guro@fb.com>
> Cc: Dennis Zhou <dennis@kernel.org>
> Cc: linux-kernel@vger.kernel.org
> Cc: cgroups@vger.kernel.org
> Cc: linux-mm@kvack.org
> Cc: kernel-team@fb.com
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
prev parent reply other threads:[~2019-02-11 18:55 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-23 22:31 [PATCH 2/2] mm: Consider subtrees in memory.events Chris Down
2019-01-24 0:24 ` Roman Gushchin
2019-01-24 1:03 ` Chris Down
2019-01-24 8:22 ` Michal Hocko
2019-01-24 15:21 ` Tejun Heo
2019-01-24 15:51 ` Michal Hocko
2019-01-24 16:00 ` Johannes Weiner
2019-01-24 17:01 ` Michal Hocko
2019-01-24 18:23 ` Johannes Weiner
2019-01-25 8:42 ` Michal Hocko
2019-01-25 16:51 ` Tejun Heo
2019-01-25 17:37 ` Michal Hocko
2019-01-25 17:37 ` Michal Hocko
2019-01-25 18:28 ` Tejun Heo
2019-01-28 12:51 ` Michal Hocko
2019-01-28 14:28 ` Tejun Heo
2019-01-28 14:52 ` Michal Hocko
2019-01-28 14:54 ` Tejun Heo
2019-01-28 15:18 ` Michal Hocko
2019-01-28 15:41 ` Tejun Heo
2019-01-28 17:05 ` Michal Hocko
2019-01-28 17:49 ` Tejun Heo
2019-01-29 14:43 ` Michal Hocko
2019-01-29 14:52 ` Tejun Heo
2019-01-30 16:50 ` Michal Hocko
2019-01-30 17:06 ` Tejun Heo
2019-01-30 17:41 ` Michal Hocko
2019-01-30 17:52 ` Tejun Heo
2019-01-30 18:16 ` Michal Hocko
2019-01-30 19:11 ` Shakeel Butt
2019-01-30 19:27 ` Johannes Weiner
2019-01-30 19:30 ` Johannes Weiner
2019-01-30 19:37 ` Shakeel Butt
2019-01-30 19:23 ` Johannes Weiner
2019-01-30 20:05 ` Michal Hocko
2019-01-30 21:31 ` Johannes Weiner
2019-01-31 8:58 ` Michal Hocko
2019-01-31 16:22 ` Johannes Weiner
2019-02-01 10:27 ` Michal Hocko
2019-02-01 16:34 ` Johannes Weiner
2019-01-28 15:59 ` Shakeel Butt
2019-01-28 16:05 ` Tejun Heo
2019-01-28 16:08 ` Shakeel Butt
2019-01-28 16:12 ` Tejun Heo
2019-01-28 14:30 ` Tejun Heo
2019-02-08 22:43 ` [PATCH v2 1/2] mm: Rename ambiguously named memory.stat counters and functions Chris Down
2019-02-08 22:44 ` [PATCH v2 2/2] mm: Consider subtrees in memory.events Chris Down
2019-02-11 19:01 ` Johannes Weiner
2019-02-11 18:55 ` Johannes Weiner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190211185535.GB13953@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=chris@chrisdown.name \
--cc=dennis@kernel.org \
--cc=guro@fb.com \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.