From: Josh Steadmon <steadmon@google.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] protocol-capabilities.txt: document symref
Date: Mon, 11 Feb 2019 16:07:49 -0800 [thread overview]
Message-ID: <20190212000749.GF72177@google.com> (raw)
In-Reply-To: <20190212000530.GC13301@sigill.intra.peff.net>
On 2019.02.11 19:05, Jeff King wrote:
> On Mon, Feb 11, 2019 at 03:52:24PM -0800, Josh Steadmon wrote:
>
> > In 7171d8c15f ("upload-pack: send symbolic ref information as
> > capability"), we added a symref capability to the pack protocol, but it
> > was never documented. Adapt the patch notes from that commit and add
> > them to the capabilities documentation.
>
> Good catch, and your explanation (especially the SHOULD/MAY bits) looks
> good.
>
> I think this is obsoleted by v2, which will send symref info along with
> each ref. I don't know if it's worth mentioning that here (the v2 docs
> discuss it, but I don't know if this capabilities document is clear
> about which ones apply only to v0).
>
> -Peff
I believe this doc is only for v0/v1. I'll add a note.
next prev parent reply other threads:[~2019-02-12 0:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-11 23:52 [PATCH] protocol-capabilities.txt: document symref Josh Steadmon
2019-02-11 23:58 ` Jonathan Nieder
2019-02-12 0:05 ` Jeff King
2019-02-12 0:07 ` Josh Steadmon [this message]
2019-02-13 23:41 ` [PATCH v2] " Josh Steadmon
2019-02-14 3:56 ` Jeff King
2019-02-20 0:32 ` Josh Steadmon
2019-02-21 17:38 ` Junio C Hamano
2019-02-20 0:32 ` [PATCH v3] " Josh Steadmon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190212000749.GF72177@google.com \
--to=steadmon@google.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.