From: Johan Hovold <johan@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Albert Ou <aou@eecs.berkeley.edu>,
Andreas Schwab <schwab@suse.de>,
Palmer Dabbelt <palmer@sifive.com>,
Johan Hovold <johan@kernel.org>,
linux-kernel@vger.kernel.org, Atish Patra <atish.patra@wdc.com>,
Anup Patel <anup@brainfault.org>,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH 5/5] riscv: use for_each_of_cpu_node iterator
Date: Tue, 12 Feb 2019 09:26:21 +0100 [thread overview]
Message-ID: <20190212082621.GA26912@localhost> (raw)
In-Reply-To: <20190212071339.GL26747@infradead.org>
On Mon, Feb 11, 2019 at 11:13:39PM -0800, Christoph Hellwig wrote:
> On Fri, Jan 18, 2019 at 03:03:08PM +0100, Johan Hovold wrote:
> > Use the new for_each_of_cpu_node() helper to iterate over cpu nodes
> > instead of open coding. Note that this will allow matching also on the
> > node name instead of the (for FDT) deprecated device_type property.
> >
> > Signed-off-by: Johan Hovold <johan@kernel.org>
>
> I think this is going to conflict with the ELF caps changes from
> Atish. Maybe the riscv_fill_hwcap hunk should be included in his
> patch?
Since that patch had some issues (e.g. the node reference underflow) it
may be better to rebase it on top of this series. The changes are
otherwise distinct after all.
> Otherwise looks good:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
Thanks for reviewing!
Johan
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Johan Hovold <johan@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Johan Hovold <johan@kernel.org>,
Palmer Dabbelt <palmer@sifive.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Andreas Schwab <schwab@suse.de>,
linux-kernel@vger.kernel.org, Atish Patra <atish.patra@wdc.com>,
Anup Patel <anup@brainfault.org>,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH 5/5] riscv: use for_each_of_cpu_node iterator
Date: Tue, 12 Feb 2019 09:26:21 +0100 [thread overview]
Message-ID: <20190212082621.GA26912@localhost> (raw)
In-Reply-To: <20190212071339.GL26747@infradead.org>
On Mon, Feb 11, 2019 at 11:13:39PM -0800, Christoph Hellwig wrote:
> On Fri, Jan 18, 2019 at 03:03:08PM +0100, Johan Hovold wrote:
> > Use the new for_each_of_cpu_node() helper to iterate over cpu nodes
> > instead of open coding. Note that this will allow matching also on the
> > node name instead of the (for FDT) deprecated device_type property.
> >
> > Signed-off-by: Johan Hovold <johan@kernel.org>
>
> I think this is going to conflict with the ELF caps changes from
> Atish. Maybe the riscv_fill_hwcap hunk should be included in his
> patch?
Since that patch had some issues (e.g. the node reference underflow) it
may be better to rebase it on top of this series. The changes are
otherwise distinct after all.
> Otherwise looks good:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
Thanks for reviewing!
Johan
next prev parent reply other threads:[~2019-02-12 8:26 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-18 14:03 [PATCH 0/5] riscv: minor fixes and cleanups Johan Hovold
2019-01-18 14:03 ` Johan Hovold
2019-01-18 14:03 ` [PATCH 1/5] riscv: add missing newlines to printk messages Johan Hovold
2019-01-18 14:03 ` Johan Hovold
2019-02-12 7:11 ` Christoph Hellwig
2019-02-12 7:11 ` Christoph Hellwig
2019-01-18 14:03 ` [PATCH 2/5] riscv: use pr_info and friends Johan Hovold
2019-01-18 14:03 ` Johan Hovold
2019-01-19 1:39 ` Paul Walmsley
2019-01-19 1:39 ` Paul Walmsley
2019-02-12 7:11 ` Christoph Hellwig
2019-02-12 7:11 ` Christoph Hellwig
2019-01-18 14:03 ` [PATCH 3/5] riscv: fix riscv_of_processor_hartid() comment Johan Hovold
2019-01-18 14:03 ` Johan Hovold
2019-01-19 1:40 ` Paul Walmsley
2019-01-19 1:40 ` Paul Walmsley
2019-02-12 7:12 ` Christoph Hellwig
2019-02-12 7:12 ` Christoph Hellwig
2019-01-18 14:03 ` [PATCH 4/5] riscv: treat cpu devicetree nodes without status as enabled Johan Hovold
2019-01-18 14:03 ` Johan Hovold
2019-01-19 1:43 ` Paul Walmsley
2019-01-19 1:43 ` Paul Walmsley
2019-01-21 8:59 ` Johan Hovold
2019-01-21 8:59 ` Johan Hovold
2019-02-12 7:12 ` Christoph Hellwig
2019-02-12 7:12 ` Christoph Hellwig
2019-01-18 14:03 ` [PATCH 5/5] riscv: use for_each_of_cpu_node iterator Johan Hovold
2019-01-18 14:03 ` Johan Hovold
2019-02-12 7:13 ` Christoph Hellwig
2019-02-12 7:13 ` Christoph Hellwig
2019-02-12 8:26 ` Johan Hovold [this message]
2019-02-12 8:26 ` Johan Hovold
2019-02-12 8:47 ` Atish Patra
2019-02-12 8:47 ` Atish Patra
2019-02-12 8:53 ` Johan Hovold
2019-02-12 8:53 ` Johan Hovold
2019-02-12 9:20 ` Atish Patra
2019-02-12 9:20 ` Atish Patra
2019-02-11 9:34 ` [PATCH 0/5] riscv: minor fixes and cleanups Johan Hovold
2019-02-11 9:34 ` Johan Hovold
2019-02-11 19:59 ` Palmer Dabbelt
2019-02-11 19:59 ` Palmer Dabbelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190212082621.GA26912@localhost \
--to=johan@kernel.org \
--cc=anup@brainfault.org \
--cc=aou@eecs.berkeley.edu \
--cc=atish.patra@wdc.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@sifive.com \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.