All of lore.kernel.org
 help / color / mirror / Atom feed
* [linux-3.18 bisection] complete test-amd64-amd64-pair
@ 2019-02-12  7:15 osstest service owner
  2019-02-12 11:26 ` Ian Jackson
  0 siblings, 1 reply; 5+ messages in thread
From: osstest service owner @ 2019-02-12  7:15 UTC (permalink / raw)
  To: xen-devel, osstest-admin

branch xen-unstable
xenbranch xen-unstable
job test-amd64-amd64-pair
testid xen-boot/dst_host

Tree: linux git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git
Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git
Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git
Tree: qemuu git://xenbits.xen.org/qemu-xen.git
Tree: xen git://xenbits.xen.org/xen.git

*** Found and reproduced problem changeset ***

  Bug is in tree:  linux git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git
  Bug introduced:  7b8052e19304865477e03a0047062d977309a22f
  Bug not present: d255d18a34a8d53ccc4a019dc07e17b6e8cf6bd1
  Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/131278/


  commit 7b8052e19304865477e03a0047062d977309a22f
  Author: Jan Beulich <JBeulich@suse.com>
  Date:   Mon Oct 19 04:23:29 2015 -0600
  
      igb: fix NULL derefs due to skipped SR-IOV enabling
      
      [ Upstream commit be06998f96ecb93938ad2cce46c4289bf7cf45bc ]
      
      The combined effect of commits 6423fc3416 ("igb: do not re-init SR-IOV
      during probe") and ceee3450b3 ("igb: make sure SR-IOV init uses the
      right number of queues") causes VFs no longer getting set up, leading
      to NULL pointer dereferences due to the adapter's ->vf_data being NULL
      while ->vfs_allocated_count is non-zero. The first commit not only
      neglected the side effect of igb_sriov_reinit() that the second commit
      tried to account for, but also that of setting IGB_FLAG_HAS_MSIX,
      without which igb_enable_sriov() is effectively a no-op. Calling
      igb_{,re}set_interrupt_capability() as done here seems to address this,
      but I'm not sure whether this is better than sinply reverting the other
      two commits.
      
      Signed-off-by: Jan Beulich <jbeulich@suse.com>
      Tested-by: Aaron Brown <aaron.f.brown@intel.com>
      Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
      Signed-off-by: Sasha Levin <sashal@kernel.org>


For bisection revision-tuple graph see:
   http://logs.test-lab.xenproject.org/osstest/results/bisect/linux-3.18/test-amd64-amd64-pair.xen-boot--dst_host.html
Revision IDs in each graph node refer, respectively, to the Trees above.

----------------------------------------
Running cs-bisection-step --graph-out=/home/logs/results/bisect/linux-3.18/test-amd64-amd64-pair.xen-boot--dst_host --summary-out=tmp/133184.bisection-summary --basis-template=128858 --blessings=real,real-bisect --flight=133184 linux-3.18 test-amd64-amd64-pair xen-boot/dst_host
Searching for failure / basis pass:
 132969 fail [dst_host=debina1,src_host=debina0] / 132456 [dst_host=baroque1,src_host=baroque0] 130367 [dst_host=albana0,src_host=albana1] 130203 [dst_host=albana0,src_host=albana1] 130067 [dst_host=pinot1,src_host=pinot0] 129845 [dst_host=albana1,src_host=albana0] 129760 [dst_host=godello1,src_host=godello0] 128858 [dst_host=elbling0,src_host=elbling1] 128841 [dst_host=elbling0,src_host=elbling1] 128807 [dst_host=godello1,src_host=godello0] 128691 [dst_host=fiano1,src_host=fiano0] 128258 [dst_h\
 ost=fiano1,src_host=fiano0] 128232 [dst_host=albana1,src_host=albana0] 128177 ok.
Failure / basis pass flights: 132969 / 128177
(tree with no url: minios)
(tree with no url: ovmf)
(tree with no url: seabios)
Tree: linux git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git
Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git
Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git
Tree: qemuu git://xenbits.xen.org/qemu-xen.git
Tree: xen git://xenbits.xen.org/xen.git
Latest 4c35624dcb3bce026bb08eb04085c187bafff863 c530a75c1e6a472b0eb9558310b518f0dfcd8860 d0d8ad39ecb51cd7497cd524484fe09f50876798 de5b678ca4dcdfa83e322491d478d66df56c1986 755eb6403ec722db37f1b8f8b51e0b0ab661c003
Basis pass 921b2fed6a79439ef1609ef4af0ada5cccb3555c c530a75c1e6a472b0eb9558310b518f0dfcd8860 9c0eed618f37dd5b4a57c8b3fbc48ef8913e3149 de5b678ca4dcdfa83e322491d478d66df56c1986 940185b2f6f343251c2b83bd96e599398cea51ec
Generating revisions with ./adhoc-revtuple-generator  git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git#921b2fed6a79439ef1609ef4af0ada5cccb3555c-4c35624dcb3bce026bb08eb04085c187bafff863 git://xenbits.xen.org/osstest/linux-firmware.git#c530a75c1e6a472b0eb9558310b518f0dfcd8860-c530a75c1e6a472b0eb9558310b518f0dfcd8860 git://xenbits.xen.org/qemu-xen-traditional.git#9c0eed618f37dd5b4a57c8b3fbc48ef8913e3149-d0d8ad39ecb51cd7497cd524484fe09f50876798 git://xenbits.xen.org/qemu-xen.git\
 #de5b678ca4dcdfa83e322491d478d66df56c1986-de5b678ca4dcdfa83e322491d478d66df56c1986 git://xenbits.xen.org/xen.git#940185b2f6f343251c2b83bd96e599398cea51ec-755eb6403ec722db37f1b8f8b51e0b0ab661c003
Loaded 3004 nodes in revision graph
Searching for test results:
 128691 [dst_host=fiano1,src_host=fiano0]
 128807 [dst_host=godello1,src_host=godello0]
 128858 [dst_host=elbling0,src_host=elbling1]
 128841 [dst_host=elbling0,src_host=elbling1]
 129760 [dst_host=godello1,src_host=godello0]
 129845 [dst_host=albana1,src_host=albana0]
 130067 [dst_host=pinot1,src_host=pinot0]
 130203 [dst_host=albana0,src_host=albana1]
 130367 [dst_host=albana0,src_host=albana1]
 130843 fail irrelevant
 130876 fail irrelevant
 130939 fail irrelevant
 131095 fail 3879c163e8681939b1d93139521aee983623884f c530a75c1e6a472b0eb9558310b518f0dfcd8860 d0d8ad39ecb51cd7497cd524484fe09f50876798 de5b678ca4dcdfa83e322491d478d66df56c1986 82855aba5bf91e50c81526167c11d4aeaf665e66
 131035 fail irrelevant
 131149 fail 3879c163e8681939b1d93139521aee983623884f c530a75c1e6a472b0eb9558310b518f0dfcd8860 d0d8ad39ecb51cd7497cd524484fe09f50876798 de5b678ca4dcdfa83e322491d478d66df56c1986 82855aba5bf91e50c81526167c11d4aeaf665e66
 131192 fail 3879c163e8681939b1d93139521aee983623884f c530a75c1e6a472b0eb9558310b518f0dfcd8860 d0d8ad39ecb51cd7497cd524484fe09f50876798 de5b678ca4dcdfa83e322491d478d66df56c1986 82855aba5bf91e50c81526167c11d4aeaf665e66
 131271 pass d255d18a34a8d53ccc4a019dc07e17b6e8cf6bd1 c530a75c1e6a472b0eb9558310b518f0dfcd8860 d0d8ad39ecb51cd7497cd524484fe09f50876798 de5b678ca4dcdfa83e322491d478d66df56c1986 6d8ffac1f7a782dc2c7f8df3871a294729ae36bd
 131272 fail 7b8052e19304865477e03a0047062d977309a22f c530a75c1e6a472b0eb9558310b518f0dfcd8860 d0d8ad39ecb51cd7497cd524484fe09f50876798 de5b678ca4dcdfa83e322491d478d66df56c1986 6d8ffac1f7a782dc2c7f8df3871a294729ae36bd
 131279 fail 3879c163e8681939b1d93139521aee983623884f c530a75c1e6a472b0eb9558310b518f0dfcd8860 d0d8ad39ecb51cd7497cd524484fe09f50876798 de5b678ca4dcdfa83e322491d478d66df56c1986 82855aba5bf91e50c81526167c11d4aeaf665e66
 131254 pass 921b2fed6a79439ef1609ef4af0ada5cccb3555c c530a75c1e6a472b0eb9558310b518f0dfcd8860 9c0eed618f37dd5b4a57c8b3fbc48ef8913e3149 de5b678ca4dcdfa83e322491d478d66df56c1986 940185b2f6f343251c2b83bd96e599398cea51ec
 131258 fail 3879c163e8681939b1d93139521aee983623884f c530a75c1e6a472b0eb9558310b518f0dfcd8860 d0d8ad39ecb51cd7497cd524484fe09f50876798 de5b678ca4dcdfa83e322491d478d66df56c1986 82855aba5bf91e50c81526167c11d4aeaf665e66
 131273 pass d255d18a34a8d53ccc4a019dc07e17b6e8cf6bd1 c530a75c1e6a472b0eb9558310b518f0dfcd8860 d0d8ad39ecb51cd7497cd524484fe09f50876798 de5b678ca4dcdfa83e322491d478d66df56c1986 6d8ffac1f7a782dc2c7f8df3871a294729ae36bd
 131259 pass 17a4b61833db0fd17164dfa7762cf6354d794e3f c530a75c1e6a472b0eb9558310b518f0dfcd8860 d0d8ad39ecb51cd7497cd524484fe09f50876798 de5b678ca4dcdfa83e322491d478d66df56c1986 6d8ffac1f7a782dc2c7f8df3871a294729ae36bd
 131260 blocked 50057d1de0173052ef90783eee8b49287c5a7aff c530a75c1e6a472b0eb9558310b518f0dfcd8860 d0d8ad39ecb51cd7497cd524484fe09f50876798 de5b678ca4dcdfa83e322491d478d66df56c1986 568653e01b84be5ac15fbf949bbcffcd91d6e829
 131231 fail 3879c163e8681939b1d93139521aee983623884f c530a75c1e6a472b0eb9558310b518f0dfcd8860 d0d8ad39ecb51cd7497cd524484fe09f50876798 de5b678ca4dcdfa83e322491d478d66df56c1986 82855aba5bf91e50c81526167c11d4aeaf665e66
 131261 fail 78e0897dd8b321ba1b4a2137778ab7ae7d400af5 c530a75c1e6a472b0eb9558310b518f0dfcd8860 d0d8ad39ecb51cd7497cd524484fe09f50876798 de5b678ca4dcdfa83e322491d478d66df56c1986 84f08707182dc240156f30540517beecbf5918b4
 131275 fail 7b8052e19304865477e03a0047062d977309a22f c530a75c1e6a472b0eb9558310b518f0dfcd8860 d0d8ad39ecb51cd7497cd524484fe09f50876798 de5b678ca4dcdfa83e322491d478d66df56c1986 6d8ffac1f7a782dc2c7f8df3871a294729ae36bd
 131277 pass d255d18a34a8d53ccc4a019dc07e17b6e8cf6bd1 c530a75c1e6a472b0eb9558310b518f0dfcd8860 d0d8ad39ecb51cd7497cd524484fe09f50876798 de5b678ca4dcdfa83e322491d478d66df56c1986 6d8ffac1f7a782dc2c7f8df3871a294729ae36bd
 131262 fail 7b8052e19304865477e03a0047062d977309a22f c530a75c1e6a472b0eb9558310b518f0dfcd8860 d0d8ad39ecb51cd7497cd524484fe09f50876798 de5b678ca4dcdfa83e322491d478d66df56c1986 6d8ffac1f7a782dc2c7f8df3871a294729ae36bd
 131266 pass aa4b7331d3121555088cddc4de0c819768961d46 c530a75c1e6a472b0eb9558310b518f0dfcd8860 d0d8ad39ecb51cd7497cd524484fe09f50876798 de5b678ca4dcdfa83e322491d478d66df56c1986 6d8ffac1f7a782dc2c7f8df3871a294729ae36bd
 131267 pass 21bfce667e8afb19265e65309af2a44737293f92 c530a75c1e6a472b0eb9558310b518f0dfcd8860 d0d8ad39ecb51cd7497cd524484fe09f50876798 de5b678ca4dcdfa83e322491d478d66df56c1986 6d8ffac1f7a782dc2c7f8df3871a294729ae36bd
 131268 pass 1c857dc0e69fdba81e5169cf4b3d2a9daaa783eb c530a75c1e6a472b0eb9558310b518f0dfcd8860 d0d8ad39ecb51cd7497cd524484fe09f50876798 de5b678ca4dcdfa83e322491d478d66df56c1986 6d8ffac1f7a782dc2c7f8df3871a294729ae36bd
 131278 fail 7b8052e19304865477e03a0047062d977309a22f c530a75c1e6a472b0eb9558310b518f0dfcd8860 d0d8ad39ecb51cd7497cd524484fe09f50876798 de5b678ca4dcdfa83e322491d478d66df56c1986 6d8ffac1f7a782dc2c7f8df3871a294729ae36bd
 131269 pass ce2c2e07337e98eb42904ef27c3ce62972d22a60 c530a75c1e6a472b0eb9558310b518f0dfcd8860 d0d8ad39ecb51cd7497cd524484fe09f50876798 de5b678ca4dcdfa83e322491d478d66df56c1986 6d8ffac1f7a782dc2c7f8df3871a294729ae36bd
 131270 pass 61fde28f92ab9a329ef06e0ab3f41269e3930213 c530a75c1e6a472b0eb9558310b518f0dfcd8860 d0d8ad39ecb51cd7497cd524484fe09f50876798 de5b678ca4dcdfa83e322491d478d66df56c1986 6d8ffac1f7a782dc2c7f8df3871a294729ae36bd
 131307 fail irrelevant
 131336 fail irrelevant
 131420 fail irrelevant
 131370 fail irrelevant
 131442 fail irrelevant
 131479 fail 49a6ef532c77a869ac776d7764e1cf46755faba2 c530a75c1e6a472b0eb9558310b518f0dfcd8860 d0d8ad39ecb51cd7497cd524484fe09f50876798 de5b678ca4dcdfa83e322491d478d66df56c1986 3fd3fda9c26fc3c4f77250f795ed7ff9d38e2ec6
 131512 fail irrelevant
 131535 fail irrelevant
 131563 fail fa42fea0d8b49ba65b49a999331950d74827a52d c530a75c1e6a472b0eb9558310b518f0dfcd8860 d0d8ad39ecb51cd7497cd524484fe09f50876798 de5b678ca4dcdfa83e322491d478d66df56c1986 9d357cbaf74f0c1dc85a16498dac6d819743ce38
 131580 fail fa42fea0d8b49ba65b49a999331950d74827a52d c530a75c1e6a472b0eb9558310b518f0dfcd8860 d0d8ad39ecb51cd7497cd524484fe09f50876798 de5b678ca4dcdfa83e322491d478d66df56c1986 9d357cbaf74f0c1dc85a16498dac6d819743ce38
 131593 fail fa42fea0d8b49ba65b49a999331950d74827a52d c530a75c1e6a472b0eb9558310b518f0dfcd8860 d0d8ad39ecb51cd7497cd524484fe09f50876798 de5b678ca4dcdfa83e322491d478d66df56c1986 7f28661f6a7ce3d82f881b9afedfebca7f2cf116
 131641 fail fa42fea0d8b49ba65b49a999331950d74827a52d c530a75c1e6a472b0eb9558310b518f0dfcd8860 d0d8ad39ecb51cd7497cd524484fe09f50876798 de5b678ca4dcdfa83e322491d478d66df56c1986 626c9bde57b540efea5ddfce7f148baeda435869
 131619 fail fa42fea0d8b49ba65b49a999331950d74827a52d c530a75c1e6a472b0eb9558310b518f0dfcd8860 d0d8ad39ecb51cd7497cd524484fe09f50876798 de5b678ca4dcdfa83e322491d478d66df56c1986 7f28661f6a7ce3d82f881b9afedfebca7f2cf116
 131666 fail fa42fea0d8b49ba65b49a999331950d74827a52d c530a75c1e6a472b0eb9558310b518f0dfcd8860 d0d8ad39ecb51cd7497cd524484fe09f50876798 de5b678ca4dcdfa83e322491d478d66df56c1986 ae7fc10d2ca5c22e04b8a28becbd1fbf8b44e83a
 131673 fail fa42fea0d8b49ba65b49a999331950d74827a52d c530a75c1e6a472b0eb9558310b518f0dfcd8860 d0d8ad39ecb51cd7497cd524484fe09f50876798 de5b678ca4dcdfa83e322491d478d66df56c1986 ae7fc10d2ca5c22e04b8a28becbd1fbf8b44e83a
 131705 fail fa42fea0d8b49ba65b49a999331950d74827a52d c530a75c1e6a472b0eb9558310b518f0dfcd8860 d0d8ad39ecb51cd7497cd524484fe09f50876798 de5b678ca4dcdfa83e322491d478d66df56c1986 7b6e05c50fc39466fcc685fb6d4216f99af58743
 131749 fail fa42fea0d8b49ba65b49a999331950d74827a52d c530a75c1e6a472b0eb9558310b518f0dfcd8860 d0d8ad39ecb51cd7497cd524484fe09f50876798 de5b678ca4dcdfa83e322491d478d66df56c1986 7b6e05c50fc39466fcc685fb6d4216f99af58743
 131729 fail fa42fea0d8b49ba65b49a999331950d74827a52d c530a75c1e6a472b0eb9558310b518f0dfcd8860 d0d8ad39ecb51cd7497cd524484fe09f50876798 de5b678ca4dcdfa83e322491d478d66df56c1986 7b6e05c50fc39466fcc685fb6d4216f99af58743
 131769 fail fa42fea0d8b49ba65b49a999331950d74827a52d c530a75c1e6a472b0eb9558310b518f0dfcd8860 d0d8ad39ecb51cd7497cd524484fe09f50876798 de5b678ca4dcdfa83e322491d478d66df56c1986 a5b0eb363694e7e15405f0b3fc5fb6fab79df1db
 131990 fail 9b5eed105a45ac0557af113b4096132ae7e3e47f c530a75c1e6a472b0eb9558310b518f0dfcd8860 d0d8ad39ecb51cd7497cd524484fe09f50876798 de5b678ca4dcdfa83e322491d478d66df56c1986 93a62c544e20ba9e141e411bbaae3d65259d13a3
 131969 fail irrelevant
 132066 fail 9b5eed105a45ac0557af113b4096132ae7e3e47f c530a75c1e6a472b0eb9558310b518f0dfcd8860 d0d8ad39ecb51cd7497cd524484fe09f50876798 de5b678ca4dcdfa83e322491d478d66df56c1986 93a62c544e20ba9e141e411bbaae3d65259d13a3
 132179 fail 9b5eed105a45ac0557af113b4096132ae7e3e47f c530a75c1e6a472b0eb9558310b518f0dfcd8860 d0d8ad39ecb51cd7497cd524484fe09f50876798 de5b678ca4dcdfa83e322491d478d66df56c1986 93a62c544e20ba9e141e411bbaae3d65259d13a3
 132290 fail 9b5eed105a45ac0557af113b4096132ae7e3e47f c530a75c1e6a472b0eb9558310b518f0dfcd8860 d0d8ad39ecb51cd7497cd524484fe09f50876798 de5b678ca4dcdfa83e322491d478d66df56c1986 1912f1220cf87aee28349469893f101980714a05
 132408 fail 9b5eed105a45ac0557af113b4096132ae7e3e47f c530a75c1e6a472b0eb9558310b518f0dfcd8860 d0d8ad39ecb51cd7497cd524484fe09f50876798 de5b678ca4dcdfa83e322491d478d66df56c1986 1912f1220cf87aee28349469893f101980714a05
 132456 [dst_host=baroque1,src_host=baroque0]
 132579 fail irrelevant
 132652 fail irrelevant
 132741 fail 4c35624dcb3bce026bb08eb04085c187bafff863 c530a75c1e6a472b0eb9558310b518f0dfcd8860 d0d8ad39ecb51cd7497cd524484fe09f50876798 de5b678ca4dcdfa83e322491d478d66df56c1986 f50dd67950ca9d5a517501af10de7c8d88d1a188
 132798 fail 4c35624dcb3bce026bb08eb04085c187bafff863 c530a75c1e6a472b0eb9558310b518f0dfcd8860 d0d8ad39ecb51cd7497cd524484fe09f50876798 de5b678ca4dcdfa83e322491d478d66df56c1986 f50dd67950ca9d5a517501af10de7c8d88d1a188
 132969 fail 4c35624dcb3bce026bb08eb04085c187bafff863 c530a75c1e6a472b0eb9558310b518f0dfcd8860 d0d8ad39ecb51cd7497cd524484fe09f50876798 de5b678ca4dcdfa83e322491d478d66df56c1986 755eb6403ec722db37f1b8f8b51e0b0ab661c003
 133181 pass 921b2fed6a79439ef1609ef4af0ada5cccb3555c c530a75c1e6a472b0eb9558310b518f0dfcd8860 9c0eed618f37dd5b4a57c8b3fbc48ef8913e3149 de5b678ca4dcdfa83e322491d478d66df56c1986 940185b2f6f343251c2b83bd96e599398cea51ec
 133182 fail 4c35624dcb3bce026bb08eb04085c187bafff863 c530a75c1e6a472b0eb9558310b518f0dfcd8860 d0d8ad39ecb51cd7497cd524484fe09f50876798 de5b678ca4dcdfa83e322491d478d66df56c1986 755eb6403ec722db37f1b8f8b51e0b0ab661c003
 128096 [dst_host=chardonnay1,src_host=chardonnay0]
 128177 pass 921b2fed6a79439ef1609ef4af0ada5cccb3555c c530a75c1e6a472b0eb9558310b518f0dfcd8860 9c0eed618f37dd5b4a57c8b3fbc48ef8913e3149 de5b678ca4dcdfa83e322491d478d66df56c1986 940185b2f6f343251c2b83bd96e599398cea51ec
 128232 [dst_host=albana1,src_host=albana0]
 128258 [dst_host=fiano1,src_host=fiano0]
Searching for interesting versions
 Result found: flight 128177 (pass), for basis pass
 Result found: flight 132969 (fail), for basis failure
 Repro found: flight 133181 (pass), for basis pass
 Repro found: flight 133182 (fail), for basis failure
 0 revisions at d255d18a34a8d53ccc4a019dc07e17b6e8cf6bd1 c530a75c1e6a472b0eb9558310b518f0dfcd8860 d0d8ad39ecb51cd7497cd524484fe09f50876798 de5b678ca4dcdfa83e322491d478d66df56c1986 6d8ffac1f7a782dc2c7f8df3871a294729ae36bd
No revisions left to test, checking graph state.
 Result found: flight 131271 (pass), for last pass
 Result found: flight 131272 (fail), for first failure
 Repro found: flight 131273 (pass), for last pass
 Repro found: flight 131275 (fail), for first failure
 Repro found: flight 131277 (pass), for last pass
 Repro found: flight 131278 (fail), for first failure

*** Found and reproduced problem changeset ***

  Bug is in tree:  linux git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git
  Bug introduced:  7b8052e19304865477e03a0047062d977309a22f
  Bug not present: d255d18a34a8d53ccc4a019dc07e17b6e8cf6bd1
  Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/131278/


  commit 7b8052e19304865477e03a0047062d977309a22f
  Author: Jan Beulich <JBeulich@suse.com>
  Date:   Mon Oct 19 04:23:29 2015 -0600
  
      igb: fix NULL derefs due to skipped SR-IOV enabling
      
      [ Upstream commit be06998f96ecb93938ad2cce46c4289bf7cf45bc ]
      
      The combined effect of commits 6423fc3416 ("igb: do not re-init SR-IOV
      during probe") and ceee3450b3 ("igb: make sure SR-IOV init uses the
      right number of queues") causes VFs no longer getting set up, leading
      to NULL pointer dereferences due to the adapter's ->vf_data being NULL
      while ->vfs_allocated_count is non-zero. The first commit not only
      neglected the side effect of igb_sriov_reinit() that the second commit
      tried to account for, but also that of setting IGB_FLAG_HAS_MSIX,
      without which igb_enable_sriov() is effectively a no-op. Calling
      igb_{,re}set_interrupt_capability() as done here seems to address this,
      but I'm not sure whether this is better than sinply reverting the other
      two commits.
      
      Signed-off-by: Jan Beulich <jbeulich@suse.com>
      Tested-by: Aaron Brown <aaron.f.brown@intel.com>
      Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
      Signed-off-by: Sasha Levin <sashal@kernel.org>

dot: graph is too large for cairo-renderer bitmaps. Scaling by 0.41419 to fit
pnmtopng: 82 colors found
Revision graph left in /home/logs/results/bisect/linux-3.18/test-amd64-amd64-pair.xen-boot--dst_host.{dot,ps,png,html,svg}.
No revision to test.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [linux-3.18 bisection] complete test-amd64-amd64-pair
  2019-02-12  7:15 [linux-3.18 bisection] complete test-amd64-amd64-pair osstest service owner
@ 2019-02-12 11:26 ` Ian Jackson
  2019-02-12 11:39   ` Jan Beulich
  0 siblings, 1 reply; 5+ messages in thread
From: Ian Jackson @ 2019-02-12 11:26 UTC (permalink / raw)
  To: Jan Beulich; +Cc: Sasha Levin, xen-devel, Aaron Brown, Jeff Kirsher

Jan, are you investigating this regression ?

osstest service owner writes ("[linux-3.18 bisection] complete test-amd64-amd64-pair"):
> branch xen-unstable
> xenbranch xen-unstable
> job test-amd64-amd64-pair
> testid xen-boot/dst_host
> 
> Tree: linux git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git
> Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git
> Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git
> Tree: qemuu git://xenbits.xen.org/qemu-xen.git
> Tree: xen git://xenbits.xen.org/xen.git
> 
> *** Found and reproduced problem changeset ***
> 
>   Bug is in tree:  linux git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git
>   Bug introduced:  7b8052e19304865477e03a0047062d977309a22f
>   Bug not present: d255d18a34a8d53ccc4a019dc07e17b6e8cf6bd1
>   Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/131278/
> 
> 
>   commit 7b8052e19304865477e03a0047062d977309a22f
>   Author: Jan Beulich <JBeulich@suse.com>
>   Date:   Mon Oct 19 04:23:29 2015 -0600
>   
>       igb: fix NULL derefs due to skipped SR-IOV enabling
>       
>       [ Upstream commit be06998f96ecb93938ad2cce46c4289bf7cf45bc ]
>       
>       The combined effect of commits 6423fc3416 ("igb: do not re-init SR-IOV
>       during probe") and ceee3450b3 ("igb: make sure SR-IOV init uses the
>       right number of queues") causes VFs no longer getting set up, leading
>       to NULL pointer dereferences due to the adapter's ->vf_data being NULL
>       while ->vfs_allocated_count is non-zero. The first commit not only
>       neglected the side effect of igb_sriov_reinit() that the second commit
>       tried to account for, but also that of setting IGB_FLAG_HAS_MSIX,
>       without which igb_enable_sriov() is effectively a no-op. Calling
>       igb_{,re}set_interrupt_capability() as done here seems to address this,
>       but I'm not sure whether this is better than sinply reverting the other
>       two commits.
>       
>       Signed-off-by: Jan Beulich <jbeulich@suse.com>
>       Tested-by: Aaron Brown <aaron.f.brown@intel.com>
>       Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
>       Signed-off-by: Sasha Levin <sashal@kernel.org>
> 
> 
> For bisection revision-tuple graph see:
>    http://logs.test-lab.xenproject.org/osstest/results/bisect/linux-3.18/test-amd64-amd64-pair.xen-boot--dst_host.html
> Revision IDs in each graph node refer, respectively, to the Trees above.


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [linux-3.18 bisection] complete test-amd64-amd64-pair
  2019-02-12 11:26 ` Ian Jackson
@ 2019-02-12 11:39   ` Jan Beulich
       [not found]     ` <fake-VM-id.1980f3cf4346994a5c6c126f36b5164c@talos.iv>
  0 siblings, 1 reply; 5+ messages in thread
From: Jan Beulich @ 2019-02-12 11:39 UTC (permalink / raw)
  To: Ian Jackson; +Cc: Sasha Levin, xen-devel, Aaron Brown, Jeffrey T Kirsher

[-- Attachment #1: Type: text/plain, Size: 2801 bytes --]

>>> On 12.02.19 at 12:26, <ian.jackson@citrix.com> wrote:
> Jan, are you investigating this regression ?

No, I'm not. I've said what I can say in a reply to an earlier bisection
report (from Dec 12th), attached again here for reference.

Jan

> osstest service owner writes ("[linux-3.18 bisection] complete 
> test-amd64-amd64-pair"):
>> branch xen-unstable
>> xenbranch xen-unstable
>> job test-amd64-amd64-pair
>> testid xen-boot/dst_host
>> 
>> Tree: linux git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git
>> Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git
>> Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git
>> Tree: qemuu git://xenbits.xen.org/qemu-xen.git
>> Tree: xen git://xenbits.xen.org/xen.git
>> 
>> *** Found and reproduced problem changeset ***
>> 
>>   Bug is in tree:  linux git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git
>>   Bug introduced:  7b8052e19304865477e03a0047062d977309a22f
>>   Bug not present: d255d18a34a8d53ccc4a019dc07e17b6e8cf6bd1
>>   Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/131278/ 
>> 
>> 
>>   commit 7b8052e19304865477e03a0047062d977309a22f
>>   Author: Jan Beulich <JBeulich@suse.com>
>>   Date:   Mon Oct 19 04:23:29 2015 -0600
>>   
>>       igb: fix NULL derefs due to skipped SR-IOV enabling
>>       
>>       [ Upstream commit be06998f96ecb93938ad2cce46c4289bf7cf45bc ]
>>       
>>       The combined effect of commits 6423fc3416 ("igb: do not re-init SR-IOV
>>       during probe") and ceee3450b3 ("igb: make sure SR-IOV init uses the
>>       right number of queues") causes VFs no longer getting set up, leading
>>       to NULL pointer dereferences due to the adapter's ->vf_data being NULL
>>       while ->vfs_allocated_count is non-zero. The first commit not only
>>       neglected the side effect of igb_sriov_reinit() that the second commit
>>       tried to account for, but also that of setting IGB_FLAG_HAS_MSIX,
>>       without which igb_enable_sriov() is effectively a no-op. Calling
>>       igb_{,re}set_interrupt_capability() as done here seems to address this,
>>       but I'm not sure whether this is better than sinply reverting the other
>>       two commits.
>>       
>>       Signed-off-by: Jan Beulich <jbeulich@suse.com>
>>       Tested-by: Aaron Brown <aaron.f.brown@intel.com>
>>       Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
>>       Signed-off-by: Sasha Levin <sashal@kernel.org>
>> 
>> 
>> For bisection revision-tuple graph see:
>>    
> http://logs.test-lab.xenproject.org/osstest/results/bisect/linux-3.18/test-am 
> d64-amd64-pair.xen-boot--dst_host.html
>> Revision IDs in each graph node refer, respectively, to the Trees above.




[-- Attachment #2: Type: message/rfc822, Size: 1923 bytes --]

From: "Jan Beulich" <JBeulich@suse.com>
To: "Sasha Levin" <sashal@kernel.org>, "osstest service owner" <osstest-admin@xenproject.org>
Cc: "xen-devel" <xen-devel@lists.xenproject.org>
Subject: Re: [Xen-devel] [linux-3.18 bisection] complete test-amd64-amd64-pair
Date: Thu, 13 Dec 2018 01:26:24 -0700

>>> On 12.12.18 at 22:41, <osstest-admin@xenproject.org> wrote:
> branch xen-unstable
> xenbranch xen-unstable
> job test-amd64-amd64-pair
> testid xen-boot/src_host
> 
> Tree: linux 
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git
> Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git
> Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git
> Tree: qemuu git://xenbits.xen.org/qemu-xen.git
> Tree: xen git://xenbits.xen.org/xen.git
> 
> *** Found and reproduced problem changeset ***
> 
>   Bug is in tree:  linux git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git
>   Bug introduced:  7b8052e19304865477e03a0047062d977309a22f
>   Bug not present: d255d18a34a8d53ccc4a019dc07e17b6e8cf6bd1
>   Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/131278/ 
> 
> 
>   commit 7b8052e19304865477e03a0047062d977309a22f
>   Author: Jan Beulich <JBeulich@suse.com>
>   Date:   Mon Oct 19 04:23:29 2015 -0600
>   
>       igb: fix NULL derefs due to skipped SR-IOV enabling

_Very_ interesting. An over three years old commit was determined
to cause whatever regression it is. But wait - that's the date of the
mainline commit, not that of the backport (which was done a month
ago). I notice that of the two original commits the combination of
which the one here is supposed to fix, only one actually got
backported. Hence I wonder whether backporting the one here
was actually appropriate.

Jan



[-- Attachment #3: Type: text/plain, Size: 157 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [linux-3.18 bisection] complete test-amd64-amd64-pair [and 1 more messages]
       [not found]     ` <fake-VM-id.1980f3cf4346994a5c6c126f36b5164c@talos.iv>
@ 2019-02-12 14:54       ` Ian Jackson
  2019-02-12 15:57         ` Sasha Levin
  0 siblings, 1 reply; 5+ messages in thread
From: Ian Jackson @ 2019-02-12 14:54 UTC (permalink / raw)
  To: Jan Beulich
  Cc: Sasha Levin, Greg Kroah-Hartman, osstest service owner,
	Jeffrey T Kirsher, xen-devel, Aaron Brown

Summary:

 7b8052e19304 which is a backport to linux-3.18 of be06998f96ec has
 been found by the Xen CI auto-bisector to be responsible for a
 regression booting under Xen.

Jan Beulich writes ("Re: [linux-3.18 bisection] complete test-amd64-amd64-pair"):
> No, I'm not. I've said what I can say in a reply to an earlier bisection
> report (from Dec 12th), attached again here for reference.

I missed that.  Thanks.

Jan Beulich writes ("Re: [Xen-devel] [linux-3.18 bisection] complete test-amd64-amd64-pair"):
> On 12.12.18 at 22:41, <osstest-admin@xenproject.org> wrote:
> >   Bug is in tree:  linux git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git
> >   Bug introduced:  7b8052e19304865477e03a0047062d977309a22f
> >   Bug not present: d255d18a34a8d53ccc4a019dc07e17b6e8cf6bd1
> >   Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/131278/ 
> > 
> > 
> >   commit 7b8052e19304865477e03a0047062d977309a22f
> >   Author: Jan Beulich <JBeulich@suse.com>
> >   Date:   Mon Oct 19 04:23:29 2015 -0600
> >   
> >       igb: fix NULL derefs due to skipped SR-IOV enabling
> 
> _Very_ interesting. An over three years old commit was determined
> to cause whatever regression it is. But wait - that's the date of the
> mainline commit, not that of the backport (which was done a month
> ago). I notice that of the two original commits the combination of
> which the one here is supposed to fix, only one actually got
> backported. Hence I wonder whether backporting the one here
> was actually appropriate.

The mainline commit be06998f96ecb93938ad2cce46c4289bf7cf45bc from
October 2015 was backported as
7b8052e19304865477e03a0047062d977309a22f.  You need to look at the
commit date as well as the author date:

   commit 7b8052e19304865477e03a0047062d977309a22f
   Author:     Jan Beulich <JBeulich@suse.com>
   AuthorDate: Mon Oct 19 04:23:29 2015 -0600
   Commit:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
   CommitDate: Sat Nov 10 07:39:21 2018 -0800

CC'ing Greg K-H.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [linux-3.18 bisection] complete test-amd64-amd64-pair [and 1 more messages]
  2019-02-12 14:54       ` [linux-3.18 bisection] complete test-amd64-amd64-pair [and 1 more messages] Ian Jackson
@ 2019-02-12 15:57         ` Sasha Levin
  0 siblings, 0 replies; 5+ messages in thread
From: Sasha Levin @ 2019-02-12 15:57 UTC (permalink / raw)
  To: Ian Jackson
  Cc: Greg Kroah-Hartman, osstest service owner, Jeffrey T Kirsher,
	Jan Beulich, xen-devel, Aaron Brown

On Tue, Feb 12, 2019 at 02:54:41PM +0000, Ian Jackson wrote:
>Summary:
>
> 7b8052e19304 which is a backport to linux-3.18 of be06998f96ec has
> been found by the Xen CI auto-bisector to be responsible for a
> regression booting under Xen.
>
>Jan Beulich writes ("Re: [linux-3.18 bisection] complete test-amd64-amd64-pair"):
>> No, I'm not. I've said what I can say in a reply to an earlier bisection
>> report (from Dec 12th), attached again here for reference.
>
>I missed that.  Thanks.
>
>Jan Beulich writes ("Re: [Xen-devel] [linux-3.18 bisection] complete test-amd64-amd64-pair"):
>> On 12.12.18 at 22:41, <osstest-admin@xenproject.org> wrote:
>> >   Bug is in tree:  linux git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git
>> >   Bug introduced:  7b8052e19304865477e03a0047062d977309a22f
>> >   Bug not present: d255d18a34a8d53ccc4a019dc07e17b6e8cf6bd1
>> >   Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/131278/
>> >
>> >
>> >   commit 7b8052e19304865477e03a0047062d977309a22f
>> >   Author: Jan Beulich <JBeulich@suse.com>
>> >   Date:   Mon Oct 19 04:23:29 2015 -0600
>> >
>> >       igb: fix NULL derefs due to skipped SR-IOV enabling
>>
>> _Very_ interesting. An over three years old commit was determined
>> to cause whatever regression it is. But wait - that's the date of the
>> mainline commit, not that of the backport (which was done a month
>> ago). I notice that of the two original commits the combination of
>> which the one here is supposed to fix, only one actually got
>> backported. Hence I wonder whether backporting the one here
>> was actually appropriate.
>
>The mainline commit be06998f96ecb93938ad2cce46c4289bf7cf45bc from
>October 2015 was backported as
>7b8052e19304865477e03a0047062d977309a22f.  You need to look at the
>commit date as well as the author date:
>
>   commit 7b8052e19304865477e03a0047062d977309a22f
>   Author:     Jan Beulich <JBeulich@suse.com>
>   AuthorDate: Mon Oct 19 04:23:29 2015 -0600
>   Commit:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>   CommitDate: Sat Nov 10 07:39:21 2018 -0800

Interesting. Could you see if picking ceee3450b3 ("igb: make sure SR-IOV
init uses the right number of queues") on top fixes the issue you're
seeing? If not, we can just revert 7b8052e19304.

--
Thanks,
Sasha

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-02-12 15:57 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-12  7:15 [linux-3.18 bisection] complete test-amd64-amd64-pair osstest service owner
2019-02-12 11:26 ` Ian Jackson
2019-02-12 11:39   ` Jan Beulich
     [not found]     ` <fake-VM-id.1980f3cf4346994a5c6c126f36b5164c@talos.iv>
2019-02-12 14:54       ` [linux-3.18 bisection] complete test-amd64-amd64-pair [and 1 more messages] Ian Jackson
2019-02-12 15:57         ` Sasha Levin

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.