* [PATCH] rapidio/mport_cdev: mark expected switch fall-through
@ 2019-02-12 17:50 Gustavo A. R. Silva
2019-02-27 4:42 ` Gustavo A. R. Silva
0 siblings, 1 reply; 2+ messages in thread
From: Gustavo A. R. Silva @ 2019-02-12 17:50 UTC (permalink / raw)
To: Matt Porter, Alexandre Bounine
Cc: linux-kernel, Gustavo A. R. Silva, Kees Cook
n preparation to enabling -Wimplicit-fallthrough, mark switch
cases where we are expecting to fall through.
This patch fixes the following warning:
drivers/rapidio/devices/rio_mport_cdev.c: In function ‘mport_release_mapping’:
drivers/rapidio/devices/rio_mport_cdev.c:2151:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
rio_unmap_inb_region(mport, map->phys_addr);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
CC drivers/regulator/fixed-helper.o
CC drivers/pinctrl/stm32/pinctrl-stm32f429.o
drivers/rapidio/devices/rio_mport_cdev.c:2152:2: note: here
case MAP_DMA:
^~~~
Warning level 3 was used: -Wimplicit-fallthrough=3
This patch is part of the ongoing efforts to enable
-Wimplicit-fallthrough.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/rapidio/devices/rio_mport_cdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/rapidio/devices/rio_mport_cdev.c b/drivers/rapidio/devices/rio_mport_cdev.c
index cbe467ff1aba..1e1f42e210a0 100644
--- a/drivers/rapidio/devices/rio_mport_cdev.c
+++ b/drivers/rapidio/devices/rio_mport_cdev.c
@@ -2149,6 +2149,7 @@ static void mport_release_mapping(struct kref *ref)
switch (map->dir) {
case MAP_INBOUND:
rio_unmap_inb_region(mport, map->phys_addr);
+ /* fall through */
case MAP_DMA:
dma_free_coherent(mport->dev.parent, map->size,
map->virt_addr, map->phys_addr);
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] rapidio/mport_cdev: mark expected switch fall-through
2019-02-12 17:50 [PATCH] rapidio/mport_cdev: mark expected switch fall-through Gustavo A. R. Silva
@ 2019-02-27 4:42 ` Gustavo A. R. Silva
0 siblings, 0 replies; 2+ messages in thread
From: Gustavo A. R. Silva @ 2019-02-27 4:42 UTC (permalink / raw)
To: Matt Porter, Alexandre Bounine; +Cc: linux-kernel, Kees Cook
Hi all,
Friendly ping:
Who can review or take this, please?
Thanks
--
Gustavo
On 2/12/19 11:50 AM, Gustavo A. R. Silva wrote:
> n preparation to enabling -Wimplicit-fallthrough, mark switch
> cases where we are expecting to fall through.
>
> This patch fixes the following warning:
>
> drivers/rapidio/devices/rio_mport_cdev.c: In function ‘mport_release_mapping’:
> drivers/rapidio/devices/rio_mport_cdev.c:2151:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
> rio_unmap_inb_region(mport, map->phys_addr);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> CC drivers/regulator/fixed-helper.o
> CC drivers/pinctrl/stm32/pinctrl-stm32f429.o
> drivers/rapidio/devices/rio_mport_cdev.c:2152:2: note: here
> case MAP_DMA:
> ^~~~
>
> Warning level 3 was used: -Wimplicit-fallthrough=3
>
> This patch is part of the ongoing efforts to enable
> -Wimplicit-fallthrough.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> drivers/rapidio/devices/rio_mport_cdev.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/rapidio/devices/rio_mport_cdev.c b/drivers/rapidio/devices/rio_mport_cdev.c
> index cbe467ff1aba..1e1f42e210a0 100644
> --- a/drivers/rapidio/devices/rio_mport_cdev.c
> +++ b/drivers/rapidio/devices/rio_mport_cdev.c
> @@ -2149,6 +2149,7 @@ static void mport_release_mapping(struct kref *ref)
> switch (map->dir) {
> case MAP_INBOUND:
> rio_unmap_inb_region(mport, map->phys_addr);
> + /* fall through */
> case MAP_DMA:
> dma_free_coherent(mport->dev.parent, map->size,
> map->virt_addr, map->phys_addr);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-02-27 4:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-12 17:50 [PATCH] rapidio/mport_cdev: mark expected switch fall-through Gustavo A. R. Silva
2019-02-27 4:42 ` Gustavo A. R. Silva
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.