From: hch@infradead.org (Christoph Hellwig)
Subject: [PATCH] scsi: lpfc: fix calls to dma_set_mask_and_coherent()
Date: Tue, 12 Feb 2019 10:34:52 -0800 [thread overview]
Message-ID: <20190212183452.GA25206@infradead.org> (raw)
In-Reply-To: <9572ae3b0131ad1c74d6a775f819437e3d4f1795.camel@redhat.com>
On Tue, Feb 12, 2019@10:37:45AM -0500, Ewan D. Milne wrote:
>
> It looks like this would introduce a different problem. "error" is set to
> -ENODEV earlier in the two functions so that the various error paths will return
> that value. If it is overwritten with a successful result from the call to
> dma_set_mask_and_coherent() but a later call to e.g. ioremap() fails, the
> functions will incorrectly return a value indicating that they have succeeded.
>
> It also appears as if the patches to hptiop, hisi_sas and bfa need to be fixed up.
> I don't have a test environment for these, although I might be able to modify the
> test environment for bfa. Martin/James, what about the others?
I don't have a test environment for them either, and I doubt many
people have. If you don't feel comfortable I can send a fix for
them.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: "Ewan D. Milne" <emilne@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-scsi@vger.kernel.org, linux-nvme@lists.infradead.org,
stable@vger.kernel.org, james.smart@broadcom.com,
dick.kennedy@broadcom.com, martin.petersen@oracle.com,
jejb@linux.ibm.com
Subject: Re: [PATCH] scsi: lpfc: fix calls to dma_set_mask_and_coherent()
Date: Tue, 12 Feb 2019 10:34:52 -0800 [thread overview]
Message-ID: <20190212183452.GA25206@infradead.org> (raw)
In-Reply-To: <9572ae3b0131ad1c74d6a775f819437e3d4f1795.camel@redhat.com>
On Tue, Feb 12, 2019 at 10:37:45AM -0500, Ewan D. Milne wrote:
>
> It looks like this would introduce a different problem. "error" is set to
> -ENODEV earlier in the two functions so that the various error paths will return
> that value. If it is overwritten with a successful result from the call to
> dma_set_mask_and_coherent() but a later call to e.g. ioremap() fails, the
> functions will incorrectly return a value indicating that they have succeeded.
>
> It also appears as if the patches to hptiop, hisi_sas and bfa need to be fixed up.
> I don't have a test environment for these, although I might be able to modify the
> test environment for bfa. Martin/James, what about the others?
I don't have a test environment for them either, and I doubt many
people have. If you don't feel comfortable I can send a fix for
them.
next prev parent reply other threads:[~2019-02-12 18:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-11 15:05 [PATCH] scsi: lpfc: fix calls to dma_set_mask_and_coherent() Ewan D. Milne
2019-02-11 15:05 ` Ewan D. Milne
2019-02-11 19:19 ` James Smart
2019-02-11 19:19 ` James Smart
2019-02-12 8:06 ` Christoph Hellwig
2019-02-12 8:06 ` Christoph Hellwig
2019-02-12 15:37 ` Ewan D. Milne
2019-02-12 15:37 ` Ewan D. Milne
2019-02-12 18:34 ` Christoph Hellwig [this message]
2019-02-12 18:34 ` Christoph Hellwig
2019-02-13 18:51 ` Ewan D. Milne
2019-02-13 3:10 ` Martin K. Petersen
2019-02-13 3:10 ` Martin K. Petersen
2019-02-13 9:18 ` John Garry
2019-02-13 9:18 ` John Garry
2019-02-13 9:18 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190212183452.GA25206@infradead.org \
--to=hch@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.