From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Tadeusz Struk <tadeusz.struk@intel.com>
Cc: linux-kselftest@vger.kernel.org, shuah@kernel.org,
linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org,
linux-security-module@vger.kernel.org, PeterHuewe@gmx.de,
jgg@ziepe.ca
Subject: Re: [PATCH 2/2] selftests: tpm2: Extend tests to cover partial reads
Date: Wed, 13 Feb 2019 01:06:55 +0200 [thread overview]
Message-ID: <20190212230655.GB3977@linux.intel.com> (raw)
In-Reply-To: <9b879fd2-5c0a-aecc-b6cb-02e5255c22f6@intel.com>
On Mon, Feb 11, 2019 at 09:55:36AM -0800, Tadeusz Struk wrote:
> On 2/11/19 8:48 AM, Jarkko Sakkinen wrote:
> > You are missing a cover letter from this patch set. Please have it in
> > v2. Also use tag "selftests/tpm2" instead of having two tags in the
> > short summaries. Now they look a bit weird.
>
> Since when is the cover letter mandatory?
> I understand that is helps for a complicated patch set
> to explain the problem and solution in the cover letter,
> but for this simple test case addition what's the point?
> And there is nothing forcing a cover letter in
> https://www.kernel.org/doc/html/v4.20/process/submitting-patches.html
OK, cool.
> Also double tags seams to be quite common for selftest.
> See git log tools/testing/selftests/
Prefer slash for TPM specific commits.
I can merge this after those extra logs are removed.
/Jarkko
WARNING: multiple messages have this Message-ID (diff)
From: jarkko.sakkinen at linux.intel.com (Jarkko Sakkinen)
Subject: [PATCH 2/2] selftests: tpm2: Extend tests to cover partial reads
Date: Wed, 13 Feb 2019 01:06:55 +0200 [thread overview]
Message-ID: <20190212230655.GB3977@linux.intel.com> (raw)
In-Reply-To: <9b879fd2-5c0a-aecc-b6cb-02e5255c22f6@intel.com>
On Mon, Feb 11, 2019 at 09:55:36AM -0800, Tadeusz Struk wrote:
> On 2/11/19 8:48 AM, Jarkko Sakkinen wrote:
> > You are missing a cover letter from this patch set. Please have it in
> > v2. Also use tag "selftests/tpm2" instead of having two tags in the
> > short summaries. Now they look a bit weird.
>
> Since when is the cover letter mandatory?
> I understand that is helps for a complicated patch set
> to explain the problem and solution in the cover letter,
> but for this simple test case addition what's the point?
> And there is nothing forcing a cover letter in
> https://www.kernel.org/doc/html/v4.20/process/submitting-patches.html
OK, cool.
> Also double tags seams to be quite common for selftest.
> See git log tools/testing/selftests/
Prefer slash for TPM specific commits.
I can merge this after those extra logs are removed.
/Jarkko
WARNING: multiple messages have this Message-ID (diff)
From: jarkko.sakkinen@linux.intel.com (Jarkko Sakkinen)
Subject: [PATCH 2/2] selftests: tpm2: Extend tests to cover partial reads
Date: Wed, 13 Feb 2019 01:06:55 +0200 [thread overview]
Message-ID: <20190212230655.GB3977@linux.intel.com> (raw)
Message-ID: <20190212230655.yvhBy6WFvUcKB9ES1ziDk2fHx4HafGjOj0Sjbd-pGXw@z> (raw)
In-Reply-To: <9b879fd2-5c0a-aecc-b6cb-02e5255c22f6@intel.com>
On Mon, Feb 11, 2019@09:55:36AM -0800, Tadeusz Struk wrote:
> On 2/11/19 8:48 AM, Jarkko Sakkinen wrote:
> > You are missing a cover letter from this patch set. Please have it in
> > v2. Also use tag "selftests/tpm2" instead of having two tags in the
> > short summaries. Now they look a bit weird.
>
> Since when is the cover letter mandatory?
> I understand that is helps for a complicated patch set
> to explain the problem and solution in the cover letter,
> but for this simple test case addition what's the point?
> And there is nothing forcing a cover letter in
> https://www.kernel.org/doc/html/v4.20/process/submitting-patches.html
OK, cool.
> Also double tags seams to be quite common for selftest.
> See git log tools/testing/selftests/
Prefer slash for TPM specific commits.
I can merge this after those extra logs are removed.
/Jarkko
next prev parent reply other threads:[~2019-02-12 23:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-05 20:28 [PATCH 1/2] selftests: tpm2: Open tpm dev in unbuffered mode Tadeusz Struk
2019-02-05 20:28 ` Tadeusz Struk
2019-02-05 20:28 ` tadeusz.struk
2019-02-05 20:28 ` [PATCH 2/2] selftests: tpm2: Extend tests to cover partial reads Tadeusz Struk
2019-02-05 20:28 ` Tadeusz Struk
2019-02-05 20:28 ` tadeusz.struk
2019-02-11 16:48 ` Jarkko Sakkinen
2019-02-11 16:48 ` Jarkko Sakkinen
2019-02-11 16:48 ` jarkko.sakkinen
2019-02-11 17:55 ` Tadeusz Struk
2019-02-11 17:55 ` Tadeusz Struk
2019-02-11 17:55 ` tadeusz.struk
2019-02-12 23:06 ` Jarkko Sakkinen [this message]
2019-02-12 23:06 ` Jarkko Sakkinen
2019-02-12 23:06 ` jarkko.sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190212230655.GB3977@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=PeterHuewe@gmx.de \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=tadeusz.struk@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.