* [PATCH] memstick: mark expected switch fall-throughs
@ 2019-02-13 2:57 Gustavo A. R. Silva
2019-03-20 17:40 ` Gustavo A. R. Silva
2019-04-23 15:15 ` Kees Cook
0 siblings, 2 replies; 5+ messages in thread
From: Gustavo A. R. Silva @ 2019-02-13 2:57 UTC (permalink / raw)
To: Alex Dubov; +Cc: linux-kernel, Gustavo A. R. Silva, Kees Cook
In preparation to enabling -Wimplicit-fallthrough, mark switch
cases where we are expecting to fall through.
This patch fixes the following warnings:
drivers/memstick/host/jmb38x_ms.c: In function ‘jmb38x_ms_write_data’:
drivers/memstick/host/jmb38x_ms.c:261:15: warning: this statement may fall through [-Wimplicit-fallthrough=]
host->io_pos++;
~~~~~~~~~~~~^~
drivers/memstick/host/jmb38x_ms.c:262:2: note: here
case 2:
^~~~
drivers/memstick/host/jmb38x_ms.c:264:15: warning: this statement may fall through [-Wimplicit-fallthrough=]
host->io_pos++;
~~~~~~~~~~~~^~
drivers/memstick/host/jmb38x_ms.c:265:2: note: here
case 1:
^~~~
drivers/memstick/host/tifm_ms.c: In function ‘tifm_ms_write_data’:
drivers/memstick/host/tifm_ms.c:168:15: warning: this statement may fall through [-Wimplicit-fallthrough=]
host->io_pos++;
~~~~~~~~~~~~^~
drivers/memstick/host/tifm_ms.c:169:2: note: here
case 2:
^~~~
drivers/memstick/host/tifm_ms.c:171:15: warning: this statement may fall through [-Wimplicit-fallthrough=]
host->io_pos++;
~~~~~~~~~~~~^~
drivers/memstick/host/tifm_ms.c:172:2: note: here
case 1:
^~~~
Warning level 3 was used: -Wimplicit-fallthrough=3
This patch is part of the ongoing efforts to enable
-Wimplicit-fallthrough.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/memstick/host/jmb38x_ms.c | 2 ++
drivers/memstick/host/tifm_ms.c | 2 ++
2 files changed, 4 insertions(+)
diff --git a/drivers/memstick/host/jmb38x_ms.c b/drivers/memstick/host/jmb38x_ms.c
index bcdca9fbef51..49c71f55489f 100644
--- a/drivers/memstick/host/jmb38x_ms.c
+++ b/drivers/memstick/host/jmb38x_ms.c
@@ -259,9 +259,11 @@ static unsigned int jmb38x_ms_write_data(struct jmb38x_ms_host *host,
case 3:
host->io_word[0] |= buf[off + 2] << 16;
host->io_pos++;
+ /* fall through */
case 2:
host->io_word[0] |= buf[off + 1] << 8;
host->io_pos++;
+ /* fall through */
case 1:
host->io_word[0] |= buf[off];
host->io_pos++;
diff --git a/drivers/memstick/host/tifm_ms.c b/drivers/memstick/host/tifm_ms.c
index bed205849d02..1bbb2ead9556 100644
--- a/drivers/memstick/host/tifm_ms.c
+++ b/drivers/memstick/host/tifm_ms.c
@@ -166,9 +166,11 @@ static unsigned int tifm_ms_write_data(struct tifm_ms *host,
case 3:
host->io_word |= buf[off + 2] << 16;
host->io_pos++;
+ /* fall through */
case 2:
host->io_word |= buf[off + 1] << 8;
host->io_pos++;
+ /* fall through */
case 1:
host->io_word |= buf[off];
host->io_pos++;
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] memstick: mark expected switch fall-throughs
2019-02-13 2:57 [PATCH] memstick: mark expected switch fall-throughs Gustavo A. R. Silva
@ 2019-03-20 17:40 ` Gustavo A. R. Silva
2019-04-23 15:10 ` Gustavo A. R. Silva
2019-04-23 15:15 ` Kees Cook
1 sibling, 1 reply; 5+ messages in thread
From: Gustavo A. R. Silva @ 2019-03-20 17:40 UTC (permalink / raw)
To: Alex Dubov; +Cc: linux-kernel, Kees Cook
Hi,
Friendly ping:
Who can take this?
Thanks
--
Gustavo
On 2/12/19 8:57 PM, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch
> cases where we are expecting to fall through.
>
> This patch fixes the following warnings:
>
> drivers/memstick/host/jmb38x_ms.c: In function ‘jmb38x_ms_write_data’:
> drivers/memstick/host/jmb38x_ms.c:261:15: warning: this statement may fall through [-Wimplicit-fallthrough=]
> host->io_pos++;
> ~~~~~~~~~~~~^~
> drivers/memstick/host/jmb38x_ms.c:262:2: note: here
> case 2:
> ^~~~
> drivers/memstick/host/jmb38x_ms.c:264:15: warning: this statement may fall through [-Wimplicit-fallthrough=]
> host->io_pos++;
> ~~~~~~~~~~~~^~
> drivers/memstick/host/jmb38x_ms.c:265:2: note: here
> case 1:
> ^~~~
> drivers/memstick/host/tifm_ms.c: In function ‘tifm_ms_write_data’:
> drivers/memstick/host/tifm_ms.c:168:15: warning: this statement may fall through [-Wimplicit-fallthrough=]
> host->io_pos++;
> ~~~~~~~~~~~~^~
> drivers/memstick/host/tifm_ms.c:169:2: note: here
> case 2:
> ^~~~
> drivers/memstick/host/tifm_ms.c:171:15: warning: this statement may fall through [-Wimplicit-fallthrough=]
> host->io_pos++;
> ~~~~~~~~~~~~^~
> drivers/memstick/host/tifm_ms.c:172:2: note: here
> case 1:
> ^~~~
>
> Warning level 3 was used: -Wimplicit-fallthrough=3
>
> This patch is part of the ongoing efforts to enable
> -Wimplicit-fallthrough.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> drivers/memstick/host/jmb38x_ms.c | 2 ++
> drivers/memstick/host/tifm_ms.c | 2 ++
> 2 files changed, 4 insertions(+)
>
> diff --git a/drivers/memstick/host/jmb38x_ms.c b/drivers/memstick/host/jmb38x_ms.c
> index bcdca9fbef51..49c71f55489f 100644
> --- a/drivers/memstick/host/jmb38x_ms.c
> +++ b/drivers/memstick/host/jmb38x_ms.c
> @@ -259,9 +259,11 @@ static unsigned int jmb38x_ms_write_data(struct jmb38x_ms_host *host,
> case 3:
> host->io_word[0] |= buf[off + 2] << 16;
> host->io_pos++;
> + /* fall through */
> case 2:
> host->io_word[0] |= buf[off + 1] << 8;
> host->io_pos++;
> + /* fall through */
> case 1:
> host->io_word[0] |= buf[off];
> host->io_pos++;
> diff --git a/drivers/memstick/host/tifm_ms.c b/drivers/memstick/host/tifm_ms.c
> index bed205849d02..1bbb2ead9556 100644
> --- a/drivers/memstick/host/tifm_ms.c
> +++ b/drivers/memstick/host/tifm_ms.c
> @@ -166,9 +166,11 @@ static unsigned int tifm_ms_write_data(struct tifm_ms *host,
> case 3:
> host->io_word |= buf[off + 2] << 16;
> host->io_pos++;
> + /* fall through */
> case 2:
> host->io_word |= buf[off + 1] << 8;
> host->io_pos++;
> + /* fall through */
> case 1:
> host->io_word |= buf[off];
> host->io_pos++;
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] memstick: mark expected switch fall-throughs
2019-03-20 17:40 ` Gustavo A. R. Silva
@ 2019-04-23 15:10 ` Gustavo A. R. Silva
0 siblings, 0 replies; 5+ messages in thread
From: Gustavo A. R. Silva @ 2019-04-23 15:10 UTC (permalink / raw)
To: Alex Dubov; +Cc: linux-kernel, Kees Cook
Hi all,
If no one cares, I'll add this to my tree for 5.2.
Thanks
--
Gustavo
On 3/20/19 12:40 PM, Gustavo A. R. Silva wrote:
> Hi,
>
> Friendly ping:
>
> Who can take this?
>
> Thanks
> --
> Gustavo
>
> On 2/12/19 8:57 PM, Gustavo A. R. Silva wrote:
>> In preparation to enabling -Wimplicit-fallthrough, mark switch
>> cases where we are expecting to fall through.
>>
>> This patch fixes the following warnings:
>>
>> drivers/memstick/host/jmb38x_ms.c: In function ‘jmb38x_ms_write_data’:
>> drivers/memstick/host/jmb38x_ms.c:261:15: warning: this statement may fall through [-Wimplicit-fallthrough=]
>> host->io_pos++;
>> ~~~~~~~~~~~~^~
>> drivers/memstick/host/jmb38x_ms.c:262:2: note: here
>> case 2:
>> ^~~~
>> drivers/memstick/host/jmb38x_ms.c:264:15: warning: this statement may fall through [-Wimplicit-fallthrough=]
>> host->io_pos++;
>> ~~~~~~~~~~~~^~
>> drivers/memstick/host/jmb38x_ms.c:265:2: note: here
>> case 1:
>> ^~~~
>> drivers/memstick/host/tifm_ms.c: In function ‘tifm_ms_write_data’:
>> drivers/memstick/host/tifm_ms.c:168:15: warning: this statement may fall through [-Wimplicit-fallthrough=]
>> host->io_pos++;
>> ~~~~~~~~~~~~^~
>> drivers/memstick/host/tifm_ms.c:169:2: note: here
>> case 2:
>> ^~~~
>> drivers/memstick/host/tifm_ms.c:171:15: warning: this statement may fall through [-Wimplicit-fallthrough=]
>> host->io_pos++;
>> ~~~~~~~~~~~~^~
>> drivers/memstick/host/tifm_ms.c:172:2: note: here
>> case 1:
>> ^~~~
>>
>> Warning level 3 was used: -Wimplicit-fallthrough=3
>>
>> This patch is part of the ongoing efforts to enable
>> -Wimplicit-fallthrough.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>> ---
>> drivers/memstick/host/jmb38x_ms.c | 2 ++
>> drivers/memstick/host/tifm_ms.c | 2 ++
>> 2 files changed, 4 insertions(+)
>>
>> diff --git a/drivers/memstick/host/jmb38x_ms.c b/drivers/memstick/host/jmb38x_ms.c
>> index bcdca9fbef51..49c71f55489f 100644
>> --- a/drivers/memstick/host/jmb38x_ms.c
>> +++ b/drivers/memstick/host/jmb38x_ms.c
>> @@ -259,9 +259,11 @@ static unsigned int jmb38x_ms_write_data(struct jmb38x_ms_host *host,
>> case 3:
>> host->io_word[0] |= buf[off + 2] << 16;
>> host->io_pos++;
>> + /* fall through */
>> case 2:
>> host->io_word[0] |= buf[off + 1] << 8;
>> host->io_pos++;
>> + /* fall through */
>> case 1:
>> host->io_word[0] |= buf[off];
>> host->io_pos++;
>> diff --git a/drivers/memstick/host/tifm_ms.c b/drivers/memstick/host/tifm_ms.c
>> index bed205849d02..1bbb2ead9556 100644
>> --- a/drivers/memstick/host/tifm_ms.c
>> +++ b/drivers/memstick/host/tifm_ms.c
>> @@ -166,9 +166,11 @@ static unsigned int tifm_ms_write_data(struct tifm_ms *host,
>> case 3:
>> host->io_word |= buf[off + 2] << 16;
>> host->io_pos++;
>> + /* fall through */
>> case 2:
>> host->io_word |= buf[off + 1] << 8;
>> host->io_pos++;
>> + /* fall through */
>> case 1:
>> host->io_word |= buf[off];
>> host->io_pos++;
>>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] memstick: mark expected switch fall-throughs
2019-02-13 2:57 [PATCH] memstick: mark expected switch fall-throughs Gustavo A. R. Silva
2019-03-20 17:40 ` Gustavo A. R. Silva
@ 2019-04-23 15:15 ` Kees Cook
2019-04-23 15:24 ` Gustavo A. R. Silva
1 sibling, 1 reply; 5+ messages in thread
From: Kees Cook @ 2019-04-23 15:15 UTC (permalink / raw)
To: Gustavo A. R. Silva; +Cc: Alex Dubov, LKML, Kees Cook
On Tue, Feb 12, 2019 at 6:57 PM Gustavo A. R. Silva
<gustavo@embeddedor.com> wrote:
>
> In preparation to enabling -Wimplicit-fallthrough, mark switch
> cases where we are expecting to fall through.
>
> This patch fixes the following warnings:
>
> drivers/memstick/host/jmb38x_ms.c: In function ‘jmb38x_ms_write_data’:
> drivers/memstick/host/jmb38x_ms.c:261:15: warning: this statement may fall through [-Wimplicit-fallthrough=]
> host->io_pos++;
> ~~~~~~~~~~~~^~
> drivers/memstick/host/jmb38x_ms.c:262:2: note: here
> case 2:
> ^~~~
> drivers/memstick/host/jmb38x_ms.c:264:15: warning: this statement may fall through [-Wimplicit-fallthrough=]
> host->io_pos++;
> ~~~~~~~~~~~~^~
> drivers/memstick/host/jmb38x_ms.c:265:2: note: here
> case 1:
> ^~~~
> drivers/memstick/host/tifm_ms.c: In function ‘tifm_ms_write_data’:
> drivers/memstick/host/tifm_ms.c:168:15: warning: this statement may fall through [-Wimplicit-fallthrough=]
> host->io_pos++;
> ~~~~~~~~~~~~^~
> drivers/memstick/host/tifm_ms.c:169:2: note: here
> case 2:
> ^~~~
> drivers/memstick/host/tifm_ms.c:171:15: warning: this statement may fall through [-Wimplicit-fallthrough=]
> host->io_pos++;
> ~~~~~~~~~~~~^~
> drivers/memstick/host/tifm_ms.c:172:2: note: here
> case 1:
> ^~~~
>
> Warning level 3 was used: -Wimplicit-fallthrough=3
>
> This patch is part of the ongoing efforts to enable
> -Wimplicit-fallthrough.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
-Kees
> ---
> drivers/memstick/host/jmb38x_ms.c | 2 ++
> drivers/memstick/host/tifm_ms.c | 2 ++
> 2 files changed, 4 insertions(+)
>
> diff --git a/drivers/memstick/host/jmb38x_ms.c b/drivers/memstick/host/jmb38x_ms.c
> index bcdca9fbef51..49c71f55489f 100644
> --- a/drivers/memstick/host/jmb38x_ms.c
> +++ b/drivers/memstick/host/jmb38x_ms.c
> @@ -259,9 +259,11 @@ static unsigned int jmb38x_ms_write_data(struct jmb38x_ms_host *host,
> case 3:
> host->io_word[0] |= buf[off + 2] << 16;
> host->io_pos++;
> + /* fall through */
> case 2:
> host->io_word[0] |= buf[off + 1] << 8;
> host->io_pos++;
> + /* fall through */
> case 1:
> host->io_word[0] |= buf[off];
> host->io_pos++;
> diff --git a/drivers/memstick/host/tifm_ms.c b/drivers/memstick/host/tifm_ms.c
> index bed205849d02..1bbb2ead9556 100644
> --- a/drivers/memstick/host/tifm_ms.c
> +++ b/drivers/memstick/host/tifm_ms.c
> @@ -166,9 +166,11 @@ static unsigned int tifm_ms_write_data(struct tifm_ms *host,
> case 3:
> host->io_word |= buf[off + 2] << 16;
> host->io_pos++;
> + /* fall through */
> case 2:
> host->io_word |= buf[off + 1] << 8;
> host->io_pos++;
> + /* fall through */
> case 1:
> host->io_word |= buf[off];
> host->io_pos++;
> --
> 2.20.1
>
--
Kees Cook
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] memstick: mark expected switch fall-throughs
2019-04-23 15:15 ` Kees Cook
@ 2019-04-23 15:24 ` Gustavo A. R. Silva
0 siblings, 0 replies; 5+ messages in thread
From: Gustavo A. R. Silva @ 2019-04-23 15:24 UTC (permalink / raw)
To: Kees Cook; +Cc: Alex Dubov, LKML
On 4/23/19 10:15 AM, Kees Cook wrote:
> On Tue, Feb 12, 2019 at 6:57 PM Gustavo A. R. Silva
> <gustavo@embeddedor.com> wrote:
>>
>> In preparation to enabling -Wimplicit-fallthrough, mark switch
>> cases where we are expecting to fall through.
>>
>> This patch fixes the following warnings:
>>
>> drivers/memstick/host/jmb38x_ms.c: In function ‘jmb38x_ms_write_data’:
>> drivers/memstick/host/jmb38x_ms.c:261:15: warning: this statement may fall through [-Wimplicit-fallthrough=]
>> host->io_pos++;
>> ~~~~~~~~~~~~^~
>> drivers/memstick/host/jmb38x_ms.c:262:2: note: here
>> case 2:
>> ^~~~
>> drivers/memstick/host/jmb38x_ms.c:264:15: warning: this statement may fall through [-Wimplicit-fallthrough=]
>> host->io_pos++;
>> ~~~~~~~~~~~~^~
>> drivers/memstick/host/jmb38x_ms.c:265:2: note: here
>> case 1:
>> ^~~~
>> drivers/memstick/host/tifm_ms.c: In function ‘tifm_ms_write_data’:
>> drivers/memstick/host/tifm_ms.c:168:15: warning: this statement may fall through [-Wimplicit-fallthrough=]
>> host->io_pos++;
>> ~~~~~~~~~~~~^~
>> drivers/memstick/host/tifm_ms.c:169:2: note: here
>> case 2:
>> ^~~~
>> drivers/memstick/host/tifm_ms.c:171:15: warning: this statement may fall through [-Wimplicit-fallthrough=]
>> host->io_pos++;
>> ~~~~~~~~~~~~^~
>> drivers/memstick/host/tifm_ms.c:172:2: note: here
>> case 1:
>> ^~~~
>>
>> Warning level 3 was used: -Wimplicit-fallthrough=3
>>
>> This patch is part of the ongoing efforts to enable
>> -Wimplicit-fallthrough.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>
> Reviewed-by: Kees Cook <keescook@chromium.org>
>
Thanks, Kees!
--
Gustavo
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-04-23 15:24 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-13 2:57 [PATCH] memstick: mark expected switch fall-throughs Gustavo A. R. Silva
2019-03-20 17:40 ` Gustavo A. R. Silva
2019-04-23 15:10 ` Gustavo A. R. Silva
2019-04-23 15:15 ` Kees Cook
2019-04-23 15:24 ` Gustavo A. R. Silva
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.