From: Johan Hovold <johan@kernel.org>
To: Loys Ollivier <lollivier@baylibre.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh@kernel.org>,
devicetree@vger.kernel.org,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Kevin Hilman <khilman@baylibre.com>,
Johan Hovold <johan@kernel.org>,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 2/4] dt-bindings: gnss: add mediatek binding
Date: Wed, 13 Feb 2019 10:34:25 +0100 [thread overview]
Message-ID: <20190213093425.GH28278@localhost> (raw)
In-Reply-To: <86o97iv2px.fsf@baylibre.com>
On Mon, Feb 11, 2019 at 03:06:50PM +0100, Loys Ollivier wrote:
>
> On Mon 11 Feb 2019 at 09:22, Johan Hovold <johan@kernel.org> wrote:
>
> > On Wed, Jan 30, 2019 at 09:50:16AM -0600, Rob Herring wrote:
> >> On Mon, Jan 28, 2019 at 05:37:59PM +0100, Loys Ollivier wrote:
> >> > Add binding for Mediatek-based GNSS receivers.
> >> >
> >> > Signed-off-by: Loys Ollivier <lollivier@baylibre.com>
> >> reset-gpios is the standard name.
> >>
> >> > +- gtop,fix-gpios : GPIO used to determine device position fix state
> >> > + (pin name: FIX, 3D_FIX)
> >
> > I'm thinking we might need a standard name for fix-gpios as well. This
> > isn't a feature that is globaltop (or mediatek) specific, and other
> > manufacturers provide similar functionality through pins named UI_FIX,
> > or even LCKIND (lock indicator).
> >
> > The pin is typically used to drive an indicator LED AFAIU, but the
> > characteristics of the signal varies from device to device (fw to fw),
> > for example, pulse when no lock and low otherwise, or pulse when a 2d or
> > 3d-fix is acquired, etc.
> >
>
> Yes most GNSS recevivers provide a similar feature even if behavior of
> the line differs.
>
> > I'm not sure how useful the pulsing would be for software, but someone
> > might find a use for it in some form.
> >
>
> Well it is useful to know when you start acquiring "valid" positionning
> data. I'm using this as a trigger to start recording position.
Sure, but a non-pulsing signal might have been easier to deal with if it
was meant to be used by software.
> > Rob, is this something we want to keep in the binding, and if so, how
> > about using a generic name such as "gnss-fix-gpios"?
>
> Name "gnss-fix-gpios" sounds good to me.
Let's go with that then.
Johan
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
WARNING: multiple messages have this Message-ID (diff)
From: Johan Hovold <johan@kernel.org>
To: Loys Ollivier <lollivier@baylibre.com>
Cc: Johan Hovold <johan@kernel.org>, Rob Herring <robh@kernel.org>,
devicetree@vger.kernel.org, Mark Rutland <mark.rutland@arm.com>,
linux-kernel@vger.kernel.org, Kevin Hilman <khilman@baylibre.com>,
linux-amlogic@lists.infradead.org,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Subject: Re: [PATCH v3 2/4] dt-bindings: gnss: add mediatek binding
Date: Wed, 13 Feb 2019 10:34:25 +0100 [thread overview]
Message-ID: <20190213093425.GH28278@localhost> (raw)
In-Reply-To: <86o97iv2px.fsf@baylibre.com>
On Mon, Feb 11, 2019 at 03:06:50PM +0100, Loys Ollivier wrote:
>
> On Mon 11 Feb 2019 at 09:22, Johan Hovold <johan@kernel.org> wrote:
>
> > On Wed, Jan 30, 2019 at 09:50:16AM -0600, Rob Herring wrote:
> >> On Mon, Jan 28, 2019 at 05:37:59PM +0100, Loys Ollivier wrote:
> >> > Add binding for Mediatek-based GNSS receivers.
> >> >
> >> > Signed-off-by: Loys Ollivier <lollivier@baylibre.com>
> >> reset-gpios is the standard name.
> >>
> >> > +- gtop,fix-gpios : GPIO used to determine device position fix state
> >> > + (pin name: FIX, 3D_FIX)
> >
> > I'm thinking we might need a standard name for fix-gpios as well. This
> > isn't a feature that is globaltop (or mediatek) specific, and other
> > manufacturers provide similar functionality through pins named UI_FIX,
> > or even LCKIND (lock indicator).
> >
> > The pin is typically used to drive an indicator LED AFAIU, but the
> > characteristics of the signal varies from device to device (fw to fw),
> > for example, pulse when no lock and low otherwise, or pulse when a 2d or
> > 3d-fix is acquired, etc.
> >
>
> Yes most GNSS recevivers provide a similar feature even if behavior of
> the line differs.
>
> > I'm not sure how useful the pulsing would be for software, but someone
> > might find a use for it in some form.
> >
>
> Well it is useful to know when you start acquiring "valid" positionning
> data. I'm using this as a trigger to start recording position.
Sure, but a non-pulsing signal might have been easier to deal with if it
was meant to be used by software.
> > Rob, is this something we want to keep in the binding, and if so, how
> > about using a generic name such as "gnss-fix-gpios"?
>
> Name "gnss-fix-gpios" sounds good to me.
Let's go with that then.
Johan
WARNING: multiple messages have this Message-ID (diff)
From: Johan Hovold <johan@kernel.org>
To: Loys Ollivier <lollivier@baylibre.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh@kernel.org>,
devicetree@vger.kernel.org,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Kevin Hilman <khilman@baylibre.com>,
Johan Hovold <johan@kernel.org>,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 2/4] dt-bindings: gnss: add mediatek binding
Date: Wed, 13 Feb 2019 10:34:25 +0100 [thread overview]
Message-ID: <20190213093425.GH28278@localhost> (raw)
In-Reply-To: <86o97iv2px.fsf@baylibre.com>
On Mon, Feb 11, 2019 at 03:06:50PM +0100, Loys Ollivier wrote:
>
> On Mon 11 Feb 2019 at 09:22, Johan Hovold <johan@kernel.org> wrote:
>
> > On Wed, Jan 30, 2019 at 09:50:16AM -0600, Rob Herring wrote:
> >> On Mon, Jan 28, 2019 at 05:37:59PM +0100, Loys Ollivier wrote:
> >> > Add binding for Mediatek-based GNSS receivers.
> >> >
> >> > Signed-off-by: Loys Ollivier <lollivier@baylibre.com>
> >> reset-gpios is the standard name.
> >>
> >> > +- gtop,fix-gpios : GPIO used to determine device position fix state
> >> > + (pin name: FIX, 3D_FIX)
> >
> > I'm thinking we might need a standard name for fix-gpios as well. This
> > isn't a feature that is globaltop (or mediatek) specific, and other
> > manufacturers provide similar functionality through pins named UI_FIX,
> > or even LCKIND (lock indicator).
> >
> > The pin is typically used to drive an indicator LED AFAIU, but the
> > characteristics of the signal varies from device to device (fw to fw),
> > for example, pulse when no lock and low otherwise, or pulse when a 2d or
> > 3d-fix is acquired, etc.
> >
>
> Yes most GNSS recevivers provide a similar feature even if behavior of
> the line differs.
>
> > I'm not sure how useful the pulsing would be for software, but someone
> > might find a use for it in some form.
> >
>
> Well it is useful to know when you start acquiring "valid" positionning
> data. I'm using this as a trigger to start recording position.
Sure, but a non-pulsing signal might have been easier to deal with if it
was meant to be used by software.
> > Rob, is this something we want to keep in the binding, and if so, how
> > about using a generic name such as "gnss-fix-gpios"?
>
> Name "gnss-fix-gpios" sounds good to me.
Let's go with that then.
Johan
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-02-13 9:34 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-28 16:37 [PATCH v3 0/4] Add driver for Mediatek-based GNSS receivers Loys Ollivier
2019-01-28 16:37 ` Loys Ollivier
2019-01-28 16:37 ` Loys Ollivier
2019-01-28 16:37 ` [PATCH v3 1/4] dt-bindings: Add vendor prefix for "GlobalTop Technology, Inc." Loys Ollivier
2019-01-28 16:37 ` Loys Ollivier
2019-01-28 16:37 ` Loys Ollivier
2019-01-30 15:48 ` Rob Herring
2019-01-30 15:48 ` Rob Herring
2019-01-30 15:48 ` Rob Herring
2019-01-30 15:48 ` Rob Herring
2019-02-01 8:17 ` Loys Ollivier
2019-02-01 8:17 ` Loys Ollivier
2019-02-01 8:17 ` Loys Ollivier
2019-01-28 16:37 ` [PATCH v3 2/4] dt-bindings: gnss: add mediatek binding Loys Ollivier
2019-01-28 16:37 ` Loys Ollivier
2019-01-28 16:37 ` Loys Ollivier
2019-01-30 15:50 ` Rob Herring
2019-01-30 15:50 ` Rob Herring
2019-01-30 15:50 ` Rob Herring
2019-02-11 9:22 ` Johan Hovold
2019-02-11 9:22 ` Johan Hovold
2019-02-11 9:22 ` Johan Hovold
2019-02-11 14:06 ` Loys Ollivier
2019-02-11 14:06 ` Loys Ollivier
2019-02-11 14:06 ` Loys Ollivier
2019-02-13 9:34 ` Johan Hovold [this message]
2019-02-13 9:34 ` Johan Hovold
2019-02-13 9:34 ` Johan Hovold
2019-02-12 21:18 ` Rob Herring
2019-02-12 21:18 ` Rob Herring
2019-02-12 21:18 ` Rob Herring
2019-02-13 9:31 ` Johan Hovold
2019-02-13 9:31 ` Johan Hovold
2019-02-13 9:31 ` Johan Hovold
2019-01-28 16:38 ` [PATCH v3 3/4] gnss: add mtk receiver type support Loys Ollivier
2019-01-28 16:38 ` Loys Ollivier
2019-01-28 16:38 ` Loys Ollivier
2019-01-28 16:38 ` [PATCH v3 4/4] gnss: add driver for mediatek receivers Loys Ollivier
2019-01-28 16:38 ` Loys Ollivier
2019-01-28 16:38 ` Loys Ollivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190213093425.GH28278@localhost \
--to=johan@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=lollivier@baylibre.com \
--cc=mark.rutland@arm.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.