From: Dan Carpenter <dan.carpenter@oracle.com>
To: Chao Yu <yuchao0@huawei.com>
Cc: Jaegeuk Kim <jaegeuk@kernel.org>,
kernel-janitors@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] f2fs: don't allow negative ->write_io_size_bits
Date: Wed, 13 Feb 2019 09:46:15 +0000 [thread overview]
Message-ID: <20190213094615.GE5458@kadam> (raw)
In-Reply-To: <05f4eed5-8b71-e97f-464a-72f8c5ae804d@huawei.com>
On Wed, Feb 13, 2019 at 04:49:57PM +0800, Chao Yu wrote:
> On 2019/2/13 11:32, Chao Yu wrote:
> > On 2019/2/12 2:45, Dan Carpenter wrote:
> >> We put an upper bound on ->write_io_size_bits but we don't have a lower
> >> bound.
> >
> > Oh, lower bound, I think there are more cases didn't consider that,
> > let me check it.
>
> Sorry, one missing case:
>
> Shouldn't it be:
>
> if (arg <= 0 || arg > __ilog2_u32(BIO_MAX_PAGES)) {
> ^
It wouldn't be hard for me to redo my patch, but I don't know enough to
say if zero is invalid and I don't want to get blamed for that... Can
you do it, since you're better able to test the change?
So let's drop this patch, and then could you give me Reported-by credit
instead?
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Chao Yu <yuchao0@huawei.com>
Cc: Jaegeuk Kim <jaegeuk@kernel.org>,
kernel-janitors@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [PATCH] f2fs: don't allow negative ->write_io_size_bits
Date: Wed, 13 Feb 2019 12:46:15 +0300 [thread overview]
Message-ID: <20190213094615.GE5458@kadam> (raw)
In-Reply-To: <05f4eed5-8b71-e97f-464a-72f8c5ae804d@huawei.com>
On Wed, Feb 13, 2019 at 04:49:57PM +0800, Chao Yu wrote:
> On 2019/2/13 11:32, Chao Yu wrote:
> > On 2019/2/12 2:45, Dan Carpenter wrote:
> >> We put an upper bound on ->write_io_size_bits but we don't have a lower
> >> bound.
> >
> > Oh, lower bound, I think there are more cases didn't consider that,
> > let me check it.
>
> Sorry, one missing case:
>
> Shouldn't it be:
>
> if (arg <= 0 || arg > __ilog2_u32(BIO_MAX_PAGES)) {
> ^
It wouldn't be hard for me to redo my patch, but I don't know enough to
say if zero is invalid and I don't want to get blamed for that... Can
you do it, since you're better able to test the change?
So let's drop this patch, and then could you give me Reported-by credit
instead?
regards,
dan carpenter
next prev parent reply other threads:[~2019-02-13 9:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-11 18:45 [PATCH] f2fs: don't allow negative ->write_io_size_bits Dan Carpenter
2019-02-11 18:45 ` Dan Carpenter
2019-02-13 3:32 ` Chao Yu
2019-02-13 3:32 ` Chao Yu
2019-02-13 8:49 ` [f2fs-dev] " Chao Yu
2019-02-13 8:49 ` Chao Yu
2019-02-13 9:46 ` Dan Carpenter [this message]
2019-02-13 9:46 ` Dan Carpenter
2019-02-14 16:09 ` [f2fs-dev] " Chao Yu
2019-02-14 16:09 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190213094615.GE5458@kadam \
--to=dan.carpenter@oracle.com \
--cc=jaegeuk@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.