All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Stefan Agner <stefan@agner.ch>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
	s.hauer@pengutronix.de, linux-kernel@vger.kernel.org,
	robh+dt@kernel.org, linux-imx@nxp.com, kernel@pengutronix.de,
	fabio.estevam@nxp.com, Shawn Guo <shawnguo@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	Trent Piepho <tpiepho@impinj.com>
Subject: Re: [PATCH 2/2] ARM: dts: imx7: add DMA properties for ECSPI
Date: Wed, 13 Feb 2019 11:56:42 +0000	[thread overview]
Message-ID: <20190213115642.GC7540@sirena.org.uk> (raw)
In-Reply-To: <c8677ded56c2fc7c1d375816f1dd8d66@agner.ch>


[-- Attachment #1.1: Type: text/plain, Size: 620 bytes --]

On Tue, Feb 12, 2019 at 08:20:46PM +0100, Stefan Agner wrote:

> > I dropped both patches from my tree.

> I think this is the wrong approach to disable DMA on those devices. The
> device tree is supposed to describe the complete hardware. If the driver
> is not ready to support DMA for that particular variant, we should add
> this information in the driver. We have compatible strings for i.MX
> 6UL/i.MX 7 to disable DMA accordingly.

Yes, that seems sensible - it's vanishingly unlikely that there's any
problem in the hardware here, it's software bugs and quirking in the
driver seems better than changing the DT.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Stefan Agner <stefan@agner.ch>
Cc: Shawn Guo <shawnguo@kernel.org>,
	s.hauer@pengutronix.de, Trent Piepho <tpiepho@impinj.com>,
	linux-imx@nxp.com, linux-kernel@vger.kernel.org,
	robh+dt@kernel.org, devicetree@vger.kernel.org,
	fabio.estevam@nxp.com, mark.rutland@arm.com,
	linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de
Subject: Re: [PATCH 2/2] ARM: dts: imx7: add DMA properties for ECSPI
Date: Wed, 13 Feb 2019 11:56:42 +0000	[thread overview]
Message-ID: <20190213115642.GC7540@sirena.org.uk> (raw)
In-Reply-To: <c8677ded56c2fc7c1d375816f1dd8d66@agner.ch>

[-- Attachment #1: Type: text/plain, Size: 620 bytes --]

On Tue, Feb 12, 2019 at 08:20:46PM +0100, Stefan Agner wrote:

> > I dropped both patches from my tree.

> I think this is the wrong approach to disable DMA on those devices. The
> device tree is supposed to describe the complete hardware. If the driver
> is not ready to support DMA for that particular variant, we should add
> this information in the driver. We have compatible strings for i.MX
> 6UL/i.MX 7 to disable DMA accordingly.

Yes, that seems sensible - it's vanishingly unlikely that there's any
problem in the hardware here, it's software bugs and quirking in the
driver seems better than changing the DT.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2019-02-13 11:56 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-07 13:22 [PATCH 1/2] ARM: dts: imx6ul: add DMA properties for ECSPI Stefan Agner
2019-01-07 13:22 ` Stefan Agner
2019-01-07 13:22 ` Stefan Agner
2019-01-07 13:22 ` [PATCH 2/2] ARM: dts: imx7: " Stefan Agner
2019-01-07 13:22   ` Stefan Agner
2019-02-07 21:00   ` Trent Piepho
2019-02-07 21:00     ` Trent Piepho
2019-02-11  1:23     ` Shawn Guo
2019-02-11  1:23       ` Shawn Guo
2019-02-11 20:14       ` Trent Piepho
2019-02-11 20:14         ` Trent Piepho
2019-02-11 21:34         ` Fabio Estevam
2019-02-11 21:34           ` Fabio Estevam
2019-02-11 22:22           ` Trent Piepho
2019-02-11 22:22             ` Trent Piepho
2019-02-12 19:37             ` Fabio Estevam
2019-02-12 19:37               ` Fabio Estevam
2019-02-13  0:07               ` Trent Piepho
2019-02-13  0:07                 ` Trent Piepho
2019-02-13  0:57                 ` Fabio Estevam
2019-02-13  0:57                   ` Fabio Estevam
2019-02-13  1:10                   ` Trent Piepho
2019-02-13  1:10                     ` Trent Piepho
2019-02-12 19:20       ` Stefan Agner
2019-02-12 19:20         ` Stefan Agner
2019-02-13 11:56         ` Mark Brown [this message]
2019-02-13 11:56           ` Mark Brown
2019-01-13  3:34 ` [PATCH 1/2] ARM: dts: imx6ul: " Shawn Guo
2019-01-13  3:34   ` Shawn Guo
2019-01-13  3:34   ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190213115642.GC7540@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=fabio.estevam@nxp.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=stefan@agner.ch \
    --cc=tpiepho@impinj.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.