From: Rob Herring <robh@kernel.org>
To: Marc Zyngier <marc.zyngier@arm.com>
Cc: Aisheng Dong <aisheng.dong@nxp.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"l.stach@pengutronix.de" <l.stach@pengutronix.de>
Subject: Re: [PATCH V3 2/4] dt-bindings: irq: imx-irqsteer: add multi output interrupts support
Date: Wed, 13 Feb 2019 16:29:52 -0600 [thread overview]
Message-ID: <20190213222952.GA4814@bogus> (raw)
In-Reply-To: <23f5f2f0-79b8-b9f7-9f46-972966563596@arm.com>
On Mon, Feb 11, 2019 at 03:34:23PM +0000, Marc Zyngier wrote:
> On 31/01/2019 08:03, Aisheng Dong wrote:
> > One irqsteer channel can support up to 8 output interrupts.
> >
> > Cc: Marc Zyngier <marc.zyngier@arm.com>
> > Cc: Rob Herring <robh+dt@kernel.org>
> > Cc: Lucas Stach <l.stach@pengutronix.de>
> > Cc: Shawn Guo <shawnguo@kernel.org>
> > Cc: devicetree@vger.kernel.org
> > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> > ---
> > ChangeLog:
> > v2->v3:
> > * fix a typo
> > v1->v2:
> > * remove one unnecessary note.
> > ---
> > .../devicetree/bindings/interrupt-controller/fsl,irqsteer.txt | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt
> > index 6d0a41b..582991c 100644
> > --- a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt
> > +++ b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt
> > @@ -6,8 +6,9 @@ Required properties:
> > - "fsl,imx8m-irqsteer"
> > - "fsl,imx-irqsteer"
> > - reg: Physical base address and size of registers.
> > -- interrupts: Should contain the parent interrupt line used to multiplex the
> > - input interrupts.
> > +- interrupts: Should contain the up to 8 parent interrupt lines used to
> > + multiplex the input interrupts. They should be specified sequentially
> > + from output 0 to 7.
> > - clocks: Should contain one clock for entry in clock-names
> > see Documentation/devicetree/bindings/clock/clock-bindings.txt
> > - clock-names:
> >
>
> I'd like an Ack from a DT person, as this is a change to an existing
> binding.
It's fine as long as old kernels ignore extra entries and new kernels
still support a single entry. Otherwise, it needs a explanation.
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Marc Zyngier <marc.zyngier@arm.com>
Cc: Aisheng Dong <aisheng.dong@nxp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
dl-linux-imx <linux-imx@nxp.com>,
"l.stach@pengutronix.de" <l.stach@pengutronix.de>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"tglx@linutronix.de" <tglx@linutronix.de>
Subject: Re: [PATCH V3 2/4] dt-bindings: irq: imx-irqsteer: add multi output interrupts support
Date: Wed, 13 Feb 2019 16:29:52 -0600 [thread overview]
Message-ID: <20190213222952.GA4814@bogus> (raw)
In-Reply-To: <23f5f2f0-79b8-b9f7-9f46-972966563596@arm.com>
On Mon, Feb 11, 2019 at 03:34:23PM +0000, Marc Zyngier wrote:
> On 31/01/2019 08:03, Aisheng Dong wrote:
> > One irqsteer channel can support up to 8 output interrupts.
> >
> > Cc: Marc Zyngier <marc.zyngier@arm.com>
> > Cc: Rob Herring <robh+dt@kernel.org>
> > Cc: Lucas Stach <l.stach@pengutronix.de>
> > Cc: Shawn Guo <shawnguo@kernel.org>
> > Cc: devicetree@vger.kernel.org
> > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> > ---
> > ChangeLog:
> > v2->v3:
> > * fix a typo
> > v1->v2:
> > * remove one unnecessary note.
> > ---
> > .../devicetree/bindings/interrupt-controller/fsl,irqsteer.txt | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt
> > index 6d0a41b..582991c 100644
> > --- a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt
> > +++ b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt
> > @@ -6,8 +6,9 @@ Required properties:
> > - "fsl,imx8m-irqsteer"
> > - "fsl,imx-irqsteer"
> > - reg: Physical base address and size of registers.
> > -- interrupts: Should contain the parent interrupt line used to multiplex the
> > - input interrupts.
> > +- interrupts: Should contain the up to 8 parent interrupt lines used to
> > + multiplex the input interrupts. They should be specified sequentially
> > + from output 0 to 7.
> > - clocks: Should contain one clock for entry in clock-names
> > see Documentation/devicetree/bindings/clock/clock-bindings.txt
> > - clock-names:
> >
>
> I'd like an Ack from a DT person, as this is a change to an existing
> binding.
It's fine as long as old kernels ignore extra entries and new kernels
still support a single entry. Otherwise, it needs a explanation.
Rob
next prev parent reply other threads:[~2019-02-13 22:30 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-31 8:03 [PATCH V3 0/4] irq: imx-irqsteer: add 32 interrupts chan and multi outputs support Aisheng Dong
2019-01-31 8:03 ` Aisheng Dong
2019-01-31 8:03 ` [PATCH V3 1/4] dt-binding: irq: imx-irqsteer: use irq number instead of group number Aisheng Dong
2019-01-31 8:03 ` Aisheng Dong
2019-02-11 15:35 ` Marc Zyngier
2019-02-11 15:35 ` Marc Zyngier
2019-02-13 22:27 ` Rob Herring
2019-02-13 22:27 ` Rob Herring
2019-02-20 6:36 ` Aisheng Dong
2019-02-20 6:36 ` Aisheng Dong
2019-02-20 6:36 ` Aisheng Dong
2019-01-31 8:03 ` [PATCH V3 2/4] dt-bindings: irq: imx-irqsteer: add multi output interrupts support Aisheng Dong
2019-01-31 8:03 ` Aisheng Dong
2019-01-31 9:05 ` Lucas Stach
2019-01-31 9:05 ` Lucas Stach
2019-02-11 15:34 ` Marc Zyngier
2019-02-11 15:34 ` Marc Zyngier
2019-02-13 22:29 ` Rob Herring [this message]
2019-02-13 22:29 ` Rob Herring
2019-02-20 6:37 ` Aisheng Dong
2019-02-20 6:37 ` Aisheng Dong
2019-01-31 8:03 ` [PATCH V3 3/4] irq: imx-irqsteer: change to use reg_num instead of irq_group Aisheng Dong
2019-01-31 8:03 ` Aisheng Dong
2019-01-31 8:03 ` [PATCH V3 4/4] irq: imx: irqsteer: add multi output interrupts support Aisheng Dong
2019-01-31 8:03 ` Aisheng Dong
2019-01-31 9:08 ` Lucas Stach
2019-01-31 9:08 ` Lucas Stach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190213222952.GA4814@bogus \
--to=robh@kernel.org \
--cc=aisheng.dong@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=shawnguo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.