From: Andrew Lunn <andrew@lunn.ch>
To: Claudiu Manoil <claudiu.manoil@nxp.com>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Alexandru Marginean <alexandru.marginean@nxp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Leo Li <leoyang.li@nxp.com>, Shawn Guo <shawnguo@kernel.org>,
"David S . Miller" <davem@davemloft.net>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH net-next 2/3] arm64: dts: fsl: ls1028a-rdb: Add ENETC external eth ports for the LS1028A RDB board
Date: Thu, 14 Feb 2019 17:27:46 +0100 [thread overview]
Message-ID: <20190214162746.GI708@lunn.ch> (raw)
In-Reply-To: <VI1PR04MB4880C9EF6C9EBFCAA2209DD596670@VI1PR04MB4880.eurprd04.prod.outlook.com>
> Hi Andrew,
>
> The extra node for mdio seems to complicate things somewhat.
> Just adding this node seems not enough. How to find out easily if a child
> of a enetc port node is a mdio node?
You copy somebody else code :-)
https://elixir.bootlin.com/linux/v5.0-rc6/source/drivers/net/dsa/mv88e6xxx/chip.c#L2765
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Claudiu Manoil <claudiu.manoil@nxp.com>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Alexandru Marginean <alexandru.marginean@nxp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Leo Li <leoyang.li@nxp.com>, Shawn Guo <shawnguo@kernel.org>,
"David S . Miller" <davem@davemloft.net>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH net-next 2/3] arm64: dts: fsl: ls1028a-rdb: Add ENETC external eth ports for the LS1028A RDB board
Date: Thu, 14 Feb 2019 17:27:46 +0100 [thread overview]
Message-ID: <20190214162746.GI708@lunn.ch> (raw)
In-Reply-To: <VI1PR04MB4880C9EF6C9EBFCAA2209DD596670@VI1PR04MB4880.eurprd04.prod.outlook.com>
> Hi Andrew,
>
> The extra node for mdio seems to complicate things somewhat.
> Just adding this node seems not enough. How to find out easily if a child
> of a enetc port node is a mdio node?
You copy somebody else code :-)
https://elixir.bootlin.com/linux/v5.0-rc6/source/drivers/net/dsa/mv88e6xxx/chip.c#L2765
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Claudiu Manoil <claudiu.manoil@nxp.com>
Cc: Shawn Guo <shawnguo@kernel.org>, Leo Li <leoyang.li@nxp.com>,
"David S . Miller" <davem@davemloft.net>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Alexandru Marginean <alexandru.marginean@nxp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 2/3] arm64: dts: fsl: ls1028a-rdb: Add ENETC external eth ports for the LS1028A RDB board
Date: Thu, 14 Feb 2019 17:27:46 +0100 [thread overview]
Message-ID: <20190214162746.GI708@lunn.ch> (raw)
In-Reply-To: <VI1PR04MB4880C9EF6C9EBFCAA2209DD596670@VI1PR04MB4880.eurprd04.prod.outlook.com>
> Hi Andrew,
>
> The extra node for mdio seems to complicate things somewhat.
> Just adding this node seems not enough. How to find out easily if a child
> of a enetc port node is a mdio node?
You copy somebody else code :-)
https://elixir.bootlin.com/linux/v5.0-rc6/source/drivers/net/dsa/mv88e6xxx/chip.c#L2765
Andrew
next prev parent reply other threads:[~2019-02-14 16:28 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-13 11:02 [PATCH net-next 0/3] enetc: Add mdio support and device tree nodes Claudiu Manoil
2019-02-13 11:02 ` Claudiu Manoil
2019-02-13 11:02 ` Claudiu Manoil
2019-02-13 11:02 ` [PATCH net-next 1/3] arm64: dts: fsl: ls1028a: Add PCI IERC node and ENETC endpoints Claudiu Manoil
2019-02-13 11:02 ` Claudiu Manoil
2019-02-13 11:02 ` [PATCH net-next 2/3] arm64: dts: fsl: ls1028a-rdb: Add ENETC external eth ports for the LS1028A RDB board Claudiu Manoil
2019-02-13 11:02 ` Claudiu Manoil
2019-02-13 18:15 ` Andrew Lunn
2019-02-13 18:15 ` Andrew Lunn
2019-02-14 15:33 ` Claudiu Manoil
2019-02-14 15:33 ` Claudiu Manoil
2019-02-14 15:33 ` Claudiu Manoil
2019-02-14 16:27 ` Andrew Lunn [this message]
2019-02-14 16:27 ` Andrew Lunn
2019-02-14 16:27 ` Andrew Lunn
2019-02-14 17:00 ` Claudiu Manoil
2019-02-14 17:00 ` Claudiu Manoil
2019-02-13 11:02 ` [PATCH net-next 3/3] enetc: Add ENETC PF level external MDIO support Claudiu Manoil
2019-02-13 11:02 ` Claudiu Manoil
2019-02-13 18:13 ` Andrew Lunn
2019-02-13 18:13 ` Andrew Lunn
2019-02-14 15:48 ` Claudiu Manoil
2019-02-14 15:48 ` Claudiu Manoil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190214162746.GI708@lunn.ch \
--to=andrew@lunn.ch \
--cc=alexandru.marginean@nxp.com \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.