From: Dan Carpenter <dan.carpenter@oracle.com>
To: Chen-Yu Tsai <wens@csie.org>
Cc: Colin King <colin.king@canonical.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
kernel-janitors@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][V2][next] regulator: axp20x: check rdev is null before dereferencing it
Date: Fri, 15 Feb 2019 07:46:58 +0000 [thread overview]
Message-ID: <20190215074658.GF2326@kadam> (raw)
In-Reply-To: <CAGb2v6597uiPec=BPvTZgppxF2upTa_zKHq+QSbddyMGJAd7uA@mail.gmail.com>
On Tue, Feb 05, 2019 at 11:37:40AM +0800, Chen-Yu Tsai wrote:
> On Sat, Dec 22, 2018 at 7:32 PM Colin King <colin.king@canonical.com> wrote:
> >
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > Currently rdev is dereferenced when assigning desc before rdev is null
> > checked, hence there is a potential null pointer dereference on rdev.
> > Fix this by null checking rdev first.
> >
> > Detected by CoverityScan, CID#1476031 ("Dereference before null check")
> >
> > Fixes: 77e3e3b165db ("regulator: axp20x: add software based soft_start for AXP209 LDO3")
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> This patch somehow fell through the cracks. Sorry about that.
>
> Both are really false positives.
I don't like when people use the word "false positive" like this. The
code doesn't checks for NULL after a dereference so that's a nonsense
to do. The correct thing is to remove the NULL check.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Chen-Yu Tsai <wens@csie.org>
Cc: Colin King <colin.king@canonical.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
kernel-janitors@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][V2][next] regulator: axp20x: check rdev is null before dereferencing it
Date: Fri, 15 Feb 2019 10:46:58 +0300 [thread overview]
Message-ID: <20190215074658.GF2326@kadam> (raw)
In-Reply-To: <CAGb2v6597uiPec=BPvTZgppxF2upTa_zKHq+QSbddyMGJAd7uA@mail.gmail.com>
On Tue, Feb 05, 2019 at 11:37:40AM +0800, Chen-Yu Tsai wrote:
> On Sat, Dec 22, 2018 at 7:32 PM Colin King <colin.king@canonical.com> wrote:
> >
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > Currently rdev is dereferenced when assigning desc before rdev is null
> > checked, hence there is a potential null pointer dereference on rdev.
> > Fix this by null checking rdev first.
> >
> > Detected by CoverityScan, CID#1476031 ("Dereference before null check")
> >
> > Fixes: 77e3e3b165db ("regulator: axp20x: add software based soft_start for AXP209 LDO3")
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> This patch somehow fell through the cracks. Sorry about that.
>
> Both are really false positives.
I don't like when people use the word "false positive" like this. The
code doesn't checks for NULL after a dereference so that's a nonsense
to do. The correct thing is to remove the NULL check.
regards,
dan carpenter
next prev parent reply other threads:[~2019-02-15 7:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-22 11:31 [PATCH][V2][next] regulator: axp20x: check rdev is null before dereferencing it Colin King
2018-12-22 11:31 ` Colin King
2019-02-04 19:13 ` Colin Ian King
2019-02-04 19:13 ` Colin Ian King
2019-02-04 19:24 ` Mark Brown
2019-02-04 19:24 ` Mark Brown
2019-02-04 19:30 ` Dan Carpenter
2019-02-04 19:30 ` Dan Carpenter
2019-02-05 3:37 ` Chen-Yu Tsai
2019-02-05 3:37 ` Chen-Yu Tsai
2019-02-15 7:46 ` Dan Carpenter [this message]
2019-02-15 7:46 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190215074658.GF2326@kadam \
--to=dan.carpenter@oracle.com \
--cc=broonie@kernel.org \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.