From: dan.carpenter@oracle.com (Dan Carpenter)
Subject: [PATCH v2] staging: erofs: keep corrupted fs from crashing kernel in erofs_namei()
Date: Fri, 15 Feb 2019 10:57:57 +0300 [thread overview]
Message-ID: <20190215075757.GG2326@kadam> (raw)
In-Reply-To: <a9381c0d-9857-4d03-710d-80006d426bbc@huawei.com>
On Fri, Feb 15, 2019@03:02:25PM +0800, Chao Yu wrote:
> On 2019/2/1 20:16, Gao Xiang wrote:
> > + /*
> > + * on-disk error, let's only BUG_ON in the debugging mode.
> > + * otherwise, it will return 1 to just skip the invalid name
> > + * and go on (in consideration of the lookup performance).
> > + */
> > + DBG_BUGON(qd->name > qd->end);
>
> qd->name == qd->end is not allowed as well?
>
> So will it be better to return directly here?
>
> if (unlikely(qd->name >= qd->end)) {
> DBG_BUGON(1);
> return 1;
> }
Please don't add likely/unlikely() annotations unless you have
benchmarked it and it makes a difference.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Chao Yu <yuchao0@huawei.com>
Cc: Gao Xiang <gaoxiang25@huawei.com>,
Al Viro <viro@ZenIV.linux.org.uk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-erofs@lists.ozlabs.org,
Chao Yu <chao@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
stable@vger.kernel.org, weidu.du@huawei.com,
Fang Wei <fangwei1@huawei.com>, Miao Xie <miaoxie@huawei.com>
Subject: Re: [PATCH v2] staging: erofs: keep corrupted fs from crashing kernel in erofs_namei()
Date: Fri, 15 Feb 2019 10:57:57 +0300 [thread overview]
Message-ID: <20190215075757.GG2326@kadam> (raw)
In-Reply-To: <a9381c0d-9857-4d03-710d-80006d426bbc@huawei.com>
On Fri, Feb 15, 2019 at 03:02:25PM +0800, Chao Yu wrote:
> On 2019/2/1 20:16, Gao Xiang wrote:
> > + /*
> > + * on-disk error, let's only BUG_ON in the debugging mode.
> > + * otherwise, it will return 1 to just skip the invalid name
> > + * and go on (in consideration of the lookup performance).
> > + */
> > + DBG_BUGON(qd->name > qd->end);
>
> qd->name == qd->end is not allowed as well?
>
> So will it be better to return directly here?
>
> if (unlikely(qd->name >= qd->end)) {
> DBG_BUGON(1);
> return 1;
> }
Please don't add likely/unlikely() annotations unless you have
benchmarked it and it makes a difference.
regards,
dan carpenter
next prev parent reply other threads:[~2019-02-15 7:57 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-01 12:16 [PATCH v2] staging: erofs: keep corrupted fs from crashing kernel in erofs_namei() Gao Xiang
2019-02-01 12:16 ` Gao Xiang
2019-02-12 5:05 ` Gao Xiang
2019-02-12 5:05 ` Gao Xiang
2019-02-15 7:02 ` Chao Yu
2019-02-15 7:02 ` Chao Yu
2019-02-15 7:57 ` Dan Carpenter [this message]
2019-02-15 7:57 ` Dan Carpenter
2019-02-15 9:04 ` Gao Xiang
2019-02-15 9:04 ` Gao Xiang
2019-02-15 9:32 ` Chao Yu
2019-02-15 9:32 ` Chao Yu
2019-02-15 9:35 ` Dan Carpenter
2019-02-15 9:35 ` Dan Carpenter
2019-02-15 10:33 ` Gao Xiang
2019-02-15 10:33 ` Gao Xiang
2019-02-18 2:41 ` Chao Yu
2019-02-18 2:41 ` Chao Yu
2019-02-18 6:16 ` Dan Carpenter
2019-02-18 6:16 ` Dan Carpenter
2019-02-15 8:58 ` Gao Xiang
2019-02-15 8:58 ` Gao Xiang
2019-02-18 1:39 ` Chao Yu
2019-02-18 1:39 ` Chao Yu
2019-02-18 2:17 ` Gao Xiang
2019-02-18 2:17 ` Gao Xiang
2019-02-18 2:50 ` Chao Yu
2019-02-18 2:50 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190215075757.GG2326@kadam \
--to=dan.carpenter@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.