From: mark gross <mgross@linux.intel.com>
To: speck@linutronix.de
Subject: [MODERATED] Re: [RFC][PATCH] performance walnuts
Date: Fri, 15 Feb 2019 09:32:47 -0800 [thread overview]
Message-ID: <20190215173247.GA11340@mgross-MOBL.amr.corp.intel.com> (raw)
In-Reply-To: <20190213025634.GA9876@mgross-MOBL.amr.corp.intel.com>
[-- Attachment #1: Type: text/plain, Size: 2776 bytes --]
On Tue, Feb 12, 2019 at 06:56:34PM -0800, speck for mark gross wrote:
> On Fri, Feb 08, 2019 at 11:53:18AM +0100, speck for Peter Zijlstra wrote:
> > On Fri, Feb 08, 2019 at 10:39:50AM +0100, Peter Zijlstra wrote:
> > > Ah, I think I found a way to avoid having to rely on this. Let me try.
> >
> > Something like so. Can someone with access to a relevant machine test
> > this?
> FWIW I have just forwarded this patch to the folks testing Andi's work. One of
> those enginees is working on getting his access to this spec list at this time.
>
Ok Nelson ran the unit test on Peter's patch. Oh I'm told we need to avoid
using the internal codenames in our patches.
the following is thest log and attached are 2 dmesg dumps from the failing
tests.
root@jf1-otc-3AR3-33:/home/labuser/ocean/tools/perf# echo 0 > /sys/devices/cpu/allow_tsx_force_abort
root@jf1-otc-3AR3-33:/home/labuser/ocean/tools/perf# dmesg -C
root@jf1-otc-3AR3-33:/home/labuser/ocean/tools/perf# ./perf stat -e '{cache-misses,cache-references,branches,branch-misses}' -a sleep 1
Killed
root@jf1-otc-3AR3-33:/home/labuser/ocean/tools/perf# dmesg > tsx_force_abort_0.dmesg
root@jf1-otc-3AR3-33:/home/labuser/ocean/tools/perf# dmesg -C
root@jf1-otc-3AR3-33:/home/labuser/ocean/tools/perf# ./perf stat -e '{cache-misses,cache-references,branches}' -a sleep 1
Killed
root@jf1-otc-3AR3-33:/home/labuser/ocean/tools/perf# dmesg > tsx_force_abort_0.dmesg-3counters
root@jf1-otc-3AR3-33:/home/labuser/ocean/tools/perf# dmesg -C
root@jf1-otc-3AR3-33:/home/labuser/ocean/tools/perf# echo 1 > /sys/devices/cpu/allow_tsx_force_abort
root@jf1-otc-3AR3-33:/home/labuser/ocean/tools/perf# dmesg -C
root@jf1-otc-3AR3-33:/home/labuser/ocean/tools/perf# ./perf stat -e '{cache-misses,cache-references,branches,branch-misses}' -a sleep 1
Performance counter stats for 'system wide':
16,917 cache-misses # 6.500 % of all cache refs
260,246 cache-references
774,346 branches
36,353 branch-misses # 4.69% of all branches
1.005494153 seconds time elapsed
root@jf1-otc-3AR3-33:/home/labuser/ocean/tools/perf# ./perf stat -e '{cache-misses,cache-references,branches}' -a sleep 1
Performance counter stats for 'system wide':
25,902 cache-misses # 7.233 % of all cache refs
358,111 cache-references
5,683,441 branches
1.005578086 seconds time elapsed
/home/labuser/ocean/tools/perf# ./perf --version
perf version 5.0.rc5.g088c82c
[-- Attachment #2: tsx_force_abort_0.dmesg --]
[-- Type: text/plain, Size: 5106 bytes --]
[60498.742721] BUG: unable to handle kernel paging request at ffffffffffffffd8
[60498.749676] #PF error: [WRITE]
[60498.752736] PGD ce8212067 P4D ce8212067 PUD ce8214067 PMD 0
[60498.758395] Oops: 0002 [#9] SMP PTI
[60498.761889] CPU: 70 PID: 6847 Comm: perf Tainted: G D W 5.0.0-rc5-1-peterz-feb8 #1
[60498.770577] Hardware name: Intel Corporation S2600WFQ/S2600WFQ, BIOS SE5C620.86B.00.01.0014.070920180847 07/09/2018
[60498.781008] RIP: 0010:dyn_constraint.isra.15+0x26/0x60
[60498.786141] Code: 00 00 c3 90 0f 1f 44 00 00 48 85 ff 48 89 f0 74 44 8b 48 20 f6 c1 80 75 3a 48 63 d2 48 8b 30 80 c9 80 48 8d 14 92 48 8d 14 d7 <48> 89 32 48 8b 70 08 48 89 72 08 48 8b 70 10 48 89 72 10 48 8b 70
[60498.804887] RSP: 0018:ffffbe498ef3fd98 EFLAGS: 00010282
[60498.810111] RAX: ffffffffac91e0a0 RBX: 00000000ffffffff RCX: 0000000000000080
[60498.817245] RDX: ffffffffffffffd8 RSI: 000000000000000f RDI: 0000000000000000
[60498.824377] RBP: ffff9e34d32c6000 R08: ffff9e34dfaa5e60 R09: ffff9e1ce0007300
[60498.831510] R10: ffff9e34d0cc78c0 R11: ffffffffac98d3a8 R12: ffff9e34d32c6000
[60498.838642] R13: ffff9e34ad8d2000 R14: ffffffffac21a7a0 R15: 0000000000000000
[60498.845775] FS: 00007fc59591d500(0000) GS:ffff9e34dfa80000(0000) knlGS:0000000000000000
[60498.853857] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[60498.859605] CR2: ffffffffffffffd8 CR3: 0000002fb2966002 CR4: 00000000007606e0
[60498.866737] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[60498.873870] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
[60498.881002] PKRU: 55555554
[60498.883711] Call Trace:
[60498.886159] skl_get_event_constraints+0x38/0x60
[60498.890779] x86_pmu_event_init+0x1c0/0x210
[60498.894966] perf_try_init_event+0x7b/0xa0
[60498.899063] perf_event_alloc+0x7e0/0x980
[60498.903075] __do_sys_perf_event_open+0x1f4/0xba0
[60498.907778] do_syscall_64+0x55/0x100
[60498.911450] entry_SYSCALL_64_after_hwframe+0x44/0xa9
[60498.916497] RIP: 0033:0x7fc593d82839
[60498.920074] Code: 00 f3 c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 1f f6 2c 00 f7 d8 64 89 01 48
[60498.938819] RSP: 002b:00007ffeefbe5cb8 EFLAGS: 00000246 ORIG_RAX: 000000000000012a
[60498.946384] RAX: ffffffffffffffda RBX: 00000000ffffffff RCX: 00007fc593d82839
[60498.953517] RDX: 0000000000000000 RSI: 00000000ffffffff RDI: 000056224565e7a8
[60498.960648] RBP: 00007ffeefbe5da0 R08: 0000000000000008 R09: 0000000000000008
[60498.967781] R10: 00000000ffffffff R11: 0000000000000246 R12: 0000000000000000
[60498.974913] R13: 0000000000000000 R14: 00005622456d7e58 R15: 000056224565e790
[60498.982046] Modules linked in: xt_CHECKSUM iptable_mangle ipt_MASQUERADE iptable_nat nf_nat_ipv4 bridge stp llc ebtable_filter ebtables ipmi_ssif intel_rapl skx_edac nfit x86_pkg_temp_thermal intel_powerclamp coretemp binfmt_misc crct10dif_pclmul crc32_pclmul ghash_clmulni_intel aesni_intel aes_x86_64 crypto_simd cryptd glue_helper joydev input_leds kvm_intel mei_me lpc_ich mei ipmi_si ioatdma ipmi_devintf dca ipmi_msghandler acpi_pad acpi_power_meter mac_hid ip6t_REJECT nf_reject_ipv6 nf_log_ipv6 xt_hl ip6t_rt ipt_REJECT nf_reject_ipv4 nf_log_ipv4 nf_log_common xt_LOG xt_limit xt_tcpudp xt_addrtype xt_conntrack ip6table_filter nfsd ip6_tables nf_conntrack_netbios_ns nf_conntrack_broadcast auth_rpcgss nf_nat_ftp nf_nat nfs_acl nf_conntrack_ftp sch_fq_codel lockd nf_conntrack grace nf_defrag_ipv6 parport_pc sunrpc nf_defrag_ipv4 ppdev libcrc32c iptable_filter lp parport ip_tables x_tables autofs4 hid_generic usbhid hid ast i2c_algo_bit ttm drm_kms_helper syscopyarea sysfillrect sysimgblt
[60498.982084] fb_sys_fops megaraid_sas i40e drm ahci i2c_i801 libahci wmi
[60499.075987] CR2: ffffffffffffffd8
[60499.079305] ---[ end trace 679d8c93fc6d7975 ]---
[60499.084898] RIP: 0010:dyn_constraint.isra.15+0x26/0x60
[60499.090033] Code: 00 00 c3 90 0f 1f 44 00 00 48 85 ff 48 89 f0 74 44 8b 48 20 f6 c1 80 75 3a 48 63 d2 48 8b 30 80 c9 80 48 8d 14 92 48 8d 14 d7 <48> 89 32 48 8b 70 08 48 89 72 08 48 8b 70 10 48 89 72 10 48 8b 70
[60499.108776] RSP: 0018:ffffbe49a0d17d98 EFLAGS: 00010282
[60499.114001] RAX: ffffffffac91e0a0 RBX: 00000000ffffffff RCX: 0000000000000080
[60499.121136] RDX: ffffffffffffffd8 RSI: 000000000000000f RDI: 0000000000000000
[60499.128266] RBP: ffff9e34d3480000 R08: ffff9e34df465e60 R09: ffff9e1ce0007300
[60499.135399] R10: ffff9e34d13cb740 R11: 0000000000000002 R12: ffff9e34d3480000
[60499.142531] R13: ffff9e34d1189000 R14: ffffffffac21a7a0 R15: 0000000000000000
[60499.149663] FS: 00007fc59591d500(0000) GS:ffff9e34dfa80000(0000) knlGS:0000000000000000
[60499.157748] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[60499.163495] CR2: ffffffffffffffd8 CR3: 0000002fb2966002 CR4: 00000000007606e0
[60499.170624] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[60499.177749] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
[60499.184880] PKRU: 55555554
[-- Attachment #3: tsx_force_abort_0.dmesg-3counters --]
[-- Type: text/plain, Size: 5273 bytes --]
[60557.346702] BUG: unable to handle kernel paging request at ffffffffffffffd8
[60557.353665] #PF error: [WRITE]
[60557.356721] PGD ce8212067 P4D ce8212067 PUD ce8214067 PMD 0
[60557.362379] Oops: 0002 [#10] SMP PTI
[60557.365962] CPU: 70 PID: 6853 Comm: perf Tainted: G D W 5.0.0-rc5-1-peterz-feb8 #1
[60557.374651] Hardware name: Intel Corporation S2600WFQ/S2600WFQ, BIOS SE5C620.86B.00.01.0014.070920180847 07/09/2018
[60557.385081] RIP: 0010:dyn_constraint.isra.15+0x26/0x60
[60557.390214] Code: 00 00 c3 90 0f 1f 44 00 00 48 85 ff 48 89 f0 74 44 8b 48 20 f6 c1 80 75 3a 48 63 d2 48 8b 30 80 c9 80 48 8d 14 92 48 8d 14 d7 <48> 89 32 48 8b 70 08 48 89 72 08 48 8b 70 10 48 89 72 10 48 8b 70
[60557.408960] RSP: 0018:ffffbe498f73fd98 EFLAGS: 00010282
[60557.414185] RAX: ffffffffac91e0a0 RBX: 00000000ffffffff RCX: 0000000000000080
[60557.421317] RDX: ffffffffffffffd8 RSI: 000000000000000f RDI: 0000000000000000
[60557.428450] RBP: ffff9e34d2878000 R08: ffff9e34dfaa5e60 R09: ffff9e1ce0007300
[60557.435582] R10: ffff9e34d0cc7bc0 R11: 0000000000000002 R12: ffff9e34d2878000
[60557.442715] R13: ffff9e34ad8d1800 R14: ffffffffac21a7a0 R15: 0000000000000000
[60557.449848] FS: 00007fd918475500(0000) GS:ffff9e34dfa80000(0000) knlGS:0000000000000000
[60557.457931] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[60557.463675] CR2: ffffffffffffffd8 CR3: 0000002fb2960001 CR4: 00000000007606e0
[60557.470800] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[60557.477933] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
[60557.485064] PKRU: 55555554
[60557.487778] Call Trace:
[60557.490230] skl_get_event_constraints+0x38/0x60
[60557.494850] x86_pmu_event_init+0x1c0/0x210
[60557.499037] perf_try_init_event+0x7b/0xa0
[60557.503134] perf_event_alloc+0x7e0/0x980
[60557.507147] __do_sys_perf_event_open+0x1f4/0xba0
[60557.511854] do_syscall_64+0x55/0x100
[60557.515522] entry_SYSCALL_64_after_hwframe+0x44/0xa9
[60557.520572] RIP: 0033:0x7fd9168da839
[60557.524148] Code: 00 f3 c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 1f f6 2c 00 f7 d8 64 89 01 48
[60557.542894] RSP: 002b:00007ffd45e7a6a8 EFLAGS: 00000246 ORIG_RAX: 000000000000012a
[60557.550457] RAX: ffffffffffffffda RBX: 00000000ffffffff RCX: 00007fd9168da839
[60557.557590] RDX: 0000000000000000 RSI: 00000000ffffffff RDI: 000055a9685a67a8
[60557.564722] RBP: 00007ffd45e7a790 R08: 0000000000000008 R09: 0000000000000008
[60557.571854] R10: 00000000ffffffff R11: 0000000000000246 R12: 0000000000000000
[60557.578986] R13: 0000000000000000 R14: 000055a9686292b8 R15: 000055a9685a6790
[60557.586117] Modules linked in: xt_CHECKSUM iptable_mangle ipt_MASQUERADE iptable_nat nf_nat_ipv4 bridge stp llc ebtable_filter ebtables ipmi_ssif intel_rapl skx_edac nfit x86_pkg_temp_thermal intel_powerclamp coretemp binfmt_misc crct10dif_pclmul crc32_pclmul ghash_clmulni_intel aesni_intel aes_x86_64 crypto_simd cryptd glue_helper joydev input_leds kvm_intel mei_me lpc_ich mei ipmi_si ioatdma ipmi_devintf dca ipmi_msghandler acpi_pad acpi_power_meter mac_hid ip6t_REJECT nf_reject_ipv6 nf_log_ipv6 xt_hl ip6t_rt ipt_REJECT nf_reject_ipv4 nf_log_ipv4 nf_log_common xt_LOG xt_limit xt_tcpudp xt_addrtype xt_conntrack ip6table_filter nfsd ip6_tables nf_conntrack_netbios_ns nf_conntrack_broadcast auth_rpcgss nf_nat_ftp nf_nat nfs_acl nf_conntrack_ftp sch_fq_codel lockd nf_conntrack grace nf_defrag_ipv6 parport_pc sunrpc nf_defrag_ipv4 ppdev libcrc32c iptable_filter lp parport ip_tables x_tables autofs4 hid_generic usbhid hid ast i2c_algo_bit ttm drm_kms_helper syscopyarea sysfillrect sysimgblt
[60557.586152] fb_sys_fops megaraid_sas i40e drm ahci i2c_i801 libahci wmi
[60557.680060] CR2: ffffffffffffffd8
[60557.683379] ---[ end trace 679d8c93fc6d7976 ]---
[60557.688978] RIP: 0010:dyn_constraint.isra.15+0x26/0x60
[60557.694115] Code: 00 00 c3 90 0f 1f 44 00 00 48 85 ff 48 89 f0 74 44 8b 48 20 f6 c1 80 75 3a 48 63 d2 48 8b 30 80 c9 80 48 8d 14 92 48 8d 14 d7 <48> 89 32 48 8b 70 08 48 89 72 08 48 8b 70 10 48 89 72 10 48 8b 70
[60557.712859] RSP: 0018:ffffbe49a0d17d98 EFLAGS: 00010282
[60557.718084] RAX: ffffffffac91e0a0 RBX: 00000000ffffffff RCX: 0000000000000080
[60557.725216] RDX: ffffffffffffffd8 RSI: 000000000000000f RDI: 0000000000000000
[60557.732349] RBP: ffff9e34d3480000 R08: ffff9e34df465e60 R09: ffff9e1ce0007300
[60557.739481] R10: ffff9e34d13cb740 R11: 0000000000000002 R12: ffff9e34d3480000
[60557.746613] R13: ffff9e34d1189000 R14: ffffffffac21a7a0 R15: 0000000000000000
[60557.753745] FS: 00007fd918475500(0000) GS:ffff9e34dfa80000(0000) knlGS:0000000000000000
[60557.761830] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[60557.767577] CR2: ffffffffffffffd8 CR3: 0000002fb2960001 CR4: 00000000007606e0
[60557.774710] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[60557.781838] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
[60557.788963] PKRU: 55555554
[60565.348258] [UFW BLOCK] IN=eno2 OUT= MAC=01:00:5e:00:00:01:00:04:96:82:75:3d:08:00 SRC=10.54.39.2 DST=224.0.0.1 LEN=32 TOS=0x00 PREC=0xC0 TTL=1 ID=14738 PROTO=2
next prev parent reply other threads:[~2019-02-15 17:32 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-07 23:41 [MODERATED] [PATCH v3 0/6] PERFv3 Andi Kleen
2019-02-07 23:41 ` [MODERATED] [PATCH v3 1/6] PERFv3 Andi Kleen
2019-02-08 8:45 ` [MODERATED] " Peter Zijlstra
2019-02-07 23:41 ` [MODERATED] [PATCH v3 2/6] PERFv3 Andi Kleen
2019-02-08 0:51 ` [MODERATED] Re: [SUSPECTED SPAM][PATCH " Andrew Cooper
2019-02-08 9:01 ` Peter Zijlstra
2019-02-08 9:31 ` [MODERATED] Re: [PATCH " Andrew Cooper
2019-02-08 9:39 ` [MODERATED] Re: [SUSPECTED SPAM][PATCH " Peter Zijlstra
2019-02-08 10:53 ` [MODERATED] [RFC][PATCH] performance walnuts Peter Zijlstra
2019-02-08 18:07 ` [MODERATED] " Andi Kleen
2019-02-11 10:40 ` Peter Zijlstra
2019-02-11 14:06 ` Thomas Gleixner
2019-02-11 20:17 ` [MODERATED] " Konrad Rzeszutek Wilk
2019-02-11 23:39 ` Thomas Gleixner
2019-02-09 0:28 ` [MODERATED] " Linus Torvalds
2019-02-09 4:34 ` Andi Kleen
2019-02-09 8:57 ` Peter Zijlstra
2019-02-13 2:56 ` mark gross
2019-02-15 17:32 ` mark gross [this message]
2019-02-15 17:44 ` Peter Zijlstra
2019-02-15 20:47 ` mark gross
2019-02-15 21:33 ` Thomas Gleixner
2019-02-19 13:35 ` [MODERATED] [RFC][PATCH v2] " Peter Zijlstra
2019-02-15 23:45 ` [MODERATED] Encrypted Message Jon Masters
2019-02-08 8:50 ` [MODERATED] Re: [PATCH v3 2/6] PERFv3 Peter Zijlstra
2019-02-08 17:26 ` Andi Kleen
2019-02-07 23:41 ` [MODERATED] [PATCH v3 3/6] PERFv3 Andi Kleen
2019-02-08 9:02 ` [MODERATED] " Peter Zijlstra
2019-02-07 23:41 ` [MODERATED] [PATCH v3 4/6] PERFv3 Andi Kleen
2019-02-07 23:41 ` [MODERATED] [PATCH v3 5/6] PERFv3 Andi Kleen
2019-02-08 0:54 ` [MODERATED] " Andrew Cooper
2019-02-07 23:41 ` [MODERATED] [PATCH v3 6/6] PERFv3 Andi Kleen
2019-02-08 9:07 ` [MODERATED] " Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190215173247.GA11340@mgross-MOBL.amr.corp.intel.com \
--to=mgross@linux.intel.com \
--cc=speck@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.