* [PATCH] scsi: mpt3sas: Add missing breaks in switch statements
@ 2019-02-15 21:54 Gustavo A. R. Silva
2019-02-27 14:37 ` Martin K. Petersen
0 siblings, 1 reply; 3+ messages in thread
From: Gustavo A. R. Silva @ 2019-02-15 21:54 UTC (permalink / raw)
To: Sathya Prakash, Chaitra P B, Suganath Prabu Subramani,
James E.J. Bottomley, Martin K. Petersen
Cc: MPT-FusionLinux.pdl, linux-scsi, linux-kernel,
Gustavo A. R. Silva, Kees Cook
Fix the following warnings by adding the proper missing breaks:
drivers/scsi/mpt3sas/mpt3sas_base.c: In function ‘_base_display_OEMs_branding’:
drivers/scsi/mpt3sas/mpt3sas_base.c:3548:4: warning: this statement may fall through [-Wimplicit-fallthrough=]
switch (ioc->pdev->subsystem_device) {
^~~~~~
drivers/scsi/mpt3sas/mpt3sas_base.c:3566:3: note: here
case MPI2_MFGPAGE_DEVID_SAS2308_2:
^~~~
drivers/scsi/mpt3sas/mpt3sas_base.c:3567:4: warning: this statement may fall through [-Wimplicit-fallthrough=]
switch (ioc->pdev->subsystem_device) {
^~~~~~
drivers/scsi/mpt3sas/mpt3sas_base.c:3601:3: note: here
case MPI25_MFGPAGE_DEVID_SAS3008:
^~~~
drivers/scsi/mpt3sas/mpt3sas_base.c:3735:4: warning: this statement may fall through [-Wimplicit-fallthrough=]
switch (ioc->pdev->subsystem_device) {
^~~~~~
drivers/scsi/mpt3sas/mpt3sas_base.c:3745:3: note: here
case MPI2_MFGPAGE_DEVID_SAS2308_2:
^~~~
drivers/scsi/mpt3sas/mpt3sas_base.c:3746:4: warning: this statement may fall through [-Wimplicit-fallthrough=]
switch (ioc->pdev->subsystem_device) {
^~~~~~
drivers/scsi/mpt3sas/mpt3sas_base.c:3768:3: note: here
default:
^~~~~~~
Warning level 3 was used: -Wimplicit-fallthrough=3
This patch is part of the ongoing efforts to enable
-Wimplicit-fallthrough.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/scsi/mpt3sas/mpt3sas_base.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c
index 0a6cb8f0680c..e57774472e75 100644
--- a/drivers/scsi/mpt3sas/mpt3sas_base.c
+++ b/drivers/scsi/mpt3sas/mpt3sas_base.c
@@ -3563,6 +3563,7 @@ _base_display_OEMs_branding(struct MPT3SAS_ADAPTER *ioc)
ioc->pdev->subsystem_device);
break;
}
+ break;
case MPI2_MFGPAGE_DEVID_SAS2308_2:
switch (ioc->pdev->subsystem_device) {
case MPT2SAS_INTEL_RS25GB008_SSDID:
@@ -3598,6 +3599,7 @@ _base_display_OEMs_branding(struct MPT3SAS_ADAPTER *ioc)
ioc->pdev->subsystem_device);
break;
}
+ break;
case MPI25_MFGPAGE_DEVID_SAS3008:
switch (ioc->pdev->subsystem_device) {
case MPT3SAS_INTEL_RMS3JC080_SSDID:
@@ -3742,6 +3744,7 @@ _base_display_OEMs_branding(struct MPT3SAS_ADAPTER *ioc)
ioc->pdev->subsystem_device);
break;
}
+ break;
case MPI2_MFGPAGE_DEVID_SAS2308_2:
switch (ioc->pdev->subsystem_device) {
case MPT2SAS_HP_2_4_INTERNAL_SSDID:
@@ -3765,6 +3768,7 @@ _base_display_OEMs_branding(struct MPT3SAS_ADAPTER *ioc)
ioc->pdev->subsystem_device);
break;
}
+ break;
default:
ioc_info(ioc, "HP SAS HBA: Subsystem ID: 0x%X\n",
ioc->pdev->subsystem_device);
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] scsi: mpt3sas: Add missing breaks in switch statements
2019-02-15 21:54 [PATCH] scsi: mpt3sas: Add missing breaks in switch statements Gustavo A. R. Silva
@ 2019-02-27 14:37 ` Martin K. Petersen
2019-02-28 20:03 ` Gustavo A. R. Silva
0 siblings, 1 reply; 3+ messages in thread
From: Martin K. Petersen @ 2019-02-27 14:37 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Sathya Prakash, Chaitra P B, Suganath Prabu Subramani,
James E.J. Bottomley, Martin K. Petersen, MPT-FusionLinux.pdl,
linux-scsi, linux-kernel, Kees Cook
Gustavo,
> Fix the following warnings by adding the proper missing breaks:
>
> drivers/scsi/mpt3sas/mpt3sas_base.c: In function ‘_base_display_OEMs_branding’:
> drivers/scsi/mpt3sas/mpt3sas_base.c:3548:4: warning: this statement may fall thr
Applied to 5.1/scsi-queue, thanks.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: mpt3sas: Add missing breaks in switch statements
2019-02-27 14:37 ` Martin K. Petersen
@ 2019-02-28 20:03 ` Gustavo A. R. Silva
0 siblings, 0 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2019-02-28 20:03 UTC (permalink / raw)
To: Martin K. Petersen
Cc: Sathya Prakash, Chaitra P B, Suganath Prabu Subramani,
James E.J. Bottomley, MPT-FusionLinux.pdl, linux-scsi,
linux-kernel, Kees Cook
On 2/27/19 8:37 AM, Martin K. Petersen wrote:
>
> Gustavo,
>
>> Fix the following warnings by adding the proper missing breaks:
>>
>> drivers/scsi/mpt3sas/mpt3sas_base.c: In function ‘_base_display_OEMs_branding’:
>> drivers/scsi/mpt3sas/mpt3sas_base.c:3548:4: warning: this statement may fall thr
>
> Applied to 5.1/scsi-queue, thanks.
>
Thank you, Martin.
There many patches in this series:
https://lore.kernel.org/patchwork/project/lkml/list/?series=374317
that never were acked/reviewed even after I have
pinged twice.
I wonder if you could apply them.
Thanks
--
Gustavo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-02-28 20:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-15 21:54 [PATCH] scsi: mpt3sas: Add missing breaks in switch statements Gustavo A. R. Silva
2019-02-27 14:37 ` Martin K. Petersen
2019-02-28 20:03 ` Gustavo A. R. Silva
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.