All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yangtao Li <tiny.windzz@gmail.com>
To: cw00.choi@samsung.com, myungjoo.ham@samsung.com,
	kyungmin.park@samsung.com, heiko@sntech.de,
	thierry.reding@gmail.com, jonathanh@nvidia.com
Cc: linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux-tegra@vger.kernel.org, Yangtao Li <tiny.windzz@gmail.com>
Subject: [PATCH 3/3] PM / devfreq: tegra: remove unneeded variable
Date: Sat, 16 Feb 2019 10:18:26 -0500	[thread overview]
Message-ID: <20190216151826.11584-4-tiny.windzz@gmail.com> (raw)
In-Reply-To: <20190216151826.11584-1-tiny.windzz@gmail.com>

This variable is not used after initialization, so
remove it. And in order to unify the code style,
move the location where the dev_get_drvdata is called
by the way.

Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
---
 drivers/devfreq/tegra-devfreq.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/devfreq/tegra-devfreq.c b/drivers/devfreq/tegra-devfreq.c
index c59d2eee5d30..c89ba7b834ff 100644
--- a/drivers/devfreq/tegra-devfreq.c
+++ b/drivers/devfreq/tegra-devfreq.c
@@ -573,10 +573,7 @@ static int tegra_governor_get_target(struct devfreq *devfreq,
 static int tegra_governor_event_handler(struct devfreq *devfreq,
 					unsigned int event, void *data)
 {
-	struct tegra_devfreq *tegra;
-	int ret = 0;
-
-	tegra = dev_get_drvdata(devfreq->dev.parent);
+	struct tegra_devfreq *tegra = dev_get_drvdata(devfreq->dev.parent);
 
 	switch (event) {
 	case DEVFREQ_GOV_START:
@@ -600,7 +597,7 @@ static int tegra_governor_event_handler(struct devfreq *devfreq,
 		break;
 	}
 
-	return ret;
+	return 0;
 }
 
 static struct devfreq_governor tegra_devfreq_governor = {
-- 
2.17.0

WARNING: multiple messages have this Message-ID (diff)
From: Yangtao Li <tiny.windzz@gmail.com>
To: cw00.choi@samsung.com, myungjoo.ham@samsung.com,
	kyungmin.park@samsung.com, heiko@sntech.de,
	thierry.reding@gmail.com, jonathanh@nvidia.com
Cc: linux-pm@vger.kernel.org, Yangtao Li <tiny.windzz@gmail.com>,
	linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
	linux-tegra@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] PM / devfreq: tegra: remove unneeded variable
Date: Sat, 16 Feb 2019 10:18:26 -0500	[thread overview]
Message-ID: <20190216151826.11584-4-tiny.windzz@gmail.com> (raw)
In-Reply-To: <20190216151826.11584-1-tiny.windzz@gmail.com>

This variable is not used after initialization, so
remove it. And in order to unify the code style,
move the location where the dev_get_drvdata is called
by the way.

Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
---
 drivers/devfreq/tegra-devfreq.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/devfreq/tegra-devfreq.c b/drivers/devfreq/tegra-devfreq.c
index c59d2eee5d30..c89ba7b834ff 100644
--- a/drivers/devfreq/tegra-devfreq.c
+++ b/drivers/devfreq/tegra-devfreq.c
@@ -573,10 +573,7 @@ static int tegra_governor_get_target(struct devfreq *devfreq,
 static int tegra_governor_event_handler(struct devfreq *devfreq,
 					unsigned int event, void *data)
 {
-	struct tegra_devfreq *tegra;
-	int ret = 0;
-
-	tegra = dev_get_drvdata(devfreq->dev.parent);
+	struct tegra_devfreq *tegra = dev_get_drvdata(devfreq->dev.parent);
 
 	switch (event) {
 	case DEVFREQ_GOV_START:
@@ -600,7 +597,7 @@ static int tegra_governor_event_handler(struct devfreq *devfreq,
 		break;
 	}
 
-	return ret;
+	return 0;
 }
 
 static struct devfreq_governor tegra_devfreq_governor = {
-- 
2.17.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2019-02-16 15:18 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-16 15:18 [PATCH 0/3] PM / devfreq: do some cleanup Yangtao Li
2019-02-16 15:18 ` Yangtao Li
2019-02-16 15:18 ` [PATCH 1/3] PM / devfreq: rk3399_dmc: remove unneeded semicolon Yangtao Li
2019-02-16 15:18   ` Yangtao Li
     [not found]   ` <20190216151826.11584-2-tiny.windzz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-02-18  0:34     ` Chanwoo Choi
2019-02-18  0:34       ` Chanwoo Choi
2019-02-18  0:34       ` Chanwoo Choi
2019-02-20 13:55       ` MyungJoo Ham
2019-02-20 13:55         ` MyungJoo Ham
2019-02-16 15:18 ` [PATCH 2/3] PM / devfreq: rockchip-dfi: " Yangtao Li
2019-02-16 15:18   ` Yangtao Li
     [not found]   ` <20190216151826.11584-3-tiny.windzz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-02-18  0:35     ` Chanwoo Choi
2019-02-18  0:35       ` Chanwoo Choi
2019-02-18  0:35       ` Chanwoo Choi
2019-02-20 13:57       ` MyungJoo Ham
2019-02-20 13:57         ` MyungJoo Ham
2019-02-16 15:18 ` Yangtao Li [this message]
2019-02-16 15:18   ` [PATCH 3/3] PM / devfreq: tegra: remove unneeded variable Yangtao Li
2019-02-18  0:38   ` Chanwoo Choi
2019-02-18  0:38     ` Chanwoo Choi
2019-02-18  9:55     ` Jon Hunter
2019-02-18  9:55       ` Jon Hunter
2019-02-18  9:55       ` Jon Hunter
2019-02-20 14:25       ` MyungJoo Ham
2019-02-20 14:25         ` MyungJoo Ham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190216151826.11584-4-tiny.windzz@gmail.com \
    --to=tiny.windzz@gmail.com \
    --cc=cw00.choi@samsung.com \
    --cc=heiko@sntech.de \
    --cc=jonathanh@nvidia.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=myungjoo.ham@samsung.com \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.