From: "Linus Lüssing" <linus.luessing@c0d3.blue>
To: nikolay@cumulusnetworks.com
Cc: netdev@vger.kernel.org, roopa@cumulusnetworks.com,
bridge@lists.linux-foundation.org, wkok@cumulusnetworks.com,
Ido Schimmel <idosch@idosch.org>,
anuradhak@cumulusnetworks.com, davem@davemloft.net
Subject: Re: [Bridge] [PATCH RFC] net: bridge: don't flood known multicast traffic when snooping is enabled
Date: Sat, 16 Feb 2019 21:37:19 +0100 [thread overview]
Message-ID: <20190216203719.GC25057@otheros> (raw)
In-Reply-To: <E8A29F94-091F-44CA-9E33-481BF21C359D@cumulusnetworks.com>
On Sat, Feb 16, 2019 at 09:27:26PM +0200, nikolay@cumulusnetworks.com wrote:
> >>The no querier condition is not currently reflected via switchdev, so
> >>the behavior you're proposing in your patch is what actually happens
> >in
> >>the data plane.
> >>
> >>We already hit the problem Linus mentioned in commit b00589af3b04
> >>("bridge: disable snooping if there is no querier"). Namely, IPv6 ND
> >>broke because a port joined before the bridge was created.
> >>
> >>I introduced a workaround in commit 9d45deb04c59 ("mlxsw: spectrum:
> >>Treat IPv6 unregistered multicast as broadcast"). I'm interested to
> >>know
> >>what other vendors are doing. Can you elaborate?
> >>
> >
> >Exactly like your fix. :) Flood it, this patch unfortunately breaks it
> >because of mrouters flag, but we can retain the behaviour
> >by forwarding only known mdsts to their ports and flooding
> >unregistered mcast when there is no querier. I think that is
> >what others do by default too, actually I think they flood with querier
> >as well. Maybe unknown mcast flooding should be controlled by a flag
> >when a querier is present
> >because we've had this behaviour for a long time, personally I'd have
> >it on
> >by default.
>
> Ugh, mispoke please read the above statement to be only about no querier.
> I meant flooding v6 link-local always.
And for routable IPv6 multicast, how would you detect multicast
listeners on the local link in absence of a querier?
WARNING: multiple messages have this Message-ID (diff)
From: "Linus Lüssing" <linus.luessing@c0d3.blue>
To: nikolay@cumulusnetworks.com
Cc: Ido Schimmel <idosch@idosch.org>,
netdev@vger.kernel.org, roopa@cumulusnetworks.com,
wkok@cumulusnetworks.com, anuradhak@cumulusnetworks.com,
bridge@lists.linux-foundation.org, davem@davemloft.net,
stephen@networkplumber.org
Subject: Re: [PATCH RFC] net: bridge: don't flood known multicast traffic when snooping is enabled
Date: Sat, 16 Feb 2019 21:37:19 +0100 [thread overview]
Message-ID: <20190216203719.GC25057@otheros> (raw)
In-Reply-To: <E8A29F94-091F-44CA-9E33-481BF21C359D@cumulusnetworks.com>
On Sat, Feb 16, 2019 at 09:27:26PM +0200, nikolay@cumulusnetworks.com wrote:
> >>The no querier condition is not currently reflected via switchdev, so
> >>the behavior you're proposing in your patch is what actually happens
> >in
> >>the data plane.
> >>
> >>We already hit the problem Linus mentioned in commit b00589af3b04
> >>("bridge: disable snooping if there is no querier"). Namely, IPv6 ND
> >>broke because a port joined before the bridge was created.
> >>
> >>I introduced a workaround in commit 9d45deb04c59 ("mlxsw: spectrum:
> >>Treat IPv6 unregistered multicast as broadcast"). I'm interested to
> >>know
> >>what other vendors are doing. Can you elaborate?
> >>
> >
> >Exactly like your fix. :) Flood it, this patch unfortunately breaks it
> >because of mrouters flag, but we can retain the behaviour
> >by forwarding only known mdsts to their ports and flooding
> >unregistered mcast when there is no querier. I think that is
> >what others do by default too, actually I think they flood with querier
> >as well. Maybe unknown mcast flooding should be controlled by a flag
> >when a querier is present
> >because we've had this behaviour for a long time, personally I'd have
> >it on
> >by default.
>
> Ugh, mispoke please read the above statement to be only about no querier.
> I meant flooding v6 link-local always.
And for routable IPv6 multicast, how would you detect multicast
listeners on the local link in absence of a querier?
next prev parent reply other threads:[~2019-02-16 20:37 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-15 13:04 [Bridge] [PATCH RFC] net: bridge: don't flood known multicast traffic when snooping is enabled Nikolay Aleksandrov
2019-02-15 13:04 ` Nikolay Aleksandrov
2019-02-15 13:09 ` [Bridge] " Nikolay Aleksandrov
2019-02-15 13:09 ` Nikolay Aleksandrov
2019-02-15 13:53 ` [Bridge] " Ido Schimmel
2019-02-15 13:53 ` Ido Schimmel
2019-02-15 17:13 ` [Bridge] " Linus Lüssing
2019-02-15 17:13 ` Linus Lüssing
2019-02-16 8:05 ` [Bridge] " Nikolay Aleksandrov
2019-02-16 8:05 ` Nikolay Aleksandrov
2019-02-16 8:35 ` [Bridge] " Nikolay Aleksandrov
2019-02-16 8:35 ` Nikolay Aleksandrov
2019-02-16 20:04 ` [Bridge] " Linus Lüssing
2019-02-16 20:04 ` Linus Lüssing
2019-02-16 18:43 ` [Bridge] " Ido Schimmel
2019-02-16 18:43 ` Ido Schimmel
2019-02-16 19:15 ` [Bridge] " nikolay
2019-02-16 19:15 ` nikolay
2019-02-16 19:27 ` [Bridge] " nikolay
2019-02-16 19:27 ` nikolay
2019-02-16 20:37 ` Linus Lüssing [this message]
2019-02-16 20:37 ` Linus Lüssing
2019-02-17 3:05 ` [Bridge] " Florian Fainelli
2019-02-17 3:05 ` Florian Fainelli
2019-02-17 10:58 ` [Bridge] " Nikolay Aleksandrov
2019-02-17 10:58 ` Nikolay Aleksandrov
2019-02-18 2:15 ` [Bridge] [LKP] [net] 5c261115ce: hwsim.ap_vlan_without_station.fail kernel test robot
2019-02-18 2:15 ` kernel test robot
2019-02-18 12:21 ` [Bridge] [RFC v2] net: bridge: don't flood known multicast traffic when snooping is enabled Nikolay Aleksandrov
2019-02-18 12:21 ` Nikolay Aleksandrov
2019-02-19 8:53 ` [Bridge] " Ido Schimmel
2019-02-19 8:53 ` Ido Schimmel
2019-02-19 8:57 ` [Bridge] " Linus Lüssing
2019-02-19 8:57 ` Linus Lüssing
2019-02-19 9:21 ` [Bridge] " Linus Lüssing
2019-02-19 9:21 ` Linus Lüssing
2019-02-19 13:31 ` Nikolay Aleksandrov
2019-02-19 13:31 ` Nikolay Aleksandrov
2019-02-19 15:42 ` Linus Lüssing
2019-02-19 15:42 ` Linus Lüssing
2019-02-19 17:26 ` Nikolay Aleksandrov
2019-02-19 17:26 ` Nikolay Aleksandrov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190216203719.GC25057@otheros \
--to=linus.luessing@c0d3.blue \
--cc=anuradhak@cumulusnetworks.com \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=idosch@idosch.org \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=roopa@cumulusnetworks.com \
--cc=wkok@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.