All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Chen <david0813@gmail.com>
To: linux-usb@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: davem@davemloft.net, hayeswang@realtek.com,
	mario.limonciello@dell.com, bigeasy@linutronix.de,
	edumazet@google.com, jslaby@suse.cz, f.fainelli@gmail.com,
	david.chen7@dell.com, kai.heng.feng@canonical.com,
	zhongjiang@huawei.com
Subject: [2/2] RTL8153-BD is used in Dell DA300 type-C dongle. It should be added to the whitelist of devices to activate MAC address pass through.
Date: Mon, 18 Feb 2019 11:48:17 +0800	[thread overview]
Message-ID: <20190218034817.7515-1-david0813@gmail.com> (raw)

From: David Chen <david.chen7@dell.com>

Per confirming with Realtek all devices containing RTL8153-BD should
activate MAC pass through and there won't use pass through bit on efuse
like in RTL8153-AD.

Signed-off-by: David Chen <david.chen7@dell.com>
---
 drivers/net/usb/r8152.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
index ada6baf8847a..86c8c64fbb0f 100644
--- a/drivers/net/usb/r8152.c
+++ b/drivers/net/usb/r8152.c
@@ -1179,7 +1179,7 @@ static int vendor_mac_passthru_addr_read(struct r8152 *tp, struct sockaddr *sa)
 	} else {
 		/* test for RTL8153-BND and RTL8153-BD */
 		ocp_data = ocp_read_byte(tp, MCU_TYPE_USB, USB_MISC_1);
-		if ((ocp_data & BND_MASK) == 0 && (ocp_data & BD_MASK)) {
+		if ((ocp_data & BND_MASK) == 0 && (ocp_data & BD_MASK) == 0) {
 			netif_dbg(tp, probe, tp->netdev,
 				  "Invalid variant for MAC pass through\n");
 			return -ENODEV;

WARNING: multiple messages have this Message-ID (diff)
From: David Chen <david0813@gmail.com>
To: linux-usb@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: davem@davemloft.net, hayeswang@realtek.com,
	mario.limonciello@dell.com, bigeasy@linutronix.de,
	edumazet@google.com, jslaby@suse.cz, f.fainelli@gmail.com,
	david.chen7@dell.com, kai.heng.feng@canonical.com,
	zhongjiang@huawei.com
Subject: [PATCH 2/2] RTL8153-BD is used in Dell DA300 type-C dongle. It should be added to the whitelist of devices to activate MAC address pass through.
Date: Mon, 18 Feb 2019 11:48:17 +0800	[thread overview]
Message-ID: <20190218034817.7515-1-david0813@gmail.com> (raw)

From: David Chen <david.chen7@dell.com>

Per confirming with Realtek all devices containing RTL8153-BD should
activate MAC pass through and there won't use pass through bit on efuse
like in RTL8153-AD.

Signed-off-by: David Chen <david.chen7@dell.com>
---
 drivers/net/usb/r8152.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
index ada6baf8847a..86c8c64fbb0f 100644
--- a/drivers/net/usb/r8152.c
+++ b/drivers/net/usb/r8152.c
@@ -1179,7 +1179,7 @@ static int vendor_mac_passthru_addr_read(struct r8152 *tp, struct sockaddr *sa)
 	} else {
 		/* test for RTL8153-BND and RTL8153-BD */
 		ocp_data = ocp_read_byte(tp, MCU_TYPE_USB, USB_MISC_1);
-		if ((ocp_data & BND_MASK) == 0 && (ocp_data & BD_MASK)) {
+		if ((ocp_data & BND_MASK) == 0 && (ocp_data & BD_MASK) == 0) {
 			netif_dbg(tp, probe, tp->netdev,
 				  "Invalid variant for MAC pass through\n");
 			return -ENODEV;
-- 
2.19.1


             reply	other threads:[~2019-02-18  3:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-18  3:48 David Chen [this message]
2019-02-18  3:48 ` [PATCH 2/2] RTL8153-BD is used in Dell DA300 type-C dongle. It should be added to the whitelist of devices to activate MAC address pass through David Chen
  -- strict thread matches above, loose matches on Subject: below --
2019-02-18  8:04 [2/2] " Oliver Neukum
2019-02-18  8:04 ` [PATCH 2/2] " Oliver Neukum
2019-02-18  8:24 [2/2] " David Chen
2019-02-18  8:24 ` [PATCH 2/2] " David Chen
2019-02-18 20:03 [2/2] " David Miller
2019-02-18 20:03 ` [PATCH 2/2] " David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190218034817.7515-1-david0813@gmail.com \
    --to=david0813@gmail.com \
    --cc=bigeasy@linutronix.de \
    --cc=davem@davemloft.net \
    --cc=david.chen7@dell.com \
    --cc=edumazet@google.com \
    --cc=f.fainelli@gmail.com \
    --cc=hayeswang@realtek.com \
    --cc=jslaby@suse.cz \
    --cc=kai.heng.feng@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mario.limonciello@dell.com \
    --cc=netdev@vger.kernel.org \
    --cc=zhongjiang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.