* [PATCH net-next] cfg80211: pmsr: use eth_broadcast_addr() to assign broadcast address
@ 2019-02-16 9:47 ` Mao Wenan
0 siblings, 0 replies; 10+ messages in thread
From: Mao Wenan @ 2019-02-16 9:47 UTC (permalink / raw)
To: johannes, linux-wireless, kernel-janitors, netdev
This patch is to use eth_broadcast_addr() to assign broadcast address
insetad of memset().
Signed-off-by: Mao Wenan <maowenan@huawei.com>
---
net/wireless/pmsr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/wireless/pmsr.c b/net/wireless/pmsr.c
index de9286703280..21139b82749f 100644
--- a/net/wireless/pmsr.c
+++ b/net/wireless/pmsr.c
@@ -258,7 +258,7 @@ int nl80211_pmsr_start(struct sk_buff *skb, struct genl_info *info)
} else {
memcpy(req->mac_addr, nla_data(info->attrs[NL80211_ATTR_MAC]),
ETH_ALEN);
- memset(req->mac_addr_mask, 0xff, ETH_ALEN);
+ eth_broadcast_addr(req->mac_addr_mask);
}
idx = 0;
--
2.20.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH net-next] cfg80211: pmsr: use eth_broadcast_addr() to assign broadcast address
@ 2019-02-16 9:47 ` Mao Wenan
0 siblings, 0 replies; 10+ messages in thread
From: Mao Wenan @ 2019-02-16 9:47 UTC (permalink / raw)
To: johannes, linux-wireless, kernel-janitors, netdev
This patch is to use eth_broadcast_addr() to assign broadcast address
insetad of memset().
Signed-off-by: Mao Wenan <maowenan@huawei.com>
---
net/wireless/pmsr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/wireless/pmsr.c b/net/wireless/pmsr.c
index de9286703280..21139b82749f 100644
--- a/net/wireless/pmsr.c
+++ b/net/wireless/pmsr.c
@@ -258,7 +258,7 @@ int nl80211_pmsr_start(struct sk_buff *skb, struct genl_info *info)
} else {
memcpy(req->mac_addr, nla_data(info->attrs[NL80211_ATTR_MAC]),
ETH_ALEN);
- memset(req->mac_addr_mask, 0xff, ETH_ALEN);
+ eth_broadcast_addr(req->mac_addr_mask);
}
idx = 0;
--
2.20.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH net-next] cfg80211: pmsr: use eth_broadcast_addr() to assign broadcast address
2019-02-16 9:47 ` Mao Wenan
@ 2019-02-18 13:25 ` maowenan
-1 siblings, 0 replies; 10+ messages in thread
From: maowenan @ 2019-02-18 13:25 UTC (permalink / raw)
To: johannes, linux-wireless, kernel-janitors, netdev, kvalo
Add kalle Valo in mail list.
Hi Kalle Valo,
Do you have any comments about this patch?
On 2019/2/16 17:47, Mao Wenan wrote:
> This patch is to use eth_broadcast_addr() to assign broadcast address
> insetad of memset().
>
> Signed-off-by: Mao Wenan <maowenan@huawei.com>
> ---
> net/wireless/pmsr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/wireless/pmsr.c b/net/wireless/pmsr.c
> index de9286703280..21139b82749f 100644
> --- a/net/wireless/pmsr.c
> +++ b/net/wireless/pmsr.c
> @@ -258,7 +258,7 @@ int nl80211_pmsr_start(struct sk_buff *skb, struct genl_info *info)
> } else {
> memcpy(req->mac_addr, nla_data(info->attrs[NL80211_ATTR_MAC]),
> ETH_ALEN);
> - memset(req->mac_addr_mask, 0xff, ETH_ALEN);
> + eth_broadcast_addr(req->mac_addr_mask);
> }
>
> idx = 0;
>
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH net-next] cfg80211: pmsr: use eth_broadcast_addr() to assign broadcast address
@ 2019-02-18 13:25 ` maowenan
0 siblings, 0 replies; 10+ messages in thread
From: maowenan @ 2019-02-18 13:25 UTC (permalink / raw)
To: johannes, linux-wireless, kernel-janitors, netdev, kvalo
Add kalle Valo in mail list.
Hi Kalle Valo,
Do you have any comments about this patch?
On 2019/2/16 17:47, Mao Wenan wrote:
> This patch is to use eth_broadcast_addr() to assign broadcast address
> insetad of memset().
>
> Signed-off-by: Mao Wenan <maowenan@huawei.com>
> ---
> net/wireless/pmsr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/wireless/pmsr.c b/net/wireless/pmsr.c
> index de9286703280..21139b82749f 100644
> --- a/net/wireless/pmsr.c
> +++ b/net/wireless/pmsr.c
> @@ -258,7 +258,7 @@ int nl80211_pmsr_start(struct sk_buff *skb, struct genl_info *info)
> } else {
> memcpy(req->mac_addr, nla_data(info->attrs[NL80211_ATTR_MAC]),
> ETH_ALEN);
> - memset(req->mac_addr_mask, 0xff, ETH_ALEN);
> + eth_broadcast_addr(req->mac_addr_mask);
> }
>
> idx = 0;
>
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH net-next] cfg80211: pmsr: use eth_broadcast_addr() to assign broadcast address
2019-02-18 13:25 ` maowenan
@ 2019-02-18 13:48 ` Kalle Valo
-1 siblings, 0 replies; 10+ messages in thread
From: Kalle Valo @ 2019-02-18 13:48 UTC (permalink / raw)
To: maowenan; +Cc: johannes, linux-wireless, kernel-janitors, netdev
maowenan <maowenan@huawei.com> writes:
> Add kalle Valo in mail list.
>
> Hi Kalle Valo,
> Do you have any comments about this patch?
Why do you ask me? Johannes maintains cfg80211, not me, and he will
provide comments once he reviews the patch (which might take some time,
we do have other tasks as well).
--
Kalle Valo
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH net-next] cfg80211: pmsr: use eth_broadcast_addr() to assign broadcast address
@ 2019-02-18 13:48 ` Kalle Valo
0 siblings, 0 replies; 10+ messages in thread
From: Kalle Valo @ 2019-02-18 13:48 UTC (permalink / raw)
To: maowenan; +Cc: johannes, linux-wireless, kernel-janitors, netdev
maowenan <maowenan@huawei.com> writes:
> Add kalle Valo in mail list.
>
> Hi Kalle Valo,
> Do you have any comments about this patch?
Why do you ask me? Johannes maintains cfg80211, not me, and he will
provide comments once he reviews the patch (which might take some time,
we do have other tasks as well).
--
Kalle Valo
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH net-next] cfg80211: pmsr: use eth_broadcast_addr() to assign broadcast address
2019-02-18 13:48 ` Kalle Valo
@ 2019-02-18 14:04 ` maowenan
-1 siblings, 0 replies; 10+ messages in thread
From: maowenan @ 2019-02-18 14:04 UTC (permalink / raw)
To: Kalle Valo; +Cc: johannes, linux-wireless, kernel-janitors, netdev
On 2019/2/18 21:48, Kalle Valo wrote:
> maowenan <maowenan@huawei.com> writes:
>
>> Add kalle Valo in mail list.
>>
>> Hi Kalle Valo,
>> Do you have any comments about this patch?
>
> Why do you ask me? Johannes maintains cfg80211, not me, and he will
> provide comments once he reviews the patch (which might take some time,
> we do have other tasks as well).
I'm sorry for this, my mistake to add wrong maintainer.
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH net-next] cfg80211: pmsr: use eth_broadcast_addr() to assign broadcast address
@ 2019-02-18 14:04 ` maowenan
0 siblings, 0 replies; 10+ messages in thread
From: maowenan @ 2019-02-18 14:04 UTC (permalink / raw)
To: Kalle Valo; +Cc: johannes, linux-wireless, kernel-janitors, netdev
On 2019/2/18 21:48, Kalle Valo wrote:
> maowenan <maowenan@huawei.com> writes:
>
>> Add kalle Valo in mail list.
>>
>> Hi Kalle Valo,
>> Do you have any comments about this patch?
>
> Why do you ask me? Johannes maintains cfg80211, not me, and he will
> provide comments once he reviews the patch (which might take some time,
> we do have other tasks as well).
I'm sorry for this, my mistake to add wrong maintainer.
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH net-next] cfg80211: pmsr: use eth_broadcast_addr() to assign broadcast address
2019-02-18 13:25 ` maowenan
@ 2019-02-18 14:36 ` Dan Carpenter
-1 siblings, 0 replies; 10+ messages in thread
From: Dan Carpenter @ 2019-02-18 14:36 UTC (permalink / raw)
To: maowenan; +Cc: johannes, linux-wireless, kernel-janitors, netdev, kvalo
On Mon, Feb 18, 2019 at 09:25:06PM +0800, maowenan wrote:
> Add kalle Valo in mail list.
>
> Hi Kalle Valo,
> Do you have any comments about this patch?
>
It's not done against a recent net-next so it doesn't apply.
Please give people a few days to reply for networking changes.
regards,
dan caprenter
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH net-next] cfg80211: pmsr: use eth_broadcast_addr() to assign broadcast address
@ 2019-02-18 14:36 ` Dan Carpenter
0 siblings, 0 replies; 10+ messages in thread
From: Dan Carpenter @ 2019-02-18 14:36 UTC (permalink / raw)
To: maowenan; +Cc: johannes, linux-wireless, kernel-janitors, netdev, kvalo
On Mon, Feb 18, 2019 at 09:25:06PM +0800, maowenan wrote:
> Add kalle Valo in mail list.
>
> Hi Kalle Valo,
> Do you have any comments about this patch?
>
It's not done against a recent net-next so it doesn't apply.
Please give people a few days to reply for networking changes.
regards,
dan caprenter
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2019-02-18 14:37 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-16 9:47 [PATCH net-next] cfg80211: pmsr: use eth_broadcast_addr() to assign broadcast address Mao Wenan
2019-02-16 9:47 ` Mao Wenan
2019-02-18 13:25 ` maowenan
2019-02-18 13:25 ` maowenan
2019-02-18 13:48 ` Kalle Valo
2019-02-18 13:48 ` Kalle Valo
2019-02-18 14:04 ` maowenan
2019-02-18 14:04 ` maowenan
2019-02-18 14:36 ` Dan Carpenter
2019-02-18 14:36 ` Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.