From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Wei Yongjun <weiyongjun1@huawei.com>,
Enric Balletbo Serra <eballetbo@gmail.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
Nick Crews <ncrews@chromium.org>,
linux-rtc@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next] rtc: wilco_ec: Make some functions static
Date: Mon, 18 Feb 2019 14:48:27 +0000 [thread overview]
Message-ID: <20190218144827.GU10129@piout.net> (raw)
In-Reply-To: <20190216013603.117969-1-weiyongjun1@huawei.com>
Enric,
You should take that one or squash it with the original commit.
On 16/02/2019 01:36:03+0000, Wei Yongjun wrote:
> Fixes the following sparse warnings:
>
> drivers/rtc/rtc-wilco-ec.c:72:5: warning:
> symbol 'wilco_ec_rtc_read' was not declared. Should it be static?
> drivers/rtc/rtc-wilco-ec.c:106:5: warning:
> symbol 'wilco_ec_rtc_write' was not declared. Should it be static?
>
> Fixes: 79c4ec4869b5 ("platform/chrome: wilco_ec: Add RTC driver")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/rtc/rtc-wilco-ec.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/rtc/rtc-wilco-ec.c b/drivers/rtc/rtc-wilco-ec.c
> index 35cc56114c1c..e62bda0cb53e 100644
> --- a/drivers/rtc/rtc-wilco-ec.c
> +++ b/drivers/rtc/rtc-wilco-ec.c
> @@ -69,7 +69,7 @@ struct ec_rtc_write {
> u8 weekday;
> } __packed;
>
> -int wilco_ec_rtc_read(struct device *dev, struct rtc_time *tm)
> +static int wilco_ec_rtc_read(struct device *dev, struct rtc_time *tm)
> {
> struct wilco_ec_device *ec = dev_get_drvdata(dev->parent);
> u8 param = EC_CMOS_TOD_READ;
> @@ -103,7 +103,7 @@ int wilco_ec_rtc_read(struct device *dev, struct rtc_time *tm)
> return 0;
> }
>
> -int wilco_ec_rtc_write(struct device *dev, struct rtc_time *tm)
> +static int wilco_ec_rtc_write(struct device *dev, struct rtc_time *tm)
> {
> struct wilco_ec_device *ec = dev_get_drvdata(dev->parent);
> struct ec_rtc_write rtc;
>
>
>
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Wei Yongjun <weiyongjun1@huawei.com>,
Enric Balletbo Serra <eballetbo@gmail.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
Nick Crews <ncrews@chromium.org>,
linux-rtc@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next] rtc: wilco_ec: Make some functions static
Date: Mon, 18 Feb 2019 15:48:27 +0100 [thread overview]
Message-ID: <20190218144827.GU10129@piout.net> (raw)
In-Reply-To: <20190216013603.117969-1-weiyongjun1@huawei.com>
Enric,
You should take that one or squash it with the original commit.
On 16/02/2019 01:36:03+0000, Wei Yongjun wrote:
> Fixes the following sparse warnings:
>
> drivers/rtc/rtc-wilco-ec.c:72:5: warning:
> symbol 'wilco_ec_rtc_read' was not declared. Should it be static?
> drivers/rtc/rtc-wilco-ec.c:106:5: warning:
> symbol 'wilco_ec_rtc_write' was not declared. Should it be static?
>
> Fixes: 79c4ec4869b5 ("platform/chrome: wilco_ec: Add RTC driver")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/rtc/rtc-wilco-ec.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/rtc/rtc-wilco-ec.c b/drivers/rtc/rtc-wilco-ec.c
> index 35cc56114c1c..e62bda0cb53e 100644
> --- a/drivers/rtc/rtc-wilco-ec.c
> +++ b/drivers/rtc/rtc-wilco-ec.c
> @@ -69,7 +69,7 @@ struct ec_rtc_write {
> u8 weekday;
> } __packed;
>
> -int wilco_ec_rtc_read(struct device *dev, struct rtc_time *tm)
> +static int wilco_ec_rtc_read(struct device *dev, struct rtc_time *tm)
> {
> struct wilco_ec_device *ec = dev_get_drvdata(dev->parent);
> u8 param = EC_CMOS_TOD_READ;
> @@ -103,7 +103,7 @@ int wilco_ec_rtc_read(struct device *dev, struct rtc_time *tm)
> return 0;
> }
>
> -int wilco_ec_rtc_write(struct device *dev, struct rtc_time *tm)
> +static int wilco_ec_rtc_write(struct device *dev, struct rtc_time *tm)
> {
> struct wilco_ec_device *ec = dev_get_drvdata(dev->parent);
> struct ec_rtc_write rtc;
>
>
>
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-02-18 14:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-16 1:36 [PATCH -next] rtc: wilco_ec: Make some functions static Wei Yongjun
2019-02-16 1:36 ` Wei Yongjun
2019-02-18 14:48 ` Alexandre Belloni [this message]
2019-02-18 14:48 ` Alexandre Belloni
2019-02-18 15:57 ` Enric Balletbo Serra
2019-02-18 15:57 ` Enric Balletbo Serra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190218144827.GU10129@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=eballetbo@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=ncrews@chromium.org \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.