All of lore.kernel.org
 help / color / mirror / Atom feed
* [Outreachy Kernel][PATCH v2] staging: erofs: match alignment with open parentheses
@ 2019-02-19  9:25 Bhanusree Pola
  2019-02-19  9:27 ` [Outreachy kernel] " Julia Lawall
  2019-02-19 10:24   ` Gao Xiang
  0 siblings, 2 replies; 7+ messages in thread
From: Bhanusree Pola @ 2019-02-19  9:25 UTC (permalink / raw)
  To: outreachy-kernel; +Cc: Gao Xiang, Chao Yu, Greg Kroah-Hartman

Align code with open parantheses to improve the readability.
Issue found using checkpatch.pl

Signed-off-by: Bhanusree Pola <bhanusreemahesh@gmail.com>
---

v2: -modified log message
    -corrected spelling in subject line

drivers/staging/erofs/dir.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/erofs/dir.c b/drivers/staging/erofs/dir.c
index 833f052f79d0..e1955703ab8f 100644
--- a/drivers/staging/erofs/dir.c
+++ b/drivers/staging/erofs/dir.c
@@ -24,8 +24,8 @@ static const unsigned char erofs_filetype_table[EROFS_FT_MAX] = {
 };
 
 static int erofs_fill_dentries(struct dir_context *ctx,
-	void *dentry_blk, unsigned int *ofs,
-	unsigned int nameoff, unsigned int maxsize)
+			       void *dentry_blk, unsigned int *ofs,
+			       unsigned int nameoff, unsigned int maxsize)
 {
 	struct erofs_dirent *de = dentry_blk;
 	const struct erofs_dirent *end = dentry_blk + nameoff;
@@ -104,9 +104,9 @@ static int erofs_readdir(struct file *f, struct dir_context *ctx)
 		nameoff = le16_to_cpu(de->nameoff);
 
 		if (unlikely(nameoff < sizeof(struct erofs_dirent) ||
-			nameoff >= PAGE_SIZE)) {
+			     nameoff >= PAGE_SIZE)) {
 			errln("%s, invalid de[0].nameoff %u",
-				__func__, nameoff);
+			      __func__, nameoff);
 
 			err = -EIO;
 			goto skip_this;
-- 
2.17.1



^ permalink raw reply related	[flat|nested] 7+ messages in thread
* Re: [Outreachy kernel] [Outreachy Kernel][PATCH v2] staging: erofs: match alignment with open parentheses
  2019-02-19  9:25 [Outreachy Kernel][PATCH v2] staging: erofs: match alignment with open parentheses Bhanusree Pola
@ 2019-02-19  9:27 ` Julia Lawall
  2019-02-19 10:16   ` Greg Kroah-Hartman
  2019-02-19 10:24   ` Gao Xiang
  1 sibling, 1 reply; 7+ messages in thread
From: Julia Lawall @ 2019-02-19  9:27 UTC (permalink / raw)
  To: Bhanusree Pola; +Cc: outreachy-kernel, Gao Xiang, Chao Yu, Greg Kroah-Hartman



On Tue, 19 Feb 2019, Bhanusree Pola wrote:

> Align code with open parantheses to improve the readability.
> Issue found using checkpatch.pl

The subject line and loge message look better now, but I wonder why you
still have [Outreachy kernel] twice?

julia

>
> Signed-off-by: Bhanusree Pola <bhanusreemahesh@gmail.com>
> ---
>
> v2: -modified log message
>     -corrected spelling in subject line
>
> drivers/staging/erofs/dir.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/erofs/dir.c b/drivers/staging/erofs/dir.c
> index 833f052f79d0..e1955703ab8f 100644
> --- a/drivers/staging/erofs/dir.c
> +++ b/drivers/staging/erofs/dir.c
> @@ -24,8 +24,8 @@ static const unsigned char erofs_filetype_table[EROFS_FT_MAX] = {
>  };
>
>  static int erofs_fill_dentries(struct dir_context *ctx,
> -	void *dentry_blk, unsigned int *ofs,
> -	unsigned int nameoff, unsigned int maxsize)
> +			       void *dentry_blk, unsigned int *ofs,
> +			       unsigned int nameoff, unsigned int maxsize)
>  {
>  	struct erofs_dirent *de = dentry_blk;
>  	const struct erofs_dirent *end = dentry_blk + nameoff;
> @@ -104,9 +104,9 @@ static int erofs_readdir(struct file *f, struct dir_context *ctx)
>  		nameoff = le16_to_cpu(de->nameoff);
>
>  		if (unlikely(nameoff < sizeof(struct erofs_dirent) ||
> -			nameoff >= PAGE_SIZE)) {
> +			     nameoff >= PAGE_SIZE)) {
>  			errln("%s, invalid de[0].nameoff %u",
> -				__func__, nameoff);
> +			      __func__, nameoff);
>
>  			err = -EIO;
>  			goto skip_this;
> --
> 2.17.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190219092525.GA4474%40bhanusree-MacBookAir.
> For more options, visit https://groups.google.com/d/optout.
>


^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [Outreachy kernel] [Outreachy Kernel][PATCH v2] staging: erofs: match alignment with open parentheses
  2019-02-19  9:27 ` [Outreachy kernel] " Julia Lawall
@ 2019-02-19 10:16   ` Greg Kroah-Hartman
  0 siblings, 0 replies; 7+ messages in thread
From: Greg Kroah-Hartman @ 2019-02-19 10:16 UTC (permalink / raw)
  To: Julia Lawall; +Cc: Bhanusree Pola, outreachy-kernel, Gao Xiang, Chao Yu

On Tue, Feb 19, 2019 at 10:27:47AM +0100, Julia Lawall wrote:
> 
> 
> On Tue, 19 Feb 2019, Bhanusree Pola wrote:
> 
> > Align code with open parantheses to improve the readability.
> > Issue found using checkpatch.pl
> 
> The subject line and loge message look better now, but I wonder why you
> still have [Outreachy kernel] twice?

It looks like it was added by both the poster, and the mailing list :(

The one I got only had one copy, so I can take it as-is.

thanks,

greg k-h


^ permalink raw reply	[flat|nested] 7+ messages in thread
* [Outreachy Kernel][PATCH v2] staging: erofs: match alignment with open parentheses
  2019-02-19  9:25 [Outreachy Kernel][PATCH v2] staging: erofs: match alignment with open parentheses Bhanusree Pola
@ 2019-02-19 10:24   ` Gao Xiang
  2019-02-19 10:24   ` Gao Xiang
  1 sibling, 0 replies; 7+ messages in thread
From: Gao Xiang @ 2019-02-19 10:24 UTC (permalink / raw)


[+cc linux-erofs and staging mailing list]

On 2019/2/19 17:25, Bhanusree Pola wrote:
> Align code with open parantheses to improve the readability.
> Issue found using checkpatch.pl
> 
> Signed-off-by: Bhanusree Pola <bhanusreemahesh at gmail.com>

Reviewed-by: Gao Xiang <gaoxiang25 at huawei.com>

Thanks,
Gao Xiang

> ---
> 
> v2: -modified log message
>     -corrected spelling in subject line
> 
> drivers/staging/erofs/dir.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/erofs/dir.c b/drivers/staging/erofs/dir.c
> index 833f052f79d0..e1955703ab8f 100644
> --- a/drivers/staging/erofs/dir.c
> +++ b/drivers/staging/erofs/dir.c
> @@ -24,8 +24,8 @@ static const unsigned char erofs_filetype_table[EROFS_FT_MAX] = {
>  };
>  
>  static int erofs_fill_dentries(struct dir_context *ctx,
> -	void *dentry_blk, unsigned int *ofs,
> -	unsigned int nameoff, unsigned int maxsize)
> +			       void *dentry_blk, unsigned int *ofs,
> +			       unsigned int nameoff, unsigned int maxsize)
>  {
>  	struct erofs_dirent *de = dentry_blk;
>  	const struct erofs_dirent *end = dentry_blk + nameoff;
> @@ -104,9 +104,9 @@ static int erofs_readdir(struct file *f, struct dir_context *ctx)
>  		nameoff = le16_to_cpu(de->nameoff);
>  
>  		if (unlikely(nameoff < sizeof(struct erofs_dirent) ||
> -			nameoff >= PAGE_SIZE)) {
> +			     nameoff >= PAGE_SIZE)) {
>  			errln("%s, invalid de[0].nameoff %u",
> -				__func__, nameoff);
> +			      __func__, nameoff);
>  
>  			err = -EIO;
>  			goto skip_this;
> 

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [Outreachy Kernel][PATCH v2] staging: erofs: match alignment with open parentheses
@ 2019-02-19 10:24   ` Gao Xiang
  0 siblings, 0 replies; 7+ messages in thread
From: Gao Xiang @ 2019-02-19 10:24 UTC (permalink / raw)
  To: Bhanusree Pola
  Cc: outreachy-kernel, Chao Yu, Greg Kroah-Hartman,
	linux-staging mailing list, linux-erofs@lists.ozlabs.org

[+cc linux-erofs and staging mailing list]

On 2019/2/19 17:25, Bhanusree Pola wrote:
> Align code with open parantheses to improve the readability.
> Issue found using checkpatch.pl
> 
> Signed-off-by: Bhanusree Pola <bhanusreemahesh@gmail.com>

Reviewed-by: Gao Xiang <gaoxiang25@huawei.com>

Thanks,
Gao Xiang

> ---
> 
> v2: -modified log message
>     -corrected spelling in subject line
> 
> drivers/staging/erofs/dir.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/erofs/dir.c b/drivers/staging/erofs/dir.c
> index 833f052f79d0..e1955703ab8f 100644
> --- a/drivers/staging/erofs/dir.c
> +++ b/drivers/staging/erofs/dir.c
> @@ -24,8 +24,8 @@ static const unsigned char erofs_filetype_table[EROFS_FT_MAX] = {
>  };
>  
>  static int erofs_fill_dentries(struct dir_context *ctx,
> -	void *dentry_blk, unsigned int *ofs,
> -	unsigned int nameoff, unsigned int maxsize)
> +			       void *dentry_blk, unsigned int *ofs,
> +			       unsigned int nameoff, unsigned int maxsize)
>  {
>  	struct erofs_dirent *de = dentry_blk;
>  	const struct erofs_dirent *end = dentry_blk + nameoff;
> @@ -104,9 +104,9 @@ static int erofs_readdir(struct file *f, struct dir_context *ctx)
>  		nameoff = le16_to_cpu(de->nameoff);
>  
>  		if (unlikely(nameoff < sizeof(struct erofs_dirent) ||
> -			nameoff >= PAGE_SIZE)) {
> +			     nameoff >= PAGE_SIZE)) {
>  			errln("%s, invalid de[0].nameoff %u",
> -				__func__, nameoff);
> +			      __func__, nameoff);
>  
>  			err = -EIO;
>  			goto skip_this;
> 


^ permalink raw reply	[flat|nested] 7+ messages in thread
* [Outreachy Kernel][PATCH v2] staging: erofs: match alignment with open parentheses
  2019-02-19 10:24   ` Gao Xiang
@ 2019-02-19 10:28     ` Chao Yu
  -1 siblings, 0 replies; 7+ messages in thread
From: Chao Yu @ 2019-02-19 10:28 UTC (permalink / raw)


On 2019/2/19 18:24, Gao Xiang wrote:
> [+cc linux-erofs and staging mailing list]
> 
> On 2019/2/19 17:25, Bhanusree Pola wrote:
>> Align code with open parantheses to improve the readability.
>> Issue found using checkpatch.pl
>>
>> Signed-off-by: Bhanusree Pola <bhanusreemahesh at gmail.com>

Reviewed-by: Chao Yu <yuchao0 at huawei.com>

Thanks,

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [Outreachy Kernel][PATCH v2] staging: erofs: match alignment with open parentheses
@ 2019-02-19 10:28     ` Chao Yu
  0 siblings, 0 replies; 7+ messages in thread
From: Chao Yu @ 2019-02-19 10:28 UTC (permalink / raw)
  To: Gao Xiang, Bhanusree Pola
  Cc: outreachy-kernel, Greg Kroah-Hartman, linux-staging mailing list,
	linux-erofs@lists.ozlabs.org

On 2019/2/19 18:24, Gao Xiang wrote:
> [+cc linux-erofs and staging mailing list]
> 
> On 2019/2/19 17:25, Bhanusree Pola wrote:
>> Align code with open parantheses to improve the readability.
>> Issue found using checkpatch.pl
>>
>> Signed-off-by: Bhanusree Pola <bhanusreemahesh@gmail.com>

Reviewed-by: Chao Yu <yuchao0@huawei.com>

Thanks,



^ permalink raw reply	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-02-19 11:20 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-19  9:25 [Outreachy Kernel][PATCH v2] staging: erofs: match alignment with open parentheses Bhanusree Pola
2019-02-19  9:27 ` [Outreachy kernel] " Julia Lawall
2019-02-19 10:16   ` Greg Kroah-Hartman
2019-02-19 10:24 ` Gao Xiang
2019-02-19 10:24   ` Gao Xiang
2019-02-19 10:28   ` Chao Yu
2019-02-19 10:28     ` Chao Yu

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.