All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org, david@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2] audio: don't build alsa and sdl by default on linux
Date: Tue, 19 Feb 2019 13:01:54 +0000	[thread overview]
Message-ID: <20190219130154.GI7154@redhat.com> (raw)
In-Reply-To: <20190219124257.3001-1-kraxel@redhat.com>

On Tue, Feb 19, 2019 at 01:42:57PM +0100, Gerd Hoffmann wrote:
> In case no sound hardware is present both alsa and sdl drivers
> initialize successfully and throw errors later on, i.e. effectively
> the automatic probing doesn't work.  Drop them from the list of
> default audio drivers for linux because of that.
> 
> Fixes: 6a48541873 audio: probe audio drivers by default
> Buglink: https://bugs.launchpad.net/qemu/+bug/1816052
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index fbd0825488..651b4f7514 100755
> --- a/configure
> +++ b/configure
> @@ -877,7 +877,7 @@ Haiku)
>    LIBS="-lposix_error_mapper -lnetwork $LIBS"
>  ;;
>  Linux)
> -  audio_drv_list="try-pa try-alsa try-sdl oss"
> +  audio_drv_list="try-pa oss"
>    audio_possible_drivers="oss alsa sdl pa"
>    linux="yes"
>    linux_user="yes"

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

  reply	other threads:[~2019-02-19 13:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-19 12:42 [Qemu-devel] [PATCH v2] audio: don't build alsa and sdl by default on linux Gerd Hoffmann
2019-02-19 13:01 ` Daniel P. Berrangé [this message]
2019-02-19 13:06 ` David Hildenbrand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190219130154.GI7154@redhat.com \
    --to=berrange@redhat.com \
    --cc=david@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.