[Qemu-devel] [PATCH v2] audio: don't build alsa and sdl by default on linux

[Qemu-devel] [PATCH v2] audio: don't build alsa and sdl by default on linux

[Gerd Hoffmann]

In case no sound hardware is present both alsa and sdl drivers
initialize successfully and throw errors later on, i.e. effectively
the automatic probing doesn't work.  Drop them from the list of
default audio drivers for linux because of that.

Fixes: 6a48541873 audio: probe audio drivers by default
Buglink: https://bugs.launchpad.net/qemu/+bug/1816052
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure b/configure
index fbd0825488..651b4f7514 100755
--- a/configure
+++ b/configure
@@ -877,7 +877,7 @@ Haiku)
   LIBS="-lposix_error_mapper -lnetwork $LIBS"
 ;;
 Linux)
-  audio_drv_list="try-pa try-alsa try-sdl oss"
+  audio_drv_list="try-pa oss"
   audio_possible_drivers="oss alsa sdl pa"
   linux="yes"
   linux_user="yes"
-- 
2.9.3

Re: [Qemu-devel] [PATCH v2] audio: don't build alsa and sdl by default on linux

[Daniel P. Berrangé]

On Tue, Feb 19, 2019 at 01:42:57PM +0100, Gerd Hoffmann wrote:
> In case no sound hardware is present both alsa and sdl drivers
> initialize successfully and throw errors later on, i.e. effectively
> the automatic probing doesn't work.  Drop them from the list of
> default audio drivers for linux because of that.
> 
> Fixes: 6a48541873 audio: probe audio drivers by default
> Buglink: https://bugs.launchpad.net/qemu/+bug/1816052
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index fbd0825488..651b4f7514 100755
> --- a/configure
> +++ b/configure
> @@ -877,7 +877,7 @@ Haiku)
>    LIBS="-lposix_error_mapper -lnetwork $LIBS"
>  ;;
>  Linux)
> -  audio_drv_list="try-pa try-alsa try-sdl oss"
> +  audio_drv_list="try-pa oss"
>    audio_possible_drivers="oss alsa sdl pa"
>    linux="yes"
>    linux_user="yes"

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Re: [Qemu-devel] [PATCH v2] audio: don't build alsa and sdl by default on linux

[David Hildenbrand]

On 19.02.19 13:42, Gerd Hoffmann wrote:
> In case no sound hardware is present both alsa and sdl drivers
> initialize successfully and throw errors later on, i.e. effectively
> the automatic probing doesn't work.  Drop them from the list of
> default audio drivers for linux because of that.
> 
> Fixes: 6a48541873 audio: probe audio drivers by default
> Buglink: https://bugs.launchpad.net/qemu/+bug/1816052
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index fbd0825488..651b4f7514 100755
> --- a/configure
> +++ b/configure
> @@ -877,7 +877,7 @@ Haiku)
>    LIBS="-lposix_error_mapper -lnetwork $LIBS"
>  ;;
>  Linux)
> -  audio_drv_list="try-pa try-alsa try-sdl oss"
> +  audio_drv_list="try-pa oss"
>    audio_possible_drivers="oss alsa sdl pa"
>    linux="yes"
>    linux_user="yes"
> 

It makes it work under my crazy environment again.

Tested-by: David Hildenbrand <david@redhat.com>

-- 

Thanks,

David / dhildenb