From: Segher Boessenkool <segher@kernel.crashing.org>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: erhard_f@mailbox.org, jack@suse.cz, linuxppc-dev@ozlabs.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
aneesh.kumar@linux.vnet.ibm.com
Subject: Re: [PATCH] powerpc/64s: Fix possible corruption on big endian due to pgd/pud_present()
Date: Tue, 19 Feb 2019 14:15:41 -0600 [thread overview]
Message-ID: <20190219201539.GT14180@gate.crashing.org> (raw)
In-Reply-To: <87imxhrkdt.fsf@concordia.ellerman.id.au>
On Mon, Feb 18, 2019 at 11:49:18AM +1100, Michael Ellerman wrote:
> Balbir Singh <bsingharora@gmail.com> writes:
> > Fair enough, my point was that the compiler can help out. I'll see what
> > -Wconversion finds on my local build :)
>
> I get about 43MB of warnings here :)
Yes, -Wconversion complains about a lot of things that are idiomatic C.
There is a reason -Wconversion is not in -Wall or -Wextra.
Segher
WARNING: multiple messages have this Message-ID (diff)
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: Balbir Singh <bsingharora@gmail.com>,
erhard_f@mailbox.org, jack@suse.cz, linuxppc-dev@ozlabs.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
aneesh.kumar@linux.vnet.ibm.com
Subject: Re: [PATCH] powerpc/64s: Fix possible corruption on big endian due to pgd/pud_present()
Date: Tue, 19 Feb 2019 14:15:41 -0600 [thread overview]
Message-ID: <20190219201539.GT14180@gate.crashing.org> (raw)
In-Reply-To: <87imxhrkdt.fsf@concordia.ellerman.id.au>
On Mon, Feb 18, 2019 at 11:49:18AM +1100, Michael Ellerman wrote:
> Balbir Singh <bsingharora@gmail.com> writes:
> > Fair enough, my point was that the compiler can help out. I'll see what
> > -Wconversion finds on my local build :)
>
> I get about 43MB of warnings here :)
Yes, -Wconversion complains about a lot of things that are idiomatic C.
There is a reason -Wconversion is not in -Wall or -Wextra.
Segher
next prev parent reply other threads:[~2019-02-19 20:18 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-14 6:23 [PATCH] powerpc/64s: Fix possible corruption on big endian due to pgd/pud_present() Michael Ellerman
2019-02-14 6:23 ` Michael Ellerman
2019-02-14 16:31 ` Jan Kara
2019-02-14 16:31 ` Jan Kara
2019-02-16 10:55 ` Balbir Singh
2019-02-16 10:55 ` Balbir Singh
2019-02-16 14:22 ` Segher Boessenkool
2019-02-16 14:22 ` Segher Boessenkool
2019-02-17 6:23 ` Balbir Singh
2019-02-17 6:23 ` Balbir Singh
2019-02-17 8:34 ` Michael Ellerman
2019-02-17 21:55 ` Balbir Singh
2019-02-17 21:55 ` Balbir Singh
2019-02-18 0:49 ` Michael Ellerman
2019-02-18 0:49 ` Michael Ellerman
2019-02-19 12:01 ` Balbir Singh
2019-02-19 12:01 ` Balbir Singh
2019-02-19 20:15 ` Segher Boessenkool [this message]
2019-02-19 20:15 ` Segher Boessenkool
2019-02-20 11:18 ` Michael Ellerman
2019-02-20 11:18 ` Michael Ellerman
2019-02-20 14:51 ` Segher Boessenkool
2019-02-20 14:51 ` Segher Boessenkool
2019-02-17 8:34 ` Michael Ellerman
2019-02-16 13:15 ` Andreas Schwab
2019-02-16 13:15 ` Andreas Schwab
2019-02-17 8:26 ` Michael Ellerman
2019-02-17 8:26 ` Michael Ellerman
2019-02-17 8:21 ` Michael Ellerman
2019-02-17 8:21 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190219201539.GT14180@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=erhard_f@mailbox.org \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.