All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Bhanusree Pola <bhanusreemahesh@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [PATCH 1/2] Staging: rtl8192e: Replace license text with SPDX identifier
Date: Wed, 20 Feb 2019 11:23:16 +0100	[thread overview]
Message-ID: <20190220102316.GA5535@kroah.com> (raw)
In-Reply-To: <20190220072820.GA21168@bhanusree-MacBookAir>

On Wed, Feb 20, 2019 at 12:58:20PM +0530, Bhanusree Pola wrote:
> - adds the SPDX GPL-2.0 license identifier which solves the checkpatch.pl warning
> - Removed license boilerplate text
> - Issue found with checkpatch.pl warning:
>   "WARNING: Missing or malformed SPDX-License-Identifier tag in line 1"
> 
> Signed-off-by: Bhanusree Pola <bhanusreemahesh@gmail.com>
> ---
>  drivers/staging/rtl8192e/dot11d.h | 17 +++--------------
>  1 file changed, 3 insertions(+), 14 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192e/dot11d.h b/drivers/staging/rtl8192e/dot11d.h
> index 0637de1cca47..44f11f629922 100644
> --- a/drivers/staging/rtl8192e/dot11d.h
> +++ b/drivers/staging/rtl8192e/dot11d.h
> @@ -1,17 +1,6 @@
> -/******************************************************************************
> - * Copyright(c) 2008 - 2010 Realtek Corporation. All rights reserved.
> - *
> - * This program is distributed in the hope that it will be useful, but WITHOUT
> - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
> - * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
> - * more details.
> - *
> - * The full GNU General Public License is included in this distribution in the
> - * file called LICENSE.
> - *
> - * Contact Information:
> - * wlanfae <wlanfae@realtek.com>

You dropped these two lines for no good reason :(

Please keep them in your next revision, it is good to have this in the
file as you know who to contact.

thanks,

greg k-h


      reply	other threads:[~2019-02-20 10:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-20  7:28 [PATCH 1/2] Staging: rtl8192e: Replace license text with SPDX identifier Bhanusree Pola
2019-02-20 10:23 ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190220102316.GA5535@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=bhanusreemahesh@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.