All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] Staging: rtl8192e: Replace license text with SPDX identifier
@ 2019-02-20  7:28 Bhanusree Pola
  2019-02-20 10:23 ` Greg Kroah-Hartman
  0 siblings, 1 reply; 2+ messages in thread
From: Bhanusree Pola @ 2019-02-20  7:28 UTC (permalink / raw)
  To: outreachy-kernel; +Cc: Greg Kroah-Hartman

- adds the SPDX GPL-2.0 license identifier which solves the checkpatch.pl warning
- Removed license boilerplate text
- Issue found with checkpatch.pl warning:
  "WARNING: Missing or malformed SPDX-License-Identifier tag in line 1"

Signed-off-by: Bhanusree Pola <bhanusreemahesh@gmail.com>
---
 drivers/staging/rtl8192e/dot11d.h | 17 +++--------------
 1 file changed, 3 insertions(+), 14 deletions(-)

diff --git a/drivers/staging/rtl8192e/dot11d.h b/drivers/staging/rtl8192e/dot11d.h
index 0637de1cca47..44f11f629922 100644
--- a/drivers/staging/rtl8192e/dot11d.h
+++ b/drivers/staging/rtl8192e/dot11d.h
@@ -1,17 +1,6 @@
-/******************************************************************************
- * Copyright(c) 2008 - 2010 Realtek Corporation. All rights reserved.
- *
- * This program is distributed in the hope that it will be useful, but WITHOUT
- * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
- * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
- * more details.
- *
- * The full GNU General Public License is included in this distribution in the
- * file called LICENSE.
- *
- * Contact Information:
- * wlanfae <wlanfae@realtek.com>
- ******************************************************************************/
+/* SPDX-License-Identifier: GPL-2.0 */
+/* Copyright(c) 2008 - 2010 Realtek Corporation. All rights reserved. */
+
 #ifndef __INC_DOT11D_H
 #define __INC_DOT11D_H
 
-- 
2.17.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 1/2] Staging: rtl8192e: Replace license text with SPDX identifier
  2019-02-20  7:28 [PATCH 1/2] Staging: rtl8192e: Replace license text with SPDX identifier Bhanusree Pola
@ 2019-02-20 10:23 ` Greg Kroah-Hartman
  0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2019-02-20 10:23 UTC (permalink / raw)
  To: Bhanusree Pola; +Cc: outreachy-kernel

On Wed, Feb 20, 2019 at 12:58:20PM +0530, Bhanusree Pola wrote:
> - adds the SPDX GPL-2.0 license identifier which solves the checkpatch.pl warning
> - Removed license boilerplate text
> - Issue found with checkpatch.pl warning:
>   "WARNING: Missing or malformed SPDX-License-Identifier tag in line 1"
> 
> Signed-off-by: Bhanusree Pola <bhanusreemahesh@gmail.com>
> ---
>  drivers/staging/rtl8192e/dot11d.h | 17 +++--------------
>  1 file changed, 3 insertions(+), 14 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192e/dot11d.h b/drivers/staging/rtl8192e/dot11d.h
> index 0637de1cca47..44f11f629922 100644
> --- a/drivers/staging/rtl8192e/dot11d.h
> +++ b/drivers/staging/rtl8192e/dot11d.h
> @@ -1,17 +1,6 @@
> -/******************************************************************************
> - * Copyright(c) 2008 - 2010 Realtek Corporation. All rights reserved.
> - *
> - * This program is distributed in the hope that it will be useful, but WITHOUT
> - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
> - * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
> - * more details.
> - *
> - * The full GNU General Public License is included in this distribution in the
> - * file called LICENSE.
> - *
> - * Contact Information:
> - * wlanfae <wlanfae@realtek.com>

You dropped these two lines for no good reason :(

Please keep them in your next revision, it is good to have this in the
file as you know who to contact.

thanks,

greg k-h


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-02-20 10:23 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-20  7:28 [PATCH 1/2] Staging: rtl8192e: Replace license text with SPDX identifier Bhanusree Pola
2019-02-20 10:23 ` Greg Kroah-Hartman

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.