From: Dan Carpenter <dan.carpenter@oracle.com>
To: YueHaibing <yuehaibing@huawei.com>
Cc: Chris Mason <clm@fb.com>, Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2 -next] btrfs: Remove unnecessary casts in btrfs_read_root_item
Date: Wed, 20 Feb 2019 12:33:38 +0000 [thread overview]
Message-ID: <20190220123338.GP17104@kadam> (raw)
In-Reply-To: <20190220123202.43256-1-yuehaibing@huawei.com>
On Wed, Feb 20, 2019 at 12:32:02PM +0000, YueHaibing wrote:
> There is a messy cast here:
> min_t(int, len, (int)sizeof(*item)));
>
> min_t() should normally cast to unsigned. It's not possible for
> "len" to be negative, but if it were then we definitely
> wouldn't want to pass negatives to read_extent_buffer(). Also there
> is an extra cast.
>
> This patch shouldn't affect runtime, it's just a clean up.
>
> Suggested-by: Dan Carpenter <dan.carpenter@oracle.com>
It wasn't really suggested by me... But I do think it's the right
thing.
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: YueHaibing <yuehaibing@huawei.com>
Cc: Chris Mason <clm@fb.com>, Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2 -next] btrfs: Remove unnecessary casts in btrfs_read_root_item
Date: Wed, 20 Feb 2019 15:33:38 +0300 [thread overview]
Message-ID: <20190220123338.GP17104@kadam> (raw)
In-Reply-To: <20190220123202.43256-1-yuehaibing@huawei.com>
On Wed, Feb 20, 2019 at 12:32:02PM +0000, YueHaibing wrote:
> There is a messy cast here:
> min_t(int, len, (int)sizeof(*item)));
>
> min_t() should normally cast to unsigned. It's not possible for
> "len" to be negative, but if it were then we definitely
> wouldn't want to pass negatives to read_extent_buffer(). Also there
> is an extra cast.
>
> This patch shouldn't affect runtime, it's just a clean up.
>
> Suggested-by: Dan Carpenter <dan.carpenter@oracle.com>
It wasn't really suggested by me... But I do think it's the right
thing.
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
regards,
dan carpenter
next prev parent reply other threads:[~2019-02-20 12:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-20 2:55 [PATCH -next] btrfs: Fix type conversion in btrfs_read_root_item YueHaibing
2019-02-20 3:08 ` YueHaibing
2019-02-20 3:38 ` Qu Wenruo
2019-02-20 3:38 ` Qu Wenruo
2019-02-20 5:58 ` Dan Carpenter
2019-02-20 5:58 ` Dan Carpenter
2019-02-20 6:10 ` Dan Carpenter
2019-02-20 6:10 ` Dan Carpenter
2019-02-20 9:10 ` YueHaibing
2019-02-20 9:10 ` YueHaibing
2019-02-20 12:32 ` [PATCH v2 -next] btrfs: Remove unnecessary casts " YueHaibing
2019-02-20 12:32 ` YueHaibing
2019-02-20 12:33 ` Dan Carpenter [this message]
2019-02-20 12:33 ` Dan Carpenter
2019-02-20 12:36 ` Qu Wenruo
2019-02-20 12:36 ` Qu Wenruo
2019-02-22 14:39 ` David Sterba
2019-02-22 14:39 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190220123338.GP17104@kadam \
--to=dan.carpenter@oracle.com \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.