[master][PATCH] ti-gc320-driver: move to k4.19

[master][PATCH] ti-gc320-driver: move to k4.19

[Gowtham Tammana]

  - Updated the recipe to pick sources for k4.19
  - Removed the gcc8 workaround patch as the new srcrev include those fixes

Signed-off-by: Gowtham Tammana <g-tammana@ti.com>
---
 ...-bypass-gcc8-stringop-overflow-error.patch | 26 -------------------
 .../ti-gc320-driver_5.0.11.p7.bb              |  7 +++--
 2 files changed, 3 insertions(+), 30 deletions(-)
 delete mode 100644 recipes-bsp/gc320-drivers/ti-gc320-driver/0001-Kbuild-bypass-gcc8-stringop-overflow-error.patch

diff --git a/recipes-bsp/gc320-drivers/ti-gc320-driver/0001-Kbuild-bypass-gcc8-stringop-overflow-error.patch b/recipes-bsp/gc320-drivers/ti-gc320-driver/0001-Kbuild-bypass-gcc8-stringop-overflow-error.patch
deleted file mode 100644
index 431afa76..00000000
--- a/recipes-bsp/gc320-drivers/ti-gc320-driver/0001-Kbuild-bypass-gcc8-stringop-overflow-error.patch
+++ /dev/null
@@ -1,26 +0,0 @@
-From c93a4217425ffebae1fb2d5c6c7fc957eb8aa18c Mon Sep 17 00:00:00 2001
-From: Denys Dmytriyenko <denys@ti.com>
-Date: Tue, 16 Oct 2018 21:16:48 -0400
-Subject: [PATCH] Kbuild: bypass gcc8 stringop-overflow error
-
-Signed-off-by: Denys Dmytriyenko <denys@ti.com>
----
- src/Kbuild | 2 +-
- 1 file changed, 1 insertion(+), 1 deletion(-)
-
-diff --git a/src/Kbuild b/src/Kbuild
-index 574a107..df4368d 100755
---- a/src/Kbuild
-+++ b/src/Kbuild
-@@ -87,7 +87,7 @@ MODULE_NAME ?= galcore
- CUSTOMER_ALLOCATOR_OBJS    ?=
- ALLOCATOR_ARRAY_H_LOCATION ?= $(OS_KERNEL_DIR)/allocator/default/
- 
--EXTRA_CFLAGS += -Werror
-+EXTRA_CFLAGS += -Werror -Wno-stringop-overflow
- 
- OBJS := $(OS_KERNEL_DIR)/gc_hal_kernel_device.o \
-         $(OS_KERNEL_DIR)/gc_hal_kernel_linux.o \
--- 
-2.7.4
-
diff --git a/recipes-bsp/gc320-drivers/ti-gc320-driver_5.0.11.p7.bb b/recipes-bsp/gc320-drivers/ti-gc320-driver_5.0.11.p7.bb
index 1a6bc5da..551a3512 100644
--- a/recipes-bsp/gc320-drivers/ti-gc320-driver_5.0.11.p7.bb
+++ b/recipes-bsp/gc320-drivers/ti-gc320-driver_5.0.11.p7.bb
@@ -9,12 +9,11 @@ MACHINE_KERNEL_PR_append = "e"
 PR = "${MACHINE_KERNEL_PR}"
 
 # Need to branch out with ${PV} var
-BRANCH = "ti-${PV}-k4.14"
+BRANCH = "ti-${PV}-k4.19"
 
-SRCREV = "a36799d9329efcfff19e30e690156d5ebf7e0c55"
+SRCREV = "9b59e596b4adefabbb686ce8845edef8114558fd"
 
-SRC_URI = "git://git.ti.com/graphics/ti-gc320-driver.git;protocol=git;branch=${BRANCH} \
-	file://0001-Kbuild-bypass-gcc8-stringop-overflow-error.patch;striplevel=2"
+SRC_URI = "git://git.ti.com/graphics/ti-gc320-driver.git;protocol=git;branch=${BRANCH}
 
 S = "${WORKDIR}/git/src"
 
-- 
2.20.1

Re: [master][PATCH] ti-gc320-driver: move to k4.19

[Denys Dmytriyenko]

On Mon, Feb 18, 2019 at 05:12:30PM -0600, Gowtham Tammana wrote:
>   - Updated the recipe to pick sources for k4.19
>   - Removed the gcc8 workaround patch as the new srcrev include those fixes
> 
> Signed-off-by: Gowtham Tammana <g-tammana@ti.com>
> ---
...
> diff --git a/recipes-bsp/gc320-drivers/ti-gc320-driver_5.0.11.p7.bb b/recipes-bsp/gc320-drivers/ti-gc320-driver_5.0.11.p7.bb
> index 1a6bc5da..551a3512 100644
> --- a/recipes-bsp/gc320-drivers/ti-gc320-driver_5.0.11.p7.bb
> +++ b/recipes-bsp/gc320-drivers/ti-gc320-driver_5.0.11.p7.bb
> @@ -9,12 +9,11 @@ MACHINE_KERNEL_PR_append = "e"
>  PR = "${MACHINE_KERNEL_PR}"
>  
>  # Need to branch out with ${PV} var
> -BRANCH = "ti-${PV}-k4.14"
> +BRANCH = "ti-${PV}-k4.19"
>  
> -SRCREV = "a36799d9329efcfff19e30e690156d5ebf7e0c55"
> +SRCREV = "9b59e596b4adefabbb686ce8845edef8114558fd"
>  
> -SRC_URI = "git://git.ti.com/graphics/ti-gc320-driver.git;protocol=git;branch=${BRANCH} \
> -	file://0001-Kbuild-bypass-gcc8-stringop-overflow-error.patch;striplevel=2"
> +SRC_URI = "git://git.ti.com/graphics/ti-gc320-driver.git;protocol=git;branch=${BRANCH}

This change lost the closing quote in SRC_URI, leading to parse errors.
Please at least build-test your patches before submitting them! Thanks.


>  S = "${WORKDIR}/git/src"
>  
> -- 
> 2.20.1
> 

Re: [master][PATCH] ti-gc320-driver: move to k4.19

[Tammana, Gowtham]

> -----Original Message-----
> From: Dmytriyenko, Denys
> Sent: Wednesday, February 20, 2019 4:16 PM
> To: Tammana, Gowtham
> Cc: meta-ti@yoctoproject.org; Balagopalakrishnan, Anand; Ruei, Eric
> Subject: Re: [meta-ti][master][PATCH] ti-gc320-driver: move to k4.19
> 
> On Mon, Feb 18, 2019 at 05:12:30PM -0600, Gowtham Tammana wrote:
> >   - Updated the recipe to pick sources for k4.19
> >   - Removed the gcc8 workaround patch as the new srcrev include those fixes
> >
> > Signed-off-by: Gowtham Tammana <g-tammana@ti.com>
> > ---
> ...
> > diff --git a/recipes-bsp/gc320-drivers/ti-gc320-driver_5.0.11.p7.bb
> b/recipes-bsp/gc320-drivers/ti-gc320-driver_5.0.11.p7.bb
> > index 1a6bc5da..551a3512 100644
> > --- a/recipes-bsp/gc320-drivers/ti-gc320-driver_5.0.11.p7.bb
> > +++ b/recipes-bsp/gc320-drivers/ti-gc320-driver_5.0.11.p7.bb
> > @@ -9,12 +9,11 @@ MACHINE_KERNEL_PR_append = "e"
> >  PR = "${MACHINE_KERNEL_PR}"
> >
> >  # Need to branch out with ${PV} var
> > -BRANCH = "ti-${PV}-k4.14"
> > +BRANCH = "ti-${PV}-k4.19"
> >
> > -SRCREV = "a36799d9329efcfff19e30e690156d5ebf7e0c55"
> > +SRCREV = "9b59e596b4adefabbb686ce8845edef8114558fd"
> >
> > -SRC_URI = "git://git.ti.com/graphics/ti-gc320-
> driver.git;protocol=git;branch=${BRANCH} \
> > -	file://0001-Kbuild-bypass-gcc8-stringop-overflow-
> error.patch;striplevel=2"
> > +SRC_URI = "git://git.ti.com/graphics/ti-gc320-
> driver.git;protocol=git;branch=${BRANCH}
> 
> This change lost the closing quote in SRC_URI, leading to parse errors.
> Please at least build-test your patches before submitting them! Thanks.

An oversight from my side on choosing the patchset, apologies.
Thanks for the fix.

 
> >  S = "${WORKDIR}/git/src"
> >
> > --
> > 2.20.1
> >