From: Wei Yang <richardw.yang@linux.intel.com>
To: Xiao Guangrong <xiaoguangrong.eric@gmail.com>
Cc: Wei Yang <richardw.yang@linux.intel.com>,
qemu-devel@nongnu.org, mst@redhat.com, imammedo@redhat.com,
philmd@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 0/3] PCDIMM cleanup
Date: Thu, 21 Feb 2019 14:13:33 +0800 [thread overview]
Message-ID: <20190221061333.GA20921@richard> (raw)
In-Reply-To: <d88127af-dbc8-fce0-f128-b23f1f6ea0ce@gmail.com>
On Thu, Feb 21, 2019 at 02:03:19PM +0800, Xiao Guangrong wrote:
>
>
>On 2/20/19 8:51 AM, Wei Yang wrote:
>> Three trivial cleanup for pc-dimm.
>>
>> Patch [1] remove the check on class->hotpluggable since pc-dimm is always
>> hotpluggable.
>> Patch [2] remove nvdimm_realize
>> Patch [2] remove pcdimm realize-callback
>>
>> v2:
>> * fix warning in Patch 1
>> * split Patch 2 into two
>>
>> Wei Yang (3):
>> pc-dimm: remove check on pc-dimm hotpluggable
>> mem/nvdimm: remove nvdimm_realize
>
>> pc-dimm: revert "introduce realize callback"
>
>I think the word 'revert' is not so precise as that hints
>the commit is bugly, instead, it was factored in the later
>comments then becomes useless now.
>
You are right. It is always difficult for me to pick up the proper word.
>Anyway, this pathset looks good to me.
>
>Reviewed-by: Xiao Guangrong <xiaoguangrong@tencent.com>
Thanks, Xiao.
--
Wei Yang
Help you, Help me
next prev parent reply other threads:[~2019-02-21 6:14 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-20 0:51 [Qemu-devel] [PATCH v2 0/3] PCDIMM cleanup Wei Yang
2019-02-20 0:51 ` [Qemu-devel] [PATCH v2 1/3] pc-dimm: remove check on pc-dimm hotpluggable Wei Yang
2019-02-20 1:13 ` Philippe Mathieu-Daudé
2019-02-20 0:51 ` [Qemu-devel] [PATCH v2 2/3] mem/nvdimm: remove nvdimm_realize Wei Yang
2019-02-20 1:21 ` Philippe Mathieu-Daudé
2019-02-20 0:51 ` [Qemu-devel] [PATCH v2 3/3] pc-dimm: revert "introduce realize callback" Wei Yang
2019-02-20 1:26 ` Philippe Mathieu-Daudé
2019-02-20 1:39 ` Wei Yang
2019-02-21 6:03 ` [Qemu-devel] [PATCH v2 0/3] PCDIMM cleanup Xiao Guangrong
2019-02-21 6:13 ` Wei Yang [this message]
2019-02-21 14:50 ` Igor Mammedov
2019-02-23 0:02 ` Wei Yang
2019-02-25 8:05 ` Igor Mammedov
2019-02-25 12:47 ` Wei Yang
2019-02-27 13:12 ` Igor Mammedov
2019-02-27 13:59 ` Wei Yang
2019-02-27 17:27 ` Igor Mammedov
2019-02-27 21:25 ` Wei Yang
2019-02-28 0:46 ` Wei Yang
2019-02-28 13:57 ` Igor Mammedov
2019-03-01 1:23 ` Wei Yang
2019-02-21 16:58 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190221061333.GA20921@richard \
--to=richardw.yang@linux.intel.com \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=xiaoguangrong.eric@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.