From: Igor Mammedov <imammedo@redhat.com>
To: Wei Yang <richardw.yang@linux.intel.com>
Cc: qemu-devel@nongnu.org, mst@redhat.com,
xiaoguangrong.eric@gmail.com, philmd@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 0/3] PCDIMM cleanup
Date: Thu, 21 Feb 2019 15:50:04 +0100 [thread overview]
Message-ID: <20190221155004.010f7b7a@redhat.com> (raw)
In-Reply-To: <20190220005124.24224-1-richardw.yang@linux.intel.com>
On Wed, 20 Feb 2019 08:51:21 +0800
Wei Yang <richardw.yang@linux.intel.com> wrote:
> Three trivial cleanup for pc-dimm.
>
> Patch [1] remove the check on class->hotpluggable since pc-dimm is always
> hotpluggable.
> Patch [2] remove nvdimm_realize
> Patch [2] remove pcdimm realize-callback
even though this series doesn't break anything, I disagree with it
conceptually as it makes device less abstracted and make it more
dependent on how existing machine code uses it.
I'd drop whole series.
>
> v2:
> * fix warning in Patch 1
> * split Patch 2 into two
>
> Wei Yang (3):
> pc-dimm: remove check on pc-dimm hotpluggable
> mem/nvdimm: remove nvdimm_realize
> pc-dimm: revert "introduce realize callback"
>
> hw/acpi/memory_hotplug.c | 5 -----
> hw/mem/nvdimm.c | 11 -----------
> hw/mem/pc-dimm.c | 5 -----
> include/hw/mem/pc-dimm.h | 3 ---
> 4 files changed, 24 deletions(-)
>
next prev parent reply other threads:[~2019-02-21 14:50 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-20 0:51 [Qemu-devel] [PATCH v2 0/3] PCDIMM cleanup Wei Yang
2019-02-20 0:51 ` [Qemu-devel] [PATCH v2 1/3] pc-dimm: remove check on pc-dimm hotpluggable Wei Yang
2019-02-20 1:13 ` Philippe Mathieu-Daudé
2019-02-20 0:51 ` [Qemu-devel] [PATCH v2 2/3] mem/nvdimm: remove nvdimm_realize Wei Yang
2019-02-20 1:21 ` Philippe Mathieu-Daudé
2019-02-20 0:51 ` [Qemu-devel] [PATCH v2 3/3] pc-dimm: revert "introduce realize callback" Wei Yang
2019-02-20 1:26 ` Philippe Mathieu-Daudé
2019-02-20 1:39 ` Wei Yang
2019-02-21 6:03 ` [Qemu-devel] [PATCH v2 0/3] PCDIMM cleanup Xiao Guangrong
2019-02-21 6:13 ` Wei Yang
2019-02-21 14:50 ` Igor Mammedov [this message]
2019-02-23 0:02 ` Wei Yang
2019-02-25 8:05 ` Igor Mammedov
2019-02-25 12:47 ` Wei Yang
2019-02-27 13:12 ` Igor Mammedov
2019-02-27 13:59 ` Wei Yang
2019-02-27 17:27 ` Igor Mammedov
2019-02-27 21:25 ` Wei Yang
2019-02-28 0:46 ` Wei Yang
2019-02-28 13:57 ` Igor Mammedov
2019-03-01 1:23 ` Wei Yang
2019-02-21 16:58 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190221155004.010f7b7a@redhat.com \
--to=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richardw.yang@linux.intel.com \
--cc=xiaoguangrong.eric@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.