From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Bhanusree Mahesh <bhanusreemahesh@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [PATCH 0/3] Staging: fbtft: Fix Various Checkpatch issues
Date: Thu, 21 Feb 2019 17:14:44 +0100 [thread overview]
Message-ID: <20190221161444.GD25800@kroah.com> (raw)
In-Reply-To: <CAB0Mk-Nt58V4_bGqFiDD5RyHEU68Azfk=1qCM-QqSiQEihr05g@mail.gmail.com>
On Thu, Feb 21, 2019 at 09:35:29PM +0530, Bhanusree Mahesh wrote:
> On Thu, 21 Feb 2019 at 21:31, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > On Thu, Feb 21, 2019 at 08:49:18PM +0530, Bhanusree Pola wrote:
> > > This series cleans the following checkpatch.pl issues:
> > >
> > > CHECK: Extra blank line not required before closing brace '}'
> > > WARNING:EXPORT_SYMBOL(foo); should follow its function/variable
> > > WARNING:line over 80 characters
> > >
> > > Bhanusree Pola (3):
> > > Staging: fbtft: Remove extra blank line before '}'
> > > Staging: fbtf: Declare Exprot symbols immediately
> > > Staging: fbtft: Fix line over 80 characters warning
> > >
> > > drivers/staging/fbtft/fbtft-core.c | 11 +++++------
> > > 1 file changed, 5 insertions(+), 6 deletions(-)
> >
> > Your patches are not "threaded", like I asked for last time. How are
> > you sending these out? git send-email should do it automatically.
> >
> i'm sending each patch separately using mutt.
Ok, when doing that, make sure you properly thread them. You can do
that by "replying" to the previous email you sent, and keeping the
"In-Reply-To:" line in the header.
Or you can use git send-email :)
You might want to get send-email working, as you are sending lots of
patches, it makes things much easier.
thanks,
greg k-h
prev parent reply other threads:[~2019-02-21 16:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-21 15:19 [PATCH 0/3] Staging: fbtft: Fix Various Checkpatch issues Bhanusree Pola
2019-02-21 16:01 ` Greg Kroah-Hartman
2019-02-21 16:05 ` Bhanusree Mahesh
2019-02-21 16:14 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190221161444.GD25800@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bhanusreemahesh@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.