[PATCH 0/3] Staging: fbtft: Fix Various Checkpatch issues

[PATCH 0/3] Staging: fbtft: Fix Various Checkpatch issues

[Bhanusree Pola]

This series cleans the following checkpatch.pl issues:

CHECK: Extra blank line not required before closing brace '}'
WARNING:EXPORT_SYMBOL(foo); should follow its function/variable
WARNING:line over 80 characters

Bhanusree Pola (3):
  Staging: fbtft: Remove extra blank line before '}'
  Staging: fbtf: Declare Exprot symbols immediately
  Staging: fbtft: Fix line over 80 characters warning

 drivers/staging/fbtft/fbtft-core.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

-- 
2.17.1

Re: [PATCH 0/3] Staging: fbtft: Fix Various Checkpatch issues

[Greg Kroah-Hartman]

On Thu, Feb 21, 2019 at 08:49:18PM +0530, Bhanusree Pola wrote:
> This series cleans the following checkpatch.pl issues:
> 
> CHECK: Extra blank line not required before closing brace '}'
> WARNING:EXPORT_SYMBOL(foo); should follow its function/variable
> WARNING:line over 80 characters
> 
> Bhanusree Pola (3):
>   Staging: fbtft: Remove extra blank line before '}'
>   Staging: fbtf: Declare Exprot symbols immediately
>   Staging: fbtft: Fix line over 80 characters warning
> 
>  drivers/staging/fbtft/fbtft-core.c | 11 +++++------
>  1 file changed, 5 insertions(+), 6 deletions(-)

Your patches are not "threaded", like I asked for last time.  How are
you sending these out?  git send-email should do it automatically.

thanks,

greg k-h

Re: [PATCH 0/3] Staging: fbtft: Fix Various Checkpatch issues

[Bhanusree Mahesh]

On Thu, 21 Feb 2019 at 21:31, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Thu, Feb 21, 2019 at 08:49:18PM +0530, Bhanusree Pola wrote:
> > This series cleans the following checkpatch.pl issues:
> >
> > CHECK: Extra blank line not required before closing brace '}'
> > WARNING:EXPORT_SYMBOL(foo); should follow its function/variable
> > WARNING:line over 80 characters
> >
> > Bhanusree Pola (3):
> >   Staging: fbtft: Remove extra blank line before '}'
> >   Staging: fbtf: Declare Exprot symbols immediately
> >   Staging: fbtft: Fix line over 80 characters warning
> >
> >  drivers/staging/fbtft/fbtft-core.c | 11 +++++------
> >  1 file changed, 5 insertions(+), 6 deletions(-)
>
> Your patches are not "threaded", like I asked for last time.  How are
> you sending these out?  git send-email should do it automatically.
>
i'm sending each patch separately using mutt.

Re: [PATCH 0/3] Staging: fbtft: Fix Various Checkpatch issues

[Greg Kroah-Hartman]

On Thu, Feb 21, 2019 at 09:35:29PM +0530, Bhanusree Mahesh wrote:
> On Thu, 21 Feb 2019 at 21:31, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > On Thu, Feb 21, 2019 at 08:49:18PM +0530, Bhanusree Pola wrote:
> > > This series cleans the following checkpatch.pl issues:
> > >
> > > CHECK: Extra blank line not required before closing brace '}'
> > > WARNING:EXPORT_SYMBOL(foo); should follow its function/variable
> > > WARNING:line over 80 characters
> > >
> > > Bhanusree Pola (3):
> > >   Staging: fbtft: Remove extra blank line before '}'
> > >   Staging: fbtf: Declare Exprot symbols immediately
> > >   Staging: fbtft: Fix line over 80 characters warning
> > >
> > >  drivers/staging/fbtft/fbtft-core.c | 11 +++++------
> > >  1 file changed, 5 insertions(+), 6 deletions(-)
> >
> > Your patches are not "threaded", like I asked for last time.  How are
> > you sending these out?  git send-email should do it automatically.
> >
> i'm sending each patch separately using mutt.

Ok, when doing that, make sure you properly thread them.  You can do
that by "replying" to the previous email you sent, and keeping the
"In-Reply-To:" line in the header.

Or you can use git send-email :)

You might want to get send-email working, as you are sending lots of
patches, it makes things much easier.

thanks,

greg k-h