From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2] net: set static variable an initial value in atl2_probe()
Date: Fri, 22 Feb 2019 06:28:29 +0000 [thread overview]
Message-ID: <20190222062829.GC1737@kadam> (raw)
In-Reply-To: <20190222054012.194038-1-maowenan@huawei.com>
You need to send this to netdev.
On Fri, Feb 22, 2019 at 01:40:12PM +0800, Mao Wenan wrote:
> cards_found is a static variable, but when it enters atl2_probe(),
> cards_found is set to zero, the value is not consistent with it in the heap,
> so next behavior is not our expect.
>
This seems reasonable. Does this do anything besides let you configure
multiple cards in different ways using module parameters?
regards,
dan carpenter
next prev parent reply other threads:[~2019-02-22 6:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-22 5:40 [PATCH v2] net: set static variable an initial value in atl2_probe() Mao Wenan
2019-02-22 6:28 ` Dan Carpenter [this message]
2019-02-22 6:54 ` maowenan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190222062829.GC1737@kadam \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.