[PATCH v2] net: set static variable an initial value in atl2_probe()

[PATCH v2] net: set static variable an initial value in atl2_probe()

[Mao Wenan]

cards_found is a static variable, but when it enters atl2_probe(),
cards_found is set to zero, the value is not consistent with it in the heap,
so next behavior is not our expect.

Signed-off-by: Mao Wenan <maowenan@huawei.com>
---
 v1->v2 change the subject from "net: drop pointless static qualifier in atl2_probe()"
 to "net: set static variable an initial value in atl2_probe()";
 keep 'static' for variable cards_found.  
 drivers/net/ethernet/atheros/atlx/atl2.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/atheros/atlx/atl2.c b/drivers/net/ethernet/atheros/atlx/atl2.c
index bb41becb6609..31ff1e0d1baa 100644
--- a/drivers/net/ethernet/atheros/atlx/atl2.c
+++ b/drivers/net/ethernet/atheros/atlx/atl2.c
@@ -1335,13 +1335,11 @@ static int atl2_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 {
 	struct net_device *netdev;
 	struct atl2_adapter *adapter;
-	static int cards_found;
+	static int cards_found = 0;
 	unsigned long mmio_start;
 	int mmio_len;
 	int err;
 
-	cards_found = 0;
-
 	err = pci_enable_device(pdev);
 	if (err)
 		return err;
-- 
2.20.1

Re: [PATCH v2] net: set static variable an initial value in atl2_probe()

[Dan Carpenter]

You need to send this to netdev.

On Fri, Feb 22, 2019 at 01:40:12PM +0800, Mao Wenan wrote:
> cards_found is a static variable, but when it enters atl2_probe(),
> cards_found is set to zero, the value is not consistent with it in the heap,
> so next behavior is not our expect.
> 

This seems reasonable.  Does this do anything besides let you configure
multiple cards in different ways using module parameters?

regards,
dan carpenter

Re: [PATCH v2] net: set static variable an initial value in atl2_probe()

[maowenan]

On 2019/2/22 14:28, Dan Carpenter wrote:
> You need to send this to netdev.
OK, I have done that.
> 
> On Fri, Feb 22, 2019 at 01:40:12PM +0800, Mao Wenan wrote:
>> cards_found is a static variable, but when it enters atl2_probe(),
>> cards_found is set to zero, the value is not consistent with it in the heap,
>> so next behavior is not our expect.
>>
> 
> This seems reasonable.  Does this do anything besides let you configure
> multiple cards in different ways using module parameters?

I think this need to develop new interface by using module parameters.