All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Mackerras <paulus@ozlabs.org>
To: Jordan Niethe <jniethe5@gmail.com>
Cc: linuxppc-dev@lists.ozlabs.org, kvm-ppc@vger.kernel.org
Subject: Re: [PATCH] KVM: PPC: Book3S HV: Fix build failure without IOMMU support
Date: Fri, 22 Feb 2019 09:41:01 +0000	[thread overview]
Message-ID: <20190222094101.GE6006@blackberry> (raw)
In-Reply-To: <20190221032848.22590-1-jniethe5@gmail.com>

On Thu, Feb 21, 2019 at 02:28:48PM +1100, Jordan Niethe wrote:
> Currently trying to build without IOMMU support will fail:
> 
>   (.text+0x1380): undefined reference to `kvmppc_h_get_tce'
>   (.text+0x1384): undefined reference to `kvmppc_rm_h_put_tce'
>   (.text+0x149c): undefined reference to `kvmppc_rm_h_stuff_tce'
>   (.text+0x14a0): undefined reference to `kvmppc_rm_h_put_tce_indirect'
> 
> This happens because turning off IOMMU support will prevent
> book3s_64_vio_hv.c from being built because it is only built when
> SPAPR_TCE_IOMMU is set, which depends on IOMMU support.
> 
> Fix it using ifdefs for the undefined references.
> 
> Fixes: 76d837a4c0f9 ("KVM: PPC: Book3S PR: Don't include SPAPR TCE code on non-pseries platforms")
> Signed-off-by: Jordan Niethe <jniethe5@gmail.com>

Thanks, applied to my kvm-ppc-next tree.

Paul.

WARNING: multiple messages have this Message-ID (diff)
From: Paul Mackerras <paulus@ozlabs.org>
To: Jordan Niethe <jniethe5@gmail.com>
Cc: linuxppc-dev@lists.ozlabs.org, kvm-ppc@vger.kernel.org
Subject: Re: [PATCH] KVM: PPC: Book3S HV: Fix build failure without IOMMU support
Date: Fri, 22 Feb 2019 20:41:01 +1100	[thread overview]
Message-ID: <20190222094101.GE6006@blackberry> (raw)
In-Reply-To: <20190221032848.22590-1-jniethe5@gmail.com>

On Thu, Feb 21, 2019 at 02:28:48PM +1100, Jordan Niethe wrote:
> Currently trying to build without IOMMU support will fail:
> 
>   (.text+0x1380): undefined reference to `kvmppc_h_get_tce'
>   (.text+0x1384): undefined reference to `kvmppc_rm_h_put_tce'
>   (.text+0x149c): undefined reference to `kvmppc_rm_h_stuff_tce'
>   (.text+0x14a0): undefined reference to `kvmppc_rm_h_put_tce_indirect'
> 
> This happens because turning off IOMMU support will prevent
> book3s_64_vio_hv.c from being built because it is only built when
> SPAPR_TCE_IOMMU is set, which depends on IOMMU support.
> 
> Fix it using ifdefs for the undefined references.
> 
> Fixes: 76d837a4c0f9 ("KVM: PPC: Book3S PR: Don't include SPAPR TCE code on non-pseries platforms")
> Signed-off-by: Jordan Niethe <jniethe5@gmail.com>

Thanks, applied to my kvm-ppc-next tree.

Paul.

  reply	other threads:[~2019-02-22  9:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-21  3:28 [PATCH] KVM: PPC: Book3S HV: Fix build failure without IOMMU support Jordan Niethe
2019-02-21  3:28 ` Jordan Niethe
2019-02-22  9:41 ` Paul Mackerras [this message]
2019-02-22  9:41   ` Paul Mackerras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190222094101.GE6006@blackberry \
    --to=paulus@ozlabs.org \
    --cc=jniethe5@gmail.com \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.