* [PATCH] ARM: dts: exynos: Add pin configuration for read strobe for Odroid XU3/XU4 eMMC @ 2019-02-22 10:19 ` Anand Moon 0 siblings, 0 replies; 6+ messages in thread From: Anand Moon @ 2019-02-22 10:19 UTC (permalink / raw) To: devicetree, linux-arm-kernel, linux-samsung-soc Cc: Rob Herring, Krzysztof Kozlowski, Marek Szyprowski, linux-kernel Add Read Strobe RDQS pin configuration for eMMC to support higher data rate read/write. Signed-off-by: Anand Moon <linux.amoon@gmail.com> --- arch/arm/boot/dts/exynos5420-pinctrl.dtsi | 6 ++++++ arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi index b82af7c89654..4fb3865e082a 100644 --- a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi +++ b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi @@ -206,6 +206,12 @@ samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV4>; }; + sd0_rdqs: sd0-rdqs { + samsung,pins = "gpc0-7"; + samsung,pin-function = <EXYNOS_PIN_FUNC_2>; + samsung,pin-pud = <EXYNOS_PIN_PULL_DOWN>; + }; + sd1_clk: sd1-clk { samsung,pins = "gpc1-0"; samsung,pin-function = <EXYNOS_PIN_FUNC_2>; diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi index b299e541cac0..d41397748ed2 100644 --- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi +++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi @@ -411,7 +411,7 @@ samsung,dw-mshc-hs400-timing = <0 2>; samsung,read-strobe-delay = <90>; pinctrl-names = "default"; - pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus1 &sd0_bus4 &sd0_bus8 &sd0_cd &sd0_rclk>; + pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_rdqs &sd0_bus1 &sd0_bus4 &sd0_bus8 &sd0_cd &sd0_rclk>; bus-width = <8>; cap-mmc-highspeed; mmc-hs200-1_8v; -- 2.20.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] ARM: dts: exynos: Add pin configuration for read strobe for Odroid XU3/XU4 eMMC @ 2019-02-22 10:19 ` Anand Moon 0 siblings, 0 replies; 6+ messages in thread From: Anand Moon @ 2019-02-22 10:19 UTC (permalink / raw) To: devicetree, linux-arm-kernel, linux-samsung-soc Cc: Rob Herring, linux-kernel, Krzysztof Kozlowski, Marek Szyprowski Add Read Strobe RDQS pin configuration for eMMC to support higher data rate read/write. Signed-off-by: Anand Moon <linux.amoon@gmail.com> --- arch/arm/boot/dts/exynos5420-pinctrl.dtsi | 6 ++++++ arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi index b82af7c89654..4fb3865e082a 100644 --- a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi +++ b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi @@ -206,6 +206,12 @@ samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV4>; }; + sd0_rdqs: sd0-rdqs { + samsung,pins = "gpc0-7"; + samsung,pin-function = <EXYNOS_PIN_FUNC_2>; + samsung,pin-pud = <EXYNOS_PIN_PULL_DOWN>; + }; + sd1_clk: sd1-clk { samsung,pins = "gpc1-0"; samsung,pin-function = <EXYNOS_PIN_FUNC_2>; diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi index b299e541cac0..d41397748ed2 100644 --- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi +++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi @@ -411,7 +411,7 @@ samsung,dw-mshc-hs400-timing = <0 2>; samsung,read-strobe-delay = <90>; pinctrl-names = "default"; - pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus1 &sd0_bus4 &sd0_bus8 &sd0_cd &sd0_rclk>; + pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_rdqs &sd0_bus1 &sd0_bus4 &sd0_bus8 &sd0_cd &sd0_rclk>; bus-width = <8>; cap-mmc-highspeed; mmc-hs200-1_8v; -- 2.20.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: exynos: Add pin configuration for read strobe for Odroid XU3/XU4 eMMC 2019-02-22 10:19 ` Anand Moon @ 2019-02-22 10:29 ` Marek Szyprowski -1 siblings, 0 replies; 6+ messages in thread From: Marek Szyprowski @ 2019-02-22 10:29 UTC (permalink / raw) To: Anand Moon, devicetree, linux-arm-kernel, linux-samsung-soc Cc: Rob Herring, Krzysztof Kozlowski, linux-kernel Hi Anand, On 2019-02-22 11:19, Anand Moon wrote: > Add Read Strobe RDQS pin configuration for eMMC to support higher data rate read/write. > > Signed-off-by: Anand Moon <linux.amoon@gmail.com> > --- > arch/arm/boot/dts/exynos5420-pinctrl.dtsi | 6 ++++++ > arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 2 +- > 2 files changed, 7 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi > index b82af7c89654..4fb3865e082a 100644 > --- a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi > +++ b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi > @@ -206,6 +206,12 @@ > samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV4>; > }; > > + sd0_rdqs: sd0-rdqs { > + samsung,pins = "gpc0-7"; > + samsung,pin-function = <EXYNOS_PIN_FUNC_2>; > + samsung,pin-pud = <EXYNOS_PIN_PULL_DOWN>; > + }; > + The above lines are not needed. There is already a sd0_rclk node with exactly the same configuration just above your change. > sd1_clk: sd1-clk { > samsung,pins = "gpc1-0"; > samsung,pin-function = <EXYNOS_PIN_FUNC_2>; > diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi > index b299e541cac0..d41397748ed2 100644 > --- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi > +++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi > @@ -411,7 +411,7 @@ > samsung,dw-mshc-hs400-timing = <0 2>; > samsung,read-strobe-delay = <90>; > pinctrl-names = "default"; > - pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus1 &sd0_bus4 &sd0_bus8 &sd0_cd &sd0_rclk>; > + pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_rdqs &sd0_bus1 &sd0_bus4 &sd0_bus8 &sd0_cd &sd0_rclk>; > bus-width = <8>; > cap-mmc-highspeed; > mmc-hs200-1_8v; Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: exynos: Add pin configuration for read strobe for Odroid XU3/XU4 eMMC @ 2019-02-22 10:29 ` Marek Szyprowski 0 siblings, 0 replies; 6+ messages in thread From: Marek Szyprowski @ 2019-02-22 10:29 UTC (permalink / raw) To: Anand Moon, devicetree, linux-arm-kernel, linux-samsung-soc Cc: Rob Herring, linux-kernel, Krzysztof Kozlowski Hi Anand, On 2019-02-22 11:19, Anand Moon wrote: > Add Read Strobe RDQS pin configuration for eMMC to support higher data rate read/write. > > Signed-off-by: Anand Moon <linux.amoon@gmail.com> > --- > arch/arm/boot/dts/exynos5420-pinctrl.dtsi | 6 ++++++ > arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 2 +- > 2 files changed, 7 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi > index b82af7c89654..4fb3865e082a 100644 > --- a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi > +++ b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi > @@ -206,6 +206,12 @@ > samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV4>; > }; > > + sd0_rdqs: sd0-rdqs { > + samsung,pins = "gpc0-7"; > + samsung,pin-function = <EXYNOS_PIN_FUNC_2>; > + samsung,pin-pud = <EXYNOS_PIN_PULL_DOWN>; > + }; > + The above lines are not needed. There is already a sd0_rclk node with exactly the same configuration just above your change. > sd1_clk: sd1-clk { > samsung,pins = "gpc1-0"; > samsung,pin-function = <EXYNOS_PIN_FUNC_2>; > diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi > index b299e541cac0..d41397748ed2 100644 > --- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi > +++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi > @@ -411,7 +411,7 @@ > samsung,dw-mshc-hs400-timing = <0 2>; > samsung,read-strobe-delay = <90>; > pinctrl-names = "default"; > - pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus1 &sd0_bus4 &sd0_bus8 &sd0_cd &sd0_rclk>; > + pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_rdqs &sd0_bus1 &sd0_bus4 &sd0_bus8 &sd0_cd &sd0_rclk>; > bus-width = <8>; > cap-mmc-highspeed; > mmc-hs200-1_8v; Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: exynos: Add pin configuration for read strobe for Odroid XU3/XU4 eMMC 2019-02-22 10:29 ` Marek Szyprowski @ 2019-02-22 10:33 ` Anand Moon -1 siblings, 0 replies; 6+ messages in thread From: Anand Moon @ 2019-02-22 10:33 UTC (permalink / raw) To: Marek Szyprowski Cc: devicetree, linux-arm-kernel, linux-samsung-soc, Rob Herring, Krzysztof Kozlowski, Linux Kernel Hi Marek, On Fri, 22 Feb 2019 at 15:59, Marek Szyprowski <m.szyprowski@samsung.com> wrote: > > Hi Anand, > > On 2019-02-22 11:19, Anand Moon wrote: > > Add Read Strobe RDQS pin configuration for eMMC to support higher data rate read/write. > > > > Signed-off-by: Anand Moon <linux.amoon@gmail.com> > > --- > > arch/arm/boot/dts/exynos5420-pinctrl.dtsi | 6 ++++++ > > arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 2 +- > > 2 files changed, 7 insertions(+), 1 deletion(-) > > > > diff --git a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi > > index b82af7c89654..4fb3865e082a 100644 > > --- a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi > > +++ b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi > > @@ -206,6 +206,12 @@ > > samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV4>; > > }; > > > > + sd0_rdqs: sd0-rdqs { > > + samsung,pins = "gpc0-7"; > > + samsung,pin-function = <EXYNOS_PIN_FUNC_2>; > > + samsung,pin-pud = <EXYNOS_PIN_PULL_DOWN>; > > + }; > > + > > The above lines are not needed. There is already a sd0_rclk node with > exactly the same configuration just above your change. > Sorry once again, I failed to look closely., sorry for the noise. Best Regards -Anand > > sd1_clk: sd1-clk { > > samsung,pins = "gpc1-0"; > > samsung,pin-function = <EXYNOS_PIN_FUNC_2>; > > diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi > > index b299e541cac0..d41397748ed2 100644 > > --- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi > > +++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi > > @@ -411,7 +411,7 @@ > > samsung,dw-mshc-hs400-timing = <0 2>; > > samsung,read-strobe-delay = <90>; > > pinctrl-names = "default"; > > - pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus1 &sd0_bus4 &sd0_bus8 &sd0_cd &sd0_rclk>; > > + pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_rdqs &sd0_bus1 &sd0_bus4 &sd0_bus8 &sd0_cd &sd0_rclk>; > > bus-width = <8>; > > cap-mmc-highspeed; > > mmc-hs200-1_8v; > > Best regards > -- > Marek Szyprowski, PhD > Samsung R&D Institute Poland > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: exynos: Add pin configuration for read strobe for Odroid XU3/XU4 eMMC @ 2019-02-22 10:33 ` Anand Moon 0 siblings, 0 replies; 6+ messages in thread From: Anand Moon @ 2019-02-22 10:33 UTC (permalink / raw) To: Marek Szyprowski Cc: devicetree, linux-samsung-soc, Linux Kernel, Krzysztof Kozlowski, Rob Herring, linux-arm-kernel Hi Marek, On Fri, 22 Feb 2019 at 15:59, Marek Szyprowski <m.szyprowski@samsung.com> wrote: > > Hi Anand, > > On 2019-02-22 11:19, Anand Moon wrote: > > Add Read Strobe RDQS pin configuration for eMMC to support higher data rate read/write. > > > > Signed-off-by: Anand Moon <linux.amoon@gmail.com> > > --- > > arch/arm/boot/dts/exynos5420-pinctrl.dtsi | 6 ++++++ > > arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 2 +- > > 2 files changed, 7 insertions(+), 1 deletion(-) > > > > diff --git a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi > > index b82af7c89654..4fb3865e082a 100644 > > --- a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi > > +++ b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi > > @@ -206,6 +206,12 @@ > > samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV4>; > > }; > > > > + sd0_rdqs: sd0-rdqs { > > + samsung,pins = "gpc0-7"; > > + samsung,pin-function = <EXYNOS_PIN_FUNC_2>; > > + samsung,pin-pud = <EXYNOS_PIN_PULL_DOWN>; > > + }; > > + > > The above lines are not needed. There is already a sd0_rclk node with > exactly the same configuration just above your change. > Sorry once again, I failed to look closely., sorry for the noise. Best Regards -Anand > > sd1_clk: sd1-clk { > > samsung,pins = "gpc1-0"; > > samsung,pin-function = <EXYNOS_PIN_FUNC_2>; > > diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi > > index b299e541cac0..d41397748ed2 100644 > > --- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi > > +++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi > > @@ -411,7 +411,7 @@ > > samsung,dw-mshc-hs400-timing = <0 2>; > > samsung,read-strobe-delay = <90>; > > pinctrl-names = "default"; > > - pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus1 &sd0_bus4 &sd0_bus8 &sd0_cd &sd0_rclk>; > > + pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_rdqs &sd0_bus1 &sd0_bus4 &sd0_bus8 &sd0_cd &sd0_rclk>; > > bus-width = <8>; > > cap-mmc-highspeed; > > mmc-hs200-1_8v; > > Best regards > -- > Marek Szyprowski, PhD > Samsung R&D Institute Poland > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-02-22 10:33 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20190222102034epcas3p373245ed6e3e83e297bcaff48aec37992@epcas3p3.samsung.com>
2019-02-22 10:19 ` [PATCH] ARM: dts: exynos: Add pin configuration for read strobe for Odroid XU3/XU4 eMMC Anand Moon
2019-02-22 10:19 ` Anand Moon
2019-02-22 10:29 ` Marek Szyprowski
2019-02-22 10:29 ` Marek Szyprowski
2019-02-22 10:33 ` Anand Moon
2019-02-22 10:33 ` Anand Moon
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.