From: Rob Herring <robh@kernel.org>
To: Martin Kepplinger <martin.kepplinger@ginzinger.com>
Cc: gregkh@linuxfoundation.org, mark.rutland@arm.com,
jslaby@suse.com, corbet@lwn.net, richard.genoud@gmail.com,
nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com,
ludovic.desroches@microchip.com, mcoquelin.stm32@gmail.com,
alexandre.torgue@st.com, linux-serial@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/9] serial: core: add rs485-rts-delay-us devicetree property for RS485
Date: Fri, 22 Feb 2019 17:44:29 -0600 [thread overview]
Message-ID: <20190222234429.GA19985@bogus> (raw)
In-Reply-To: <20190221171758.10322-3-martin.kepplinger@ginzinger.com>
On Thu, Feb 21, 2019 at 06:17:52PM +0100, Martin Kepplinger wrote:
> struct serial_rs485 now optionally holds the rts delay values in
> microseconds. Users can set these delays in their devicetree descriptions,
> so this adds the microseconds-option with the "rs485-rts-delay-us" boolean
> property.
If it has a value, it's not boolean.
Should the old prop be deprecated?
>
> Signed-off-by: Martin Kepplinger <martin.kepplinger@ginzinger.com>
> ---
> Documentation/devicetree/bindings/serial/rs485.txt | 1 +
> drivers/tty/serial/serial_core.c | 11 +++++++++++
> 2 files changed, 12 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/serial/rs485.txt b/Documentation/devicetree/bindings/serial/rs485.txt
> index b92592dff6dd..77396c62b383 100644
> --- a/Documentation/devicetree/bindings/serial/rs485.txt
> +++ b/Documentation/devicetree/bindings/serial/rs485.txt
> @@ -12,6 +12,7 @@ Optional properties:
> * b is the delay between end of data sent and rts signal in milliseconds
> it corresponds to the delay after sending data and actual release of the line.
> If this property is not specified, <0 0> is assumed.
> +- rs485-rts-delay-us: the same as rs485-rts-delay, but in microseconds.
> - rs485-rts-active-low: drive RTS low when sending (default is high).
> - linux,rs485-enabled-at-boot-time: empty property telling to enable the rs485
> feature at boot time. It can be disabled later with proper ioctl.
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Martin Kepplinger <martin.kepplinger@ginzinger.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
alexandre.belloni@bootlin.com, alexandre.torgue@st.com,
corbet@lwn.net, richard.genoud@gmail.com,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
ludovic.desroches@microchip.com, mcoquelin.stm32@gmail.com,
jslaby@suse.com, linux-serial@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 3/9] serial: core: add rs485-rts-delay-us devicetree property for RS485
Date: Fri, 22 Feb 2019 17:44:29 -0600 [thread overview]
Message-ID: <20190222234429.GA19985@bogus> (raw)
In-Reply-To: <20190221171758.10322-3-martin.kepplinger@ginzinger.com>
On Thu, Feb 21, 2019 at 06:17:52PM +0100, Martin Kepplinger wrote:
> struct serial_rs485 now optionally holds the rts delay values in
> microseconds. Users can set these delays in their devicetree descriptions,
> so this adds the microseconds-option with the "rs485-rts-delay-us" boolean
> property.
If it has a value, it's not boolean.
Should the old prop be deprecated?
>
> Signed-off-by: Martin Kepplinger <martin.kepplinger@ginzinger.com>
> ---
> Documentation/devicetree/bindings/serial/rs485.txt | 1 +
> drivers/tty/serial/serial_core.c | 11 +++++++++++
> 2 files changed, 12 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/serial/rs485.txt b/Documentation/devicetree/bindings/serial/rs485.txt
> index b92592dff6dd..77396c62b383 100644
> --- a/Documentation/devicetree/bindings/serial/rs485.txt
> +++ b/Documentation/devicetree/bindings/serial/rs485.txt
> @@ -12,6 +12,7 @@ Optional properties:
> * b is the delay between end of data sent and rts signal in milliseconds
> it corresponds to the delay after sending data and actual release of the line.
> If this property is not specified, <0 0> is assumed.
> +- rs485-rts-delay-us: the same as rs485-rts-delay, but in microseconds.
> - rs485-rts-active-low: drive RTS low when sending (default is high).
> - linux,rs485-enabled-at-boot-time: empty property telling to enable the rs485
> feature at boot time. It can be disabled later with proper ioctl.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-02-22 23:44 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-21 17:17 [PATCH v2 1/9] serial: uapi: add SER_RS485_DELAY_IN_USEC flag to struct serial_rs485 Martin Kepplinger
2019-02-21 17:17 ` Martin Kepplinger
2019-02-21 17:17 ` Martin Kepplinger
2019-02-21 17:17 ` [PATCH v2 2/9] Documentation: serial-rs485: document SER_RS485_DELAY_IN_USEC flag Martin Kepplinger
2019-02-21 17:17 ` Martin Kepplinger
2019-02-21 17:17 ` Martin Kepplinger
2019-02-21 17:17 ` [PATCH v2 3/9] serial: core: add rs485-rts-delay-us devicetree property for RS485 Martin Kepplinger
2019-02-21 17:17 ` Martin Kepplinger
2019-02-21 17:17 ` Martin Kepplinger
2019-02-22 23:44 ` Rob Herring [this message]
2019-02-22 23:44 ` Rob Herring
2019-02-21 17:17 ` [PATCH v2 4/9] serial: 8250: add support for rs485 RTS delays in microseconds Martin Kepplinger
2019-02-21 17:17 ` Martin Kepplinger
2019-02-21 17:17 ` Martin Kepplinger
2019-03-29 14:36 ` Ahmad Fatoum
2019-03-29 14:36 ` Ahmad Fatoum
2019-02-21 17:17 ` [PATCH v2 5/9] serial: omap-serial: " Martin Kepplinger
2019-02-21 17:17 ` Martin Kepplinger
2019-02-21 17:17 ` Martin Kepplinger
2019-02-21 17:17 ` [PATCH v2 6/9] serial: sc16is7xx: " Martin Kepplinger
2019-02-21 17:17 ` Martin Kepplinger
2019-02-21 17:17 ` Martin Kepplinger
2019-02-21 17:17 ` [PATCH v2 7/9] serial: atmel_serial: set SER_RS485_DELAY_IN_USEC accordingly Martin Kepplinger
2019-02-21 17:17 ` Martin Kepplinger
2019-02-21 17:17 ` Martin Kepplinger
2019-02-21 17:17 ` [PATCH v2 8/9] serial: fsl_lpuart: " Martin Kepplinger
2019-02-21 17:17 ` Martin Kepplinger
2019-02-21 17:17 ` Martin Kepplinger
2019-02-21 17:17 ` [PATCH v2 9/9] serial: st32-usart: " Martin Kepplinger
2019-02-21 17:17 ` Martin Kepplinger
2019-02-21 17:17 ` Martin Kepplinger
2019-03-08 7:36 ` [PATCH v2 1/9] serial: uapi: add SER_RS485_DELAY_IN_USEC flag to struct serial_rs485 Martin Kepplinger
2019-03-08 7:36 ` Martin Kepplinger
2019-03-08 7:36 ` Martin Kepplinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190222234429.GA19985@bogus \
--to=robh@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandre.torgue@st.com \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=ludovic.desroches@microchip.com \
--cc=mark.rutland@arm.com \
--cc=martin.kepplinger@ginzinger.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=nicolas.ferre@microchip.com \
--cc=richard.genoud@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.