* [PATCH] staging: netlogic: Add SPDX-License-Identifier tag @ 2019-02-23 6:24 Bhagyashri Dighole 2019-02-23 7:20 ` [Outreachy kernel] " Julia Lawall 0 siblings, 1 reply; 6+ messages in thread From: Bhagyashri Dighole @ 2019-02-23 6:24 UTC (permalink / raw) To: Greg Kroah-Hartman; +Cc: Outreachy Adds the SPDX GPL-2.0 or BSD-2-clause license identifier, which solves the checkpatch.pl warning: "WARNING: Missing or malformed SPDX-License-Identifier tag in line 1". Signed-off-by: Bhagyashri Dighole <digholebhagyashri@gmail.com> --- drivers/staging/netlogic/platform_net.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/netlogic/platform_net.c b/drivers/staging/netlogic/platform_net.c index abf4c71..2637fb1 100644 --- a/drivers/staging/netlogic/platform_net.c +++ b/drivers/staging/netlogic/platform_net.c @@ -1,3 +1,4 @@ +// SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) /* * Copyright (c) 2003-2012 Broadcom Corporation * All Rights Reserved -- 2.7.4 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: netlogic: Add SPDX-License-Identifier tag 2019-02-23 6:24 [PATCH] staging: netlogic: Add SPDX-License-Identifier tag Bhagyashri Dighole @ 2019-02-23 7:20 ` Julia Lawall 2019-02-23 7:53 ` Bhagyashri Dighole 2019-02-23 7:54 ` Greg Kroah-Hartman 0 siblings, 2 replies; 6+ messages in thread From: Julia Lawall @ 2019-02-23 7:20 UTC (permalink / raw) To: Bhagyashri Dighole; +Cc: Greg Kroah-Hartman, Outreachy On Sat, 23 Feb 2019, Bhagyashri Dighole wrote: > Adds the SPDX GPL-2.0 or BSD-2-clause license identifier, which solves the Where do you get the BSD-2-clause thing from? It seems that Broadcom has made their own license. julia > checkpatch.pl warning: > "WARNING: Missing or malformed SPDX-License-Identifier tag in line 1". > > Signed-off-by: Bhagyashri Dighole <digholebhagyashri@gmail.com> > --- > drivers/staging/netlogic/platform_net.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/netlogic/platform_net.c b/drivers/staging/netlogic/platform_net.c > index abf4c71..2637fb1 100644 > --- a/drivers/staging/netlogic/platform_net.c > +++ b/drivers/staging/netlogic/platform_net.c > @@ -1,3 +1,4 @@ > +// SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > /* > * Copyright (c) 2003-2012 Broadcom Corporation > * All Rights Reserved > -- > 2.7.4 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190223062455.GA11432%40bhagyashri-Lenovo-G570. > For more options, visit https://groups.google.com/d/optout. > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: netlogic: Add SPDX-License-Identifier tag 2019-02-23 7:20 ` [Outreachy kernel] " Julia Lawall @ 2019-02-23 7:53 ` Bhagyashri Dighole 2019-02-23 8:26 ` Julia Lawall 2019-02-23 7:54 ` Greg Kroah-Hartman 1 sibling, 1 reply; 6+ messages in thread From: Bhagyashri Dighole @ 2019-02-23 7:53 UTC (permalink / raw) To: Julia Lawall; +Cc: Greg Kroah-Hartman, Outreachy [-- Attachment #1: Type: text/plain, Size: 1977 bytes --] Hi Julia, I get "BSD-2-Clause" from the LICENSE directory under the kernels project. There are licenses with short identifiers. I checked BSD-2-Clause license conditions and found that there are 2 condition which exactly matches with the license context in the "platform_net.h" file. That's how I get to know which SPDX short identifiers should be used. Correct me if I am wrong. -- Bhagyashri Dighole On Sat, Feb 23, 2019 at 12:50 PM Julia Lawall <julia.lawall@lip6.fr> wrote: > > > On Sat, 23 Feb 2019, Bhagyashri Dighole wrote: > > > Adds the SPDX GPL-2.0 or BSD-2-clause license identifier, which solves > the > > Where do you get the BSD-2-clause thing from? It seems that Broadcom has > made their own license. > > julia > > > checkpatch.pl warning: > > "WARNING: Missing or malformed SPDX-License-Identifier tag in line 1". > > > > Signed-off-by: Bhagyashri Dighole <digholebhagyashri@gmail.com> > > --- > > drivers/staging/netlogic/platform_net.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/staging/netlogic/platform_net.c > b/drivers/staging/netlogic/platform_net.c > > index abf4c71..2637fb1 100644 > > --- a/drivers/staging/netlogic/platform_net.c > > +++ b/drivers/staging/netlogic/platform_net.c > > @@ -1,3 +1,4 @@ > > +// SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > /* > > * Copyright (c) 2003-2012 Broadcom Corporation > > * All Rights Reserved > > -- > > 2.7.4 > > > > -- > > You received this message because you are subscribed to the Google > Groups "outreachy-kernel" group. > > To unsubscribe from this group and stop receiving emails from it, send > an email to outreachy-kernel+unsubscribe@googlegroups.com. > > To post to this group, send email to outreachy-kernel@googlegroups.com. > > To view this discussion on the web visit > https://groups.google.com/d/msgid/outreachy-kernel/20190223062455.GA11432%40bhagyashri-Lenovo-G570 > . > > For more options, visit https://groups.google.com/d/optout. > > > [-- Attachment #2: Type: text/html, Size: 3062 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: netlogic: Add SPDX-License-Identifier tag 2019-02-23 7:53 ` Bhagyashri Dighole @ 2019-02-23 8:26 ` Julia Lawall 0 siblings, 0 replies; 6+ messages in thread From: Julia Lawall @ 2019-02-23 8:26 UTC (permalink / raw) To: Bhagyashri Dighole; +Cc: Greg Kroah-Hartman, Outreachy [-- Attachment #1: Type: text/plain, Size: 2399 bytes --] On Sat, 23 Feb 2019, Bhagyashri Dighole wrote: > Hi Julia, > > I get "BSD-2-Clause" from the LICENSE directory under the kernels project. > There are licenses with short identifiers. I checked BSD-2-Clause license > conditions and found that there are 2 condition which exactly matches with > the license context in the "platform_net.h" file. That's how I get to know > which SPDX short identifiers should be used. Correct me if I am wrong. Ah, no, like Greg said, it sounds perfect. Thanks for the explanation :) julia > > -- > Bhagyashri Dighole > > On Sat, Feb 23, 2019 at 12:50 PM Julia Lawall <julia.lawall@lip6.fr> wrote: > > > On Sat, 23 Feb 2019, Bhagyashri Dighole wrote: > > > Adds the SPDX GPL-2.0 or BSD-2-clause license identifier, > which solves the > > Where do you get the BSD-2-clause thing from? It seems that > Broadcom has > made their own license. > > julia > > > checkpatch.pl warning: > > "WARNING: Missing or malformed SPDX-License-Identifier tag in > line 1". > > > > Signed-off-by: Bhagyashri Dighole > <digholebhagyashri@gmail.com> > > --- > > drivers/staging/netlogic/platform_net.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/staging/netlogic/platform_net.c > b/drivers/staging/netlogic/platform_net.c > > index abf4c71..2637fb1 100644 > > --- a/drivers/staging/netlogic/platform_net.c > > +++ b/drivers/staging/netlogic/platform_net.c > > @@ -1,3 +1,4 @@ > > +// SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > /* > > * Copyright (c) 2003-2012 Broadcom Corporation > > * All Rights Reserved > > -- > > 2.7.4 > > > > -- > > You received this message because you are subscribed to the > Google Groups "outreachy-kernel" group. > > To unsubscribe from this group and stop receiving emails from > it, send an email to > outreachy-kernel+unsubscribe@googlegroups.com. > > To post to this group, send email to > outreachy-kernel@googlegroups.com. > > To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/20190223062455.GA11432%4 > 0bhagyashri-Lenovo-G570. > > For more options, visit https://groups.google.com/d/optout. > > > > > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: netlogic: Add SPDX-License-Identifier tag 2019-02-23 7:20 ` [Outreachy kernel] " Julia Lawall 2019-02-23 7:53 ` Bhagyashri Dighole @ 2019-02-23 7:54 ` Greg Kroah-Hartman 2019-02-23 8:03 ` Bhagyashri Dighole 1 sibling, 1 reply; 6+ messages in thread From: Greg Kroah-Hartman @ 2019-02-23 7:54 UTC (permalink / raw) To: Julia Lawall, Bhagyashri Dighole, Outreachy On Sat, Feb 23, 2019 at 08:20:27AM +0100, Julia Lawall wrote: > > > On Sat, 23 Feb 2019, Bhagyashri Dighole wrote: > > > Adds the SPDX GPL-2.0 or BSD-2-clause license identifier, which solves the > > Where do you get the BSD-2-clause thing from? It seems that Broadcom has > made their own license. No, it really does look like BSD-2, so this looks correct. Bhagyashri, nice work! But, I would like to see this happen for all of the files for this driver at the same time, and then send a patch that removes the boiler-plate license text, so we just end up with the copyright lines and the SPDX lines at the top of the files. Can you redo this patch as a patch series that does that please? thanks, greg k-h ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: netlogic: Add SPDX-License-Identifier tag 2019-02-23 7:54 ` Greg Kroah-Hartman @ 2019-02-23 8:03 ` Bhagyashri Dighole 0 siblings, 0 replies; 6+ messages in thread From: Bhagyashri Dighole @ 2019-02-23 8:03 UTC (permalink / raw) To: Greg Kroah-Hartman; +Cc: Julia Lawall, Outreachy [-- Attachment #1: Type: text/plain, Size: 901 bytes --] Thanks Greg. Sure, I will do that. -- Bhagyashri On Sat, Feb 23, 2019 at 1:24 PM Greg Kroah-Hartman < gregkh@linuxfoundation.org> wrote: > On Sat, Feb 23, 2019 at 08:20:27AM +0100, Julia Lawall wrote: > > > > > > On Sat, 23 Feb 2019, Bhagyashri Dighole wrote: > > > > > Adds the SPDX GPL-2.0 or BSD-2-clause license identifier, which solves > the > > > > Where do you get the BSD-2-clause thing from? It seems that Broadcom has > > made their own license. > > No, it really does look like BSD-2, so this looks correct. Bhagyashri, > nice work! > > But, I would like to see this happen for all of the files for this > driver at the same time, and then send a patch that removes the > boiler-plate license text, so we just end up with the copyright lines > and the SPDX lines at the top of the files. > > Can you redo this patch as a patch series that does that please? > > thanks, > > greg k-h > [-- Attachment #2: Type: text/html, Size: 1314 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-02-23 8:27 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-02-23 6:24 [PATCH] staging: netlogic: Add SPDX-License-Identifier tag Bhagyashri Dighole 2019-02-23 7:20 ` [Outreachy kernel] " Julia Lawall 2019-02-23 7:53 ` Bhagyashri Dighole 2019-02-23 8:26 ` Julia Lawall 2019-02-23 7:54 ` Greg Kroah-Hartman 2019-02-23 8:03 ` Bhagyashri Dighole
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.