* [PATCH V5 1/2] i2c: tegra: remove master fifo support on tegra186
@ 2019-02-19 17:28 ` Sowjanya Komatineni
0 siblings, 0 replies; 6+ messages in thread
From: Sowjanya Komatineni @ 2019-02-19 17:28 UTC (permalink / raw)
To: thierry.reding, jonathanh, talho, skomatineni
Cc: wsa, linux-tegra, linux-kernel, linux-i2c
Tegra186 does not have master FIFO control register and instead
uses FIFO control register like prior Tegra chipset.
This patch fixes this and prevents crashing during boot when
accessing FIFO control registers.
Acked-by: Thierry Reding <treding@nvidia.com>
Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
---
drivers/i2c/busses/i2c-tegra.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c
index a4cd79c9f7a7..e6851904acc1 100644
--- a/drivers/i2c/busses/i2c-tegra.c
+++ b/drivers/i2c/busses/i2c-tegra.c
@@ -1436,7 +1436,7 @@ static const struct tegra_i2c_hw_feature tegra186_i2c_hw = {
.has_config_load_reg = true,
.has_multi_master_mode = true,
.has_slcg_override_reg = true,
- .has_mst_fifo = true,
+ .has_mst_fifo = false,
.quirks = &tegra_i2c_quirks,
.supports_bus_clear = true,
.has_apb_dma = false,
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH V5 1/2] i2c: tegra: remove master fifo support on tegra186
@ 2019-02-19 17:28 ` Sowjanya Komatineni
0 siblings, 0 replies; 6+ messages in thread
From: Sowjanya Komatineni @ 2019-02-19 17:28 UTC (permalink / raw)
To: thierry.reding, jonathanh, talho, skomatineni
Cc: wsa, linux-tegra, linux-kernel, linux-i2c
Tegra186 does not have master FIFO control register and instead
uses FIFO control register like prior Tegra chipset.
This patch fixes this and prevents crashing during boot when
accessing FIFO control registers.
Acked-by: Thierry Reding <treding@nvidia.com>
Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
---
drivers/i2c/busses/i2c-tegra.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c
index a4cd79c9f7a7..e6851904acc1 100644
--- a/drivers/i2c/busses/i2c-tegra.c
+++ b/drivers/i2c/busses/i2c-tegra.c
@@ -1436,7 +1436,7 @@ static const struct tegra_i2c_hw_feature tegra186_i2c_hw = {
.has_config_load_reg = true,
.has_multi_master_mode = true,
.has_slcg_override_reg = true,
- .has_mst_fifo = true,
+ .has_mst_fifo = false,
.quirks = &tegra_i2c_quirks,
.supports_bus_clear = true,
.has_apb_dma = false,
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH V5 2/2] i2c: tegra: remove multi-master support
2019-02-19 17:28 ` Sowjanya Komatineni
@ 2019-02-19 17:28 ` Sowjanya Komatineni
-1 siblings, 0 replies; 6+ messages in thread
From: Sowjanya Komatineni @ 2019-02-19 17:28 UTC (permalink / raw)
To: thierry.reding, jonathanh, talho, skomatineni
Cc: wsa, linux-tegra, linux-kernel, linux-i2c
Multi-master support is defeatured on Tegra210 and Tegra186 due to
known bugs.
This patch removes multi-master support for Tegra210 and Tegra186
I2C HW feature.
Acked-by: Thierry Reding <treding@nvidia.com>
Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
---
drivers/i2c/busses/i2c-tegra.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c
index e6851904acc1..26f686bc3491 100644
--- a/drivers/i2c/busses/i2c-tegra.c
+++ b/drivers/i2c/busses/i2c-tegra.c
@@ -1409,7 +1409,7 @@ static const struct tegra_i2c_hw_feature tegra210_i2c_hw = {
.clk_divisor_fast_mode = 0x19,
.clk_divisor_fast_plus_mode = 0x10,
.has_config_load_reg = true,
- .has_multi_master_mode = true,
+ .has_multi_master_mode = false,
.has_slcg_override_reg = true,
.has_mst_fifo = false,
.quirks = &tegra_i2c_quirks,
@@ -1434,7 +1434,7 @@ static const struct tegra_i2c_hw_feature tegra186_i2c_hw = {
.clk_divisor_fast_mode = 0x19,
.clk_divisor_fast_plus_mode = 0x10,
.has_config_load_reg = true,
- .has_multi_master_mode = true,
+ .has_multi_master_mode = false,
.has_slcg_override_reg = true,
.has_mst_fifo = false,
.quirks = &tegra_i2c_quirks,
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH V5 2/2] i2c: tegra: remove multi-master support
@ 2019-02-19 17:28 ` Sowjanya Komatineni
0 siblings, 0 replies; 6+ messages in thread
From: Sowjanya Komatineni @ 2019-02-19 17:28 UTC (permalink / raw)
To: thierry.reding, jonathanh, talho, skomatineni
Cc: wsa, linux-tegra, linux-kernel, linux-i2c
Multi-master support is defeatured on Tegra210 and Tegra186 due to
known bugs.
This patch removes multi-master support for Tegra210 and Tegra186
I2C HW feature.
Acked-by: Thierry Reding <treding@nvidia.com>
Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
---
drivers/i2c/busses/i2c-tegra.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c
index e6851904acc1..26f686bc3491 100644
--- a/drivers/i2c/busses/i2c-tegra.c
+++ b/drivers/i2c/busses/i2c-tegra.c
@@ -1409,7 +1409,7 @@ static const struct tegra_i2c_hw_feature tegra210_i2c_hw = {
.clk_divisor_fast_mode = 0x19,
.clk_divisor_fast_plus_mode = 0x10,
.has_config_load_reg = true,
- .has_multi_master_mode = true,
+ .has_multi_master_mode = false,
.has_slcg_override_reg = true,
.has_mst_fifo = false,
.quirks = &tegra_i2c_quirks,
@@ -1434,7 +1434,7 @@ static const struct tegra_i2c_hw_feature tegra186_i2c_hw = {
.clk_divisor_fast_mode = 0x19,
.clk_divisor_fast_plus_mode = 0x10,
.has_config_load_reg = true,
- .has_multi_master_mode = true,
+ .has_multi_master_mode = false,
.has_slcg_override_reg = true,
.has_mst_fifo = false,
.quirks = &tegra_i2c_quirks,
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH V5 2/2] i2c: tegra: remove multi-master support
2019-02-19 17:28 ` Sowjanya Komatineni
(?)
@ 2019-02-23 9:29 ` Wolfram Sang
-1 siblings, 0 replies; 6+ messages in thread
From: Wolfram Sang @ 2019-02-23 9:29 UTC (permalink / raw)
To: Sowjanya Komatineni
Cc: thierry.reding, jonathanh, talho, linux-tegra, linux-kernel,
linux-i2c
[-- Attachment #1: Type: text/plain, Size: 397 bytes --]
On Tue, Feb 19, 2019 at 09:28:52AM -0800, Sowjanya Komatineni wrote:
> Multi-master support is defeatured on Tegra210 and Tegra186 due to
> known bugs.
>
> This patch removes multi-master support for Tegra210 and Tegra186
> I2C HW feature.
>
> Acked-by: Thierry Reding <treding@nvidia.com>
> Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH V5 1/2] i2c: tegra: remove master fifo support on tegra186
2019-02-19 17:28 ` Sowjanya Komatineni
(?)
(?)
@ 2019-02-23 9:29 ` Wolfram Sang
-1 siblings, 0 replies; 6+ messages in thread
From: Wolfram Sang @ 2019-02-23 9:29 UTC (permalink / raw)
To: Sowjanya Komatineni
Cc: thierry.reding, jonathanh, talho, linux-tegra, linux-kernel,
linux-i2c
[-- Attachment #1: Type: text/plain, Size: 449 bytes --]
On Tue, Feb 19, 2019 at 09:28:51AM -0800, Sowjanya Komatineni wrote:
> Tegra186 does not have master FIFO control register and instead
> uses FIFO control register like prior Tegra chipset.
>
> This patch fixes this and prevents crashing during boot when
> accessing FIFO control registers.
>
> Acked-by: Thierry Reding <treding@nvidia.com>
> Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-02-23 9:29 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-19 17:28 [PATCH V5 1/2] i2c: tegra: remove master fifo support on tegra186 Sowjanya Komatineni
2019-02-19 17:28 ` Sowjanya Komatineni
2019-02-19 17:28 ` [PATCH V5 2/2] i2c: tegra: remove multi-master support Sowjanya Komatineni
2019-02-19 17:28 ` Sowjanya Komatineni
2019-02-23 9:29 ` Wolfram Sang
2019-02-23 9:29 ` [PATCH V5 1/2] i2c: tegra: remove master fifo support on tegra186 Wolfram Sang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.