From: Andrew Lunn <andrew@lunn.ch>
To: xiaofeis@codeaurora.org
Cc: Vinod Koul <vkoul@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
linux-arm-msm@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Niklas Cassel <niklas.cassel@linaro.org>,
netdev@vger.kernel.org
Subject: Re: [PATCH] net: dsa: Inherit dev addr from master
Date: Mon, 25 Feb 2019 14:21:07 +0100 [thread overview]
Message-ID: <20190225132107.GG20855@lunn.ch> (raw)
In-Reply-To: <441ae81a814498876e4cfed6fd5b7bcb@codeaurora.org>
> I think we can remove the first inherit, but if keep it, we can see
> consistent address output by ifconfig -a before open master and slave
> interface.
True
But it also means we see inconsistent MAC addresses on the master. The
MAC address changes on open.
Maybe it would be better to change your master so it sets its MAC
address during probe? Everything is then consistent all the time.
Andrew
next prev parent reply other threads:[~2019-02-25 13:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-22 12:56 [PATCH] net: dsa: Inherit dev addr from master Vinod Koul
2019-02-22 14:30 ` Andrew Lunn
2019-02-25 13:13 ` xiaofeis
2019-02-25 13:21 ` Andrew Lunn [this message]
2019-03-27 4:09 ` xiaofeis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190225132107.GG20855@lunn.ch \
--to=andrew@lunn.ch \
--cc=bjorn.andersson@linaro.org \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=niklas.cassel@linaro.org \
--cc=vivien.didelot@gmail.com \
--cc=vkoul@kernel.org \
--cc=xiaofeis@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.