Re: [PATCH] Staging: vt6655: Fix check - Lines should not end with a '('

[Greg KH <gregkh@linuxfoundation.org>]

On Mon, Feb 25, 2019 at 12:02:35PM -0600, Madhumitha Prabakaran wrote:
> Improve readibility
> 
> Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
> ---
>  drivers/staging/vt6655/card.c | 11 +++++------
>  1 file changed, 5 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
> index 5dedc7aad384..6042f0bcd3f8 100644
> --- a/drivers/staging/vt6655/card.c
> +++ b/drivers/staging/vt6655/card.c
> @@ -62,12 +62,11 @@ static const unsigned short cwRXBCNTSFOff[MAX_RATE] = {
>  
>  static
>  void
> -s_vCalculateOFDMRParameter(
> -	unsigned char byRate,
> -	u8 bb_type,
> -	unsigned char *pbyTxRate,
> -	unsigned char *pbyRsvTime
> -);
> +s_vCalculateOFDMRParameter
> +	(unsigned char byRate,
> +	 u8 bb_type,
> +	 unsigned char *pbyTxRate,
> +	 unsigned char *pbyRsvTime);

There's so much wrong with these few lines to start with, you can make
this look a lot better all at once.

How about this change instead:

static void s_vCalculateOFDMRParameter(unsigned char byRate, u8 bb_type,
				       unsigned char *pbyTxRate,
				       unsigned char *pbyRsvTime);

Isn't that much more readable over the initial, and even your change?

thanks,

greg k-h