* [PATCH] Staging: vt6655: Fix check - Lines should not end with a '('
@ 2019-02-25 18:02 Madhumitha Prabakaran
2019-02-26 10:44 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Madhumitha Prabakaran @ 2019-02-25 18:02 UTC (permalink / raw)
To: forest, gregkh, outreachy-kernel; +Cc: Madhumitha Prabakaran
Improve readibility
Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
---
drivers/staging/vt6655/card.c | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
index 5dedc7aad384..6042f0bcd3f8 100644
--- a/drivers/staging/vt6655/card.c
+++ b/drivers/staging/vt6655/card.c
@@ -62,12 +62,11 @@ static const unsigned short cwRXBCNTSFOff[MAX_RATE] = {
static
void
-s_vCalculateOFDMRParameter(
- unsigned char byRate,
- u8 bb_type,
- unsigned char *pbyTxRate,
- unsigned char *pbyRsvTime
-);
+s_vCalculateOFDMRParameter
+ (unsigned char byRate,
+ u8 bb_type,
+ unsigned char *pbyTxRate,
+ unsigned char *pbyRsvTime);
/*--------------------- Export Functions --------------------------*/
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] Staging: vt6655: Fix check - Lines should not end with a '('
2019-02-25 18:02 [PATCH] Staging: vt6655: Fix check - Lines should not end with a '(' Madhumitha Prabakaran
@ 2019-02-26 10:44 ` Greg KH
2019-02-26 12:40 ` Madhumthia Prabakaran
0 siblings, 1 reply; 4+ messages in thread
From: Greg KH @ 2019-02-26 10:44 UTC (permalink / raw)
To: Madhumitha Prabakaran; +Cc: forest, outreachy-kernel
On Mon, Feb 25, 2019 at 12:02:35PM -0600, Madhumitha Prabakaran wrote:
> Improve readibility
>
> Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
> ---
> drivers/staging/vt6655/card.c | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
> index 5dedc7aad384..6042f0bcd3f8 100644
> --- a/drivers/staging/vt6655/card.c
> +++ b/drivers/staging/vt6655/card.c
> @@ -62,12 +62,11 @@ static const unsigned short cwRXBCNTSFOff[MAX_RATE] = {
>
> static
> void
> -s_vCalculateOFDMRParameter(
> - unsigned char byRate,
> - u8 bb_type,
> - unsigned char *pbyTxRate,
> - unsigned char *pbyRsvTime
> -);
> +s_vCalculateOFDMRParameter
> + (unsigned char byRate,
> + u8 bb_type,
> + unsigned char *pbyTxRate,
> + unsigned char *pbyRsvTime);
There's so much wrong with these few lines to start with, you can make
this look a lot better all at once.
How about this change instead:
static void s_vCalculateOFDMRParameter(unsigned char byRate, u8 bb_type,
unsigned char *pbyTxRate,
unsigned char *pbyRsvTime);
Isn't that much more readable over the initial, and even your change?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] Staging: vt6655: Fix check - Lines should not end with a '('
2019-02-26 10:44 ` Greg KH
@ 2019-02-26 12:40 ` Madhumthia Prabakaran
0 siblings, 0 replies; 4+ messages in thread
From: Madhumthia Prabakaran @ 2019-02-26 12:40 UTC (permalink / raw)
To: Greg KH, outreachy-kernel
On Tue, Feb 26, 2019 at 11:44:29AM +0100, Greg KH wrote:
> On Mon, Feb 25, 2019 at 12:02:35PM -0600, Madhumitha Prabakaran wrote:
> > Improve readibility
> >
> > Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
> > ---
> > drivers/staging/vt6655/card.c | 11 +++++------
> > 1 file changed, 5 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
> > index 5dedc7aad384..6042f0bcd3f8 100644
> > --- a/drivers/staging/vt6655/card.c
> > +++ b/drivers/staging/vt6655/card.c
> > @@ -62,12 +62,11 @@ static const unsigned short cwRXBCNTSFOff[MAX_RATE] = {
> >
> > static
> > void
> > -s_vCalculateOFDMRParameter(
> > - unsigned char byRate,
> > - u8 bb_type,
> > - unsigned char *pbyTxRate,
> > - unsigned char *pbyRsvTime
> > -);
> > +s_vCalculateOFDMRParameter
> > + (unsigned char byRate,
> > + u8 bb_type,
> > + unsigned char *pbyTxRate,
> > + unsigned char *pbyRsvTime);
>
> There's so much wrong with these few lines to start with, you can make
> this look a lot better all at once.
>
> How about this change instead:
>
> static void s_vCalculateOFDMRParameter(unsigned char byRate, u8 bb_type,
> unsigned char *pbyTxRate,
> unsigned char *pbyRsvTime);
>
> Isn't that much more readable over the initial, and even your change?
>
> thanks,
>
> greg k-h
I will update and send it
Madhumitha
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] Staging: vt6655: Fix check - Lines should not end with a '('
@ 2019-02-25 18:13 Madhumitha Prabakaran
0 siblings, 0 replies; 4+ messages in thread
From: Madhumitha Prabakaran @ 2019-02-25 18:13 UTC (permalink / raw)
To: forest, gregkh, outreachy-kernel; +Cc: Madhumitha Prabakaran
Improve readibility
Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
---
drivers/staging/vt6655/card.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
index 6042f0bcd3f8..278cdedabae2 100644
--- a/drivers/staging/vt6655/card.c
+++ b/drivers/staging/vt6655/card.c
@@ -503,10 +503,7 @@ bool CARDbRadioPowerOn(struct vnt_private *priv)
return bResult;
}
-void
-CARDvSafeResetTx(
- struct vnt_private *priv
-)
+void CARDvSafeResetTx(struct vnt_private *priv)
{
unsigned int uu;
struct vnt_tx_desc *pCurrTD;
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-02-26 12:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-25 18:02 [PATCH] Staging: vt6655: Fix check - Lines should not end with a '(' Madhumitha Prabakaran
2019-02-26 10:44 ` Greg KH
2019-02-26 12:40 ` Madhumthia Prabakaran
-- strict thread matches above, loose matches on Subject: below --
2019-02-25 18:13 Madhumitha Prabakaran
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.