From: Christoph Hellwig <hch@infradead.org>
To: Hannes Reinecke <hare@suse.de>
Cc: Sreekanth Reddy <sreekanth.reddy@broadcom.com>,
linux-scsi <linux-scsi@vger.kernel.org>,
Sathya Prakash <Sathya.Prakash@broadcom.com>,
Suganath Prabu Subramani <suganath-prabu.subramani@broadcom.com>,
stable@vger.kernel.org
Subject: Re: [PATCH v1] mpt3sas: Use driver scsi lookup to track outstanding IOs
Date: Tue, 26 Feb 2019 06:33:13 -0800 [thread overview]
Message-ID: <20190226143313.GA23865@infradead.org> (raw)
In-Reply-To: <0dfb09ca-8723-3a3c-a6a8-c643856c57e3@suse.de>
On Tue, Feb 26, 2019 at 02:49:30PM +0100, Hannes Reinecke wrote:
> Attached is a patch to demonstrate my approach.
> I am aware that it'll only be useful for latest upstream where the legacy
> I/O path has been dropped completely, so we wouldn't need to worry about it.
> For older releases indeed you would need to with something like your
> proposed patch, but for upstream I really would like to switch to
> blk_mq_tagset_busy() iter.
While this is better than the driver private tracking we really should
not have to iterate all outstanding command, because if we have any
there is a bug we need to fix in the higher layers instead of working
around it in the drivers.
next prev parent reply other threads:[~2019-02-26 14:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-21 12:11 [PATCH v1] mpt3sas: Use driver scsi lookup to track outstanding IOs Sreekanth Reddy
2019-02-21 12:11 ` Sreekanth Reddy
[not found] ` <20190222152433.CF1822086A@mail.kernel.org>
2019-02-25 5:12 ` Sreekanth Reddy
2019-02-25 19:08 ` Hannes Reinecke
2019-02-26 11:48 ` Sreekanth Reddy
2019-02-26 12:28 ` Hannes Reinecke
2019-02-26 13:12 ` Sreekanth Reddy
2019-02-26 13:49 ` Hannes Reinecke
2019-02-26 13:49 ` Hannes Reinecke
2019-02-26 14:33 ` Christoph Hellwig [this message]
2019-02-26 14:40 ` Martin K. Petersen
2019-02-26 14:53 ` Hannes Reinecke
2019-02-26 16:05 ` Kashyap Desai
2019-02-27 14:50 ` Martin K. Petersen
2019-02-28 13:25 ` Sreekanth Reddy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190226143313.GA23865@infradead.org \
--to=hch@infradead.org \
--cc=Sathya.Prakash@broadcom.com \
--cc=hare@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=sreekanth.reddy@broadcom.com \
--cc=stable@vger.kernel.org \
--cc=suganath-prabu.subramani@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.