From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Christoph Hellwig <hch@lst.de>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Sebastian Reichel <sre@kernel.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: Regression in Linux next with dma cma changes
Date: Tue, 26 Feb 2019 12:15:19 -0800 [thread overview]
Message-ID: <20190226201518.GA3205@Asurada-Nvidia.nvidia.com> (raw)
In-Reply-To: <20190226200155.GE39872@atomide.com>
On Tue, Feb 26, 2019 at 12:01:55PM -0800, Tony Lindgren wrote:
> Looks like commit d222e42e8816 ("dma-contiguous: do not allocate a
> single page from CMA area") caused a regression at least for
> omap dss where we now get the following error on init:
>
> omapdss_dispc 58001000.dispc:
> dispc_errata_i734_wa_init: dma_alloc_writecombine failed
>
> Any ideas what might be going wrong?
It's probably because the dma_alloc_from_contiguous() call in
this path doesn't rebound to allocate a normal single page.
And I guess we should have left the change within dma-direct.
Christoph, do you agree?
I am submitting a revert first.
WARNING: multiple messages have this Message-ID (diff)
From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Tony Lindgren <tony@atomide.com>
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Sebastian Reichel <sre@kernel.org>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
linux-omap@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
linux-arm-kernel@lists.infradead.org,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: Regression in Linux next with dma cma changes
Date: Tue, 26 Feb 2019 12:15:19 -0800 [thread overview]
Message-ID: <20190226201518.GA3205@Asurada-Nvidia.nvidia.com> (raw)
In-Reply-To: <20190226200155.GE39872@atomide.com>
On Tue, Feb 26, 2019 at 12:01:55PM -0800, Tony Lindgren wrote:
> Looks like commit d222e42e8816 ("dma-contiguous: do not allocate a
> single page from CMA area") caused a regression at least for
> omap dss where we now get the following error on init:
>
> omapdss_dispc 58001000.dispc:
> dispc_errata_i734_wa_init: dma_alloc_writecombine failed
>
> Any ideas what might be going wrong?
It's probably because the dma_alloc_from_contiguous() call in
this path doesn't rebound to allocate a normal single page.
And I guess we should have left the change within dma-direct.
Christoph, do you agree?
I am submitting a revert first.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-02-26 20:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-26 20:01 Regression in Linux next with dma cma changes Tony Lindgren
2019-02-26 20:01 ` Tony Lindgren
2019-02-26 20:15 ` Nicolin Chen [this message]
2019-02-26 20:15 ` Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190226201518.GA3205@Asurada-Nvidia.nvidia.com \
--to=nicoleotsuka@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hch@lst.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=sre@kernel.org \
--cc=tomi.valkeinen@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.