Re: [Outreachy kernel] [PATCH v3] Staging: vt6655: Alignment of function parameters

[Greg KH <gregkh@linuxfoundation.org>]

On Tue, Feb 26, 2019 at 02:01:50PM -0600, Madhumitha Prabakaran wrote:
> This patch align the function parameters to improve readibility.
> 
> Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
> 
> ---
> Changes in v2
> -Make a commit message imperative
> -Use multiple lines to improve readibility
> 
> Changes in v3
> -Commit message and subject line are modified
> -Alignment of function parameters
> ---
>  drivers/staging/vt6655/baseband.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/vt6655/baseband.c b/drivers/staging/vt6655/baseband.c
> index 35bbff807df9..e3fecd732c88 100644
> --- a/drivers/staging/vt6655/baseband.c
> +++ b/drivers/staging/vt6655/baseband.c
> @@ -1705,9 +1705,9 @@ static const unsigned short awcFrameTime[MAX_RATE] = {
>   *
>   */
>  unsigned int BBuGetFrameTime(unsigned char byPreambleType,
> -	unsigned char byPktType,
> -	unsigned int cbFrameLength,
> -	unsigned short wRate)
> +		unsigned char byPktType,
> +		unsigned int cbFrameLength,
> +		unsigned short wRate)

They should line up with the variable above it, so this should end up
looking like:
unsigned int BBuGetFrameTime(unsigned char byPreambleType,
			     unsigned char byPktType,
			     unsigned int cbFrameLength,
			     unsigned short wRate)

But, given that there is no need to put one variable per line, you can
shorten this and make it look like:

unsigned int BBuGetFrameTime(unsigned char byPreambleType,
			     unsigned char byPktType,
			     unsigned int cbFrameLength, unsigned short wRate)

thanks,

greg k-h