* [PATCH v3] Staging: vt6655: Alignment of function parameters
@ 2019-02-26 20:01 Madhumitha Prabakaran
2019-02-27 14:47 ` [Outreachy kernel] " Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Madhumitha Prabakaran @ 2019-02-26 20:01 UTC (permalink / raw)
To: forest, gregkh, outreachy-kernel; +Cc: Madhumitha Prabakaran
This patch align the function parameters to improve readibility.
Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
---
Changes in v2
-Make a commit message imperative
-Use multiple lines to improve readibility
Changes in v3
-Commit message and subject line are modified
-Alignment of function parameters
---
drivers/staging/vt6655/baseband.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/vt6655/baseband.c b/drivers/staging/vt6655/baseband.c
index 35bbff807df9..e3fecd732c88 100644
--- a/drivers/staging/vt6655/baseband.c
+++ b/drivers/staging/vt6655/baseband.c
@@ -1705,9 +1705,9 @@ static const unsigned short awcFrameTime[MAX_RATE] = {
*
*/
unsigned int BBuGetFrameTime(unsigned char byPreambleType,
- unsigned char byPktType,
- unsigned int cbFrameLength,
- unsigned short wRate)
+ unsigned char byPktType,
+ unsigned int cbFrameLength,
+ unsigned short wRate)
{
unsigned int uFrameTime;
unsigned int uPreamble;
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Outreachy kernel] [PATCH v3] Staging: vt6655: Alignment of function parameters
2019-02-26 20:01 [PATCH v3] Staging: vt6655: Alignment of function parameters Madhumitha Prabakaran
@ 2019-02-27 14:47 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2019-02-27 14:47 UTC (permalink / raw)
To: Madhumitha Prabakaran; +Cc: forest, outreachy-kernel
On Tue, Feb 26, 2019 at 02:01:50PM -0600, Madhumitha Prabakaran wrote:
> This patch align the function parameters to improve readibility.
>
> Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
>
> ---
> Changes in v2
> -Make a commit message imperative
> -Use multiple lines to improve readibility
>
> Changes in v3
> -Commit message and subject line are modified
> -Alignment of function parameters
> ---
> drivers/staging/vt6655/baseband.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/vt6655/baseband.c b/drivers/staging/vt6655/baseband.c
> index 35bbff807df9..e3fecd732c88 100644
> --- a/drivers/staging/vt6655/baseband.c
> +++ b/drivers/staging/vt6655/baseband.c
> @@ -1705,9 +1705,9 @@ static const unsigned short awcFrameTime[MAX_RATE] = {
> *
> */
> unsigned int BBuGetFrameTime(unsigned char byPreambleType,
> - unsigned char byPktType,
> - unsigned int cbFrameLength,
> - unsigned short wRate)
> + unsigned char byPktType,
> + unsigned int cbFrameLength,
> + unsigned short wRate)
They should line up with the variable above it, so this should end up
looking like:
unsigned int BBuGetFrameTime(unsigned char byPreambleType,
unsigned char byPktType,
unsigned int cbFrameLength,
unsigned short wRate)
But, given that there is no need to put one variable per line, you can
shorten this and make it look like:
unsigned int BBuGetFrameTime(unsigned char byPreambleType,
unsigned char byPktType,
unsigned int cbFrameLength, unsigned short wRate)
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-02-27 14:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-26 20:01 [PATCH v3] Staging: vt6655: Alignment of function parameters Madhumitha Prabakaran
2019-02-27 14:47 ` [Outreachy kernel] " Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.