[PATCH v3] Staging: vt6655: Alignment of function declaration

[PATCH v3] Staging: vt6655: Alignment of function declaration

[Madhumitha Prabakaran]

Align function arguments and function type to improve readability.

Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
---
Changes in v3-
-Included driver name in subject line

Changes in v2-
- Modified subject line and commit log
---
 drivers/staging/vt6655/card.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
index 2996bf614caa..8d0182f5725c 100644
--- a/drivers/staging/vt6655/card.c
+++ b/drivers/staging/vt6655/card.c
@@ -499,7 +499,7 @@ bool CARDbRadioPowerOn(struct vnt_private *priv)
 	return bResult;
 }
 
-void CARDvSafeResetTx(truct vnt_private *priv)
+void CARDvSafeResetTx(struct vnt_private *priv)
 {
 	unsigned int uu;
 	struct vnt_tx_desc *pCurrTD;
-- 
2.17.1

Re: [PATCH v3] Staging: vt6655: Alignment of function declaration

[Greg KH]

On Wed, Feb 27, 2019 at 10:12:27AM -0600, Madhumitha Prabakaran wrote:
> Align function arguments and function type to improve readability.
> 
> Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
> ---
> Changes in v3-
> -Included driver name in subject line
> 
> Changes in v2-
> - Modified subject line and commit log
> ---
>  drivers/staging/vt6655/card.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
> index 2996bf614caa..8d0182f5725c 100644
> --- a/drivers/staging/vt6655/card.c
> +++ b/drivers/staging/vt6655/card.c
> @@ -499,7 +499,7 @@ bool CARDbRadioPowerOn(struct vnt_private *priv)
>  	return bResult;
>  }
>  
> -void CARDvSafeResetTx(truct vnt_private *priv)
> +void CARDvSafeResetTx(struct vnt_private *priv)

Are you sure about this patch???

Re: [Outreachy kernel] [PATCH v3] Staging: vt6655: Alignment of function declaration

[Julia Lawall]

On Wed, 27 Feb 2019, Madhumitha Prabakaran wrote:

> Align function arguments and function type to improve readability.
>
> Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
> ---
> Changes in v3-
> -Included driver name in subject line
>
> Changes in v2-
> - Modified subject line and commit log
> ---
>  drivers/staging/vt6655/card.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
> index 2996bf614caa..8d0182f5725c 100644
> --- a/drivers/staging/vt6655/card.c
> +++ b/drivers/staging/vt6655/card.c
> @@ -499,7 +499,7 @@ bool CARDbRadioPowerOn(struct vnt_private *priv)
>  	return bResult;
>  }
>
> -void CARDvSafeResetTx(truct vnt_private *priv)

This is invalid code and clearly was not in the kernel previously.  I
think that you are making your changes based on some change you previously
made, rather than based on the code in Greg's tree.

julia

> +void CARDvSafeResetTx(struct vnt_private *priv)
>  {
>  	unsigned int uu;
>  	struct vnt_tx_desc *pCurrTD;
> --
> 2.17.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190227161227.22128-1-madhumithabiw%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>