* [PATCH v2] Staging: vt6655: Modify comment style for SPDX License Identifier @ 2019-02-26 21:55 Madhumitha Prabakaran 2019-02-27 14:48 ` Greg KH 0 siblings, 1 reply; 8+ messages in thread From: Madhumitha Prabakaran @ 2019-02-26 21:55 UTC (permalink / raw) To: forest, gregkh, outreachy-kernel; +Cc: Madhumitha Prabakaran FIx the warning by changing comment style based on header file type as per License identifier syntax Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com> --- Changes in v2 - Modified subject line and commit log drivers/staging/vt6655/baseband.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vt6655/baseband.h b/drivers/staging/vt6655/baseband.h index f2b6a98de2c1..0cc2e07829c5 100644 --- a/drivers/staging/vt6655/baseband.h +++ b/drivers/staging/vt6655/baseband.h @@ -1,4 +1,4 @@ -* SPDX-License-Identifier: GPL-2.0+ */ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. -- 2.17.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2] Staging: vt6655: Modify comment style for SPDX License Identifier 2019-02-26 21:55 [PATCH v2] Staging: vt6655: Modify comment style for SPDX License Identifier Madhumitha Prabakaran @ 2019-02-27 14:48 ` Greg KH 2019-02-27 16:43 ` Madhumthia Prabakaran 0 siblings, 1 reply; 8+ messages in thread From: Greg KH @ 2019-02-27 14:48 UTC (permalink / raw) To: Madhumitha Prabakaran; +Cc: forest, outreachy-kernel On Tue, Feb 26, 2019 at 03:55:31PM -0600, Madhumitha Prabakaran wrote: > FIx the warning by changing comment style based on header file type as > per License identifier syntax > > Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com> > --- > Changes in v2 > - Modified subject line and commit log > > drivers/staging/vt6655/baseband.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/vt6655/baseband.h b/drivers/staging/vt6655/baseband.h > index f2b6a98de2c1..0cc2e07829c5 100644 > --- a/drivers/staging/vt6655/baseband.h > +++ b/drivers/staging/vt6655/baseband.h > @@ -1,4 +1,4 @@ > -* SPDX-License-Identifier: GPL-2.0+ */ > +/* SPDX-License-Identifier: GPL-2.0+ */ This patch does not apply to my tree :( ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] Staging: vt6655: Modify comment style for SPDX License Identifier 2019-02-27 14:48 ` Greg KH @ 2019-02-27 16:43 ` Madhumthia Prabakaran 2019-02-27 17:05 ` Greg KH 2019-02-27 19:46 ` [Outreachy kernel] " Julia Lawall 0 siblings, 2 replies; 8+ messages in thread From: Madhumthia Prabakaran @ 2019-02-27 16:43 UTC (permalink / raw) To: Greg KH, forest, outreachy-kernel On Wed, Feb 27, 2019 at 03:48:36PM +0100, Greg KH wrote: > On Tue, Feb 26, 2019 at 03:55:31PM -0600, Madhumitha Prabakaran wrote: > > FIx the warning by changing comment style based on header file type as > > per License identifier syntax > > > > Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com> > > --- > > Changes in v2 > > - Modified subject line and commit log > > > > drivers/staging/vt6655/baseband.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/staging/vt6655/baseband.h b/drivers/staging/vt6655/baseband.h > > index f2b6a98de2c1..0cc2e07829c5 100644 > > --- a/drivers/staging/vt6655/baseband.h > > +++ b/drivers/staging/vt6655/baseband.h > > @@ -1,4 +1,4 @@ > > -* SPDX-License-Identifier: GPL-2.0+ */ > > +/* SPDX-License-Identifier: GPL-2.0+ */ > > This patch does not apply to my tree :( > I didn't understand why it doesn't apply to your tree. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] Staging: vt6655: Modify comment style for SPDX License Identifier 2019-02-27 16:43 ` Madhumthia Prabakaran @ 2019-02-27 17:05 ` Greg KH 2019-02-27 17:10 ` Madhumthia Prabakaran 2019-02-27 19:46 ` [Outreachy kernel] " Julia Lawall 1 sibling, 1 reply; 8+ messages in thread From: Greg KH @ 2019-02-27 17:05 UTC (permalink / raw) To: Madhumthia Prabakaran; +Cc: forest, outreachy-kernel On Wed, Feb 27, 2019 at 10:43:29AM -0600, Madhumthia Prabakaran wrote: > On Wed, Feb 27, 2019 at 03:48:36PM +0100, Greg KH wrote: > > On Tue, Feb 26, 2019 at 03:55:31PM -0600, Madhumitha Prabakaran wrote: > > > FIx the warning by changing comment style based on header file type as > > > per License identifier syntax > > > > > > Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com> > > > --- > > > Changes in v2 > > > - Modified subject line and commit log > > > > > > drivers/staging/vt6655/baseband.h | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/staging/vt6655/baseband.h b/drivers/staging/vt6655/baseband.h > > > index f2b6a98de2c1..0cc2e07829c5 100644 > > > --- a/drivers/staging/vt6655/baseband.h > > > +++ b/drivers/staging/vt6655/baseband.h > > > @@ -1,4 +1,4 @@ > > > -* SPDX-License-Identifier: GPL-2.0+ */ > > > +/* SPDX-License-Identifier: GPL-2.0+ */ > > > > This patch does not apply to my tree :( > > > > > I didn't understand why it doesn't apply to your tree. > Neither do I :) Please try rebasing your patch on the top of my staging-testing branch and see if that produces a different patch or not. If it does, please resend. thanks, greg k-h ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] Staging: vt6655: Modify comment style for SPDX License Identifier 2019-02-27 17:05 ` Greg KH @ 2019-02-27 17:10 ` Madhumthia Prabakaran 2019-02-27 17:33 ` Greg KH 0 siblings, 1 reply; 8+ messages in thread From: Madhumthia Prabakaran @ 2019-02-27 17:10 UTC (permalink / raw) To: Greg KH, forest, outreachy-kernel On Wed, Feb 27, 2019 at 06:05:14PM +0100, Greg KH wrote: > On Wed, Feb 27, 2019 at 10:43:29AM -0600, Madhumthia Prabakaran wrote: > > On Wed, Feb 27, 2019 at 03:48:36PM +0100, Greg KH wrote: > > > On Tue, Feb 26, 2019 at 03:55:31PM -0600, Madhumitha Prabakaran wrote: > > > > FIx the warning by changing comment style based on header file type as > > > > per License identifier syntax > > > > > > > > Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com> > > > > --- > > > > Changes in v2 > > > > - Modified subject line and commit log > > > > > > > > drivers/staging/vt6655/baseband.h | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/staging/vt6655/baseband.h b/drivers/staging/vt6655/baseband.h > > > > index f2b6a98de2c1..0cc2e07829c5 100644 > > > > --- a/drivers/staging/vt6655/baseband.h > > > > +++ b/drivers/staging/vt6655/baseband.h > > > > @@ -1,4 +1,4 @@ > > > > -* SPDX-License-Identifier: GPL-2.0+ */ > > > > +/* SPDX-License-Identifier: GPL-2.0+ */ > > > > > > This patch does not apply to my tree :( > > > > > > > > > I didn't understand why it doesn't apply to your tree. > > > > Neither do I :) > > Please try rebasing your patch on the top of my staging-testing branch > and see if that produces a different patch or not. If it does, please > resend. > > thanks, > > greg k-h I will rebase it and send it again. Also, I want to make sure whether you got a similar patch with same commit log or not. Thanks, Madhumitha ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] Staging: vt6655: Modify comment style for SPDX License Identifier 2019-02-27 17:10 ` Madhumthia Prabakaran @ 2019-02-27 17:33 ` Greg KH 2019-02-27 17:42 ` Madhumthia Prabakaran 0 siblings, 1 reply; 8+ messages in thread From: Greg KH @ 2019-02-27 17:33 UTC (permalink / raw) To: Madhumthia Prabakaran; +Cc: forest, outreachy-kernel On Wed, Feb 27, 2019 at 11:10:23AM -0600, Madhumthia Prabakaran wrote: > On Wed, Feb 27, 2019 at 06:05:14PM +0100, Greg KH wrote: > > On Wed, Feb 27, 2019 at 10:43:29AM -0600, Madhumthia Prabakaran wrote: > > > On Wed, Feb 27, 2019 at 03:48:36PM +0100, Greg KH wrote: > > > > On Tue, Feb 26, 2019 at 03:55:31PM -0600, Madhumitha Prabakaran wrote: > > > > > FIx the warning by changing comment style based on header file type as > > > > > per License identifier syntax > > > > > > > > > > Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com> > > > > > --- > > > > > Changes in v2 > > > > > - Modified subject line and commit log > > > > > > > > > > drivers/staging/vt6655/baseband.h | 2 +- > > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > > diff --git a/drivers/staging/vt6655/baseband.h b/drivers/staging/vt6655/baseband.h > > > > > index f2b6a98de2c1..0cc2e07829c5 100644 > > > > > --- a/drivers/staging/vt6655/baseband.h > > > > > +++ b/drivers/staging/vt6655/baseband.h > > > > > @@ -1,4 +1,4 @@ > > > > > -* SPDX-License-Identifier: GPL-2.0+ */ > > > > > +/* SPDX-License-Identifier: GPL-2.0+ */ > > > > > > > > This patch does not apply to my tree :( > > > > > > > > > > > > > I didn't understand why it doesn't apply to your tree. > > > > > > > Neither do I :) > > > > Please try rebasing your patch on the top of my staging-testing branch > > and see if that produces a different patch or not. If it does, please > > resend. > > > > thanks, > > > > greg k-h > > > I will rebase it and send it again. > > Also, I want to make sure whether you got a similar patch with same commit log or not. I have no idea. Remember, I get over 1000 emails a day to do something with, I have the short-term memory of a squirrel and have no idea if someone has sent something prior to this at all, sorry. It is your job as a patch submitter to make it as easy as possible for me to apply patches. Sometimes that requires extra work, and rebasing patches due to other people's patches colliding with your work. That's just part of the development process. thanks, greg k-h ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] Staging: vt6655: Modify comment style for SPDX License Identifier 2019-02-27 17:33 ` Greg KH @ 2019-02-27 17:42 ` Madhumthia Prabakaran 0 siblings, 0 replies; 8+ messages in thread From: Madhumthia Prabakaran @ 2019-02-27 17:42 UTC (permalink / raw) To: Greg KH, forest, outreachy-kernel On Wed, Feb 27, 2019 at 06:33:02PM +0100, Greg KH wrote: > On Wed, Feb 27, 2019 at 11:10:23AM -0600, Madhumthia Prabakaran wrote: > > On Wed, Feb 27, 2019 at 06:05:14PM +0100, Greg KH wrote: > > > On Wed, Feb 27, 2019 at 10:43:29AM -0600, Madhumthia Prabakaran wrote: > > > > On Wed, Feb 27, 2019 at 03:48:36PM +0100, Greg KH wrote: > > > > > On Tue, Feb 26, 2019 at 03:55:31PM -0600, Madhumitha Prabakaran wrote: > > > > > > FIx the warning by changing comment style based on header file type as > > > > > > per License identifier syntax > > > > > > > > > > > > Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com> > > > > > > --- > > > > > > Changes in v2 > > > > > > - Modified subject line and commit log > > > > > > > > > > > > drivers/staging/vt6655/baseband.h | 2 +- > > > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > > > > diff --git a/drivers/staging/vt6655/baseband.h b/drivers/staging/vt6655/baseband.h > > > > > > index f2b6a98de2c1..0cc2e07829c5 100644 > > > > > > --- a/drivers/staging/vt6655/baseband.h > > > > > > +++ b/drivers/staging/vt6655/baseband.h > > > > > > @@ -1,4 +1,4 @@ > > > > > > -* SPDX-License-Identifier: GPL-2.0+ */ > > > > > > +/* SPDX-License-Identifier: GPL-2.0+ */ > > > > > > > > > > This patch does not apply to my tree :( > > > > > > > > > > > > > > > > > I didn't understand why it doesn't apply to your tree. > > > > > > > > > > Neither do I :) > > > > > > Please try rebasing your patch on the top of my staging-testing branch > > > and see if that produces a different patch or not. If it does, please > > > resend. > > > > > > thanks, > > > > > > greg k-h > > > > > > I will rebase it and send it again. > > > > Also, I want to make sure whether you got a similar patch with same commit log or not. > > I have no idea. > > Remember, I get over 1000 emails a day to do something with, I have the > short-term memory of a squirrel and have no idea if someone has sent > something prior to this at all, sorry. > > It is your job as a patch submitter to make it as easy as possible for > me to apply patches. Sometimes that requires extra work, and rebasing > patches due to other people's patches colliding with your work. That's > just part of the development process. > > thanks, > > greg k-h No problem, I understand. I will rebase it and send it again. Thanks, Madhumitha ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Outreachy kernel] Re: [PATCH v2] Staging: vt6655: Modify comment style for SPDX License Identifier 2019-02-27 16:43 ` Madhumthia Prabakaran 2019-02-27 17:05 ` Greg KH @ 2019-02-27 19:46 ` Julia Lawall 1 sibling, 0 replies; 8+ messages in thread From: Julia Lawall @ 2019-02-27 19:46 UTC (permalink / raw) To: Madhumthia Prabakaran; +Cc: Greg KH, forest, outreachy-kernel On Wed, 27 Feb 2019, Madhumthia Prabakaran wrote: > On Wed, Feb 27, 2019 at 03:48:36PM +0100, Greg KH wrote: > > On Tue, Feb 26, 2019 at 03:55:31PM -0600, Madhumitha Prabakaran wrote: > > > FIx the warning by changing comment style based on header file type as > > > per License identifier syntax > > > > > > Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com> > > > --- > > > Changes in v2 > > > - Modified subject line and commit log > > > > > > drivers/staging/vt6655/baseband.h | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/staging/vt6655/baseband.h b/drivers/staging/vt6655/baseband.h > > > index f2b6a98de2c1..0cc2e07829c5 100644 > > > --- a/drivers/staging/vt6655/baseband.h > > > +++ b/drivers/staging/vt6655/baseband.h > > > @@ -1,4 +1,4 @@ > > > -* SPDX-License-Identifier: GPL-2.0+ */ > > > +/* SPDX-License-Identifier: GPL-2.0+ */ > > > > This patch does not apply to my tree :( > > > > > I didn't understand why it doesn't apply to your tree. The - line is not a valid comment. That is surely not what there was before in the kernel. julia > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190227164328.GB22354%40madhuleo. > For more options, visit https://groups.google.com/d/optout. > ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-02-27 19:46 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-02-26 21:55 [PATCH v2] Staging: vt6655: Modify comment style for SPDX License Identifier Madhumitha Prabakaran 2019-02-27 14:48 ` Greg KH 2019-02-27 16:43 ` Madhumthia Prabakaran 2019-02-27 17:05 ` Greg KH 2019-02-27 17:10 ` Madhumthia Prabakaran 2019-02-27 17:33 ` Greg KH 2019-02-27 17:42 ` Madhumthia Prabakaran 2019-02-27 19:46 ` [Outreachy kernel] " Julia Lawall
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.